deps: V8: backports for gcc 12 by richardlau · Pull Request #52183 · nodejs/node

richardlau · 2024-03-21T19:42:44Z

Original commit message:

Fix build with older versions of GCC.
This ports the change from bazel on v8:
https://crrev.com/c/3368869
Compilation errors started showing after this CL:
https://crrev.com/c/5199515
Change-Id: I8c161a0d9ad5c04d452c444ef4feafae2ef4f6db
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5280535
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/main@{#92252}

Refs: v8/v8@f8d5e57

Original commit message:

Fix build with gcc12
- A number of erroneous flags have been added to BUILD.gn
- wasm-init-expr.cc is creating an 8 byte buffer witch may be
much smaller than max size_t output. We also need to make room
for the `f` character and the terminating null character
- inspector_protocol currently generates the following error
```
error: loop variable ‘json_in’ of type ‘const std::string&’ {aka
‘const std::__cxx11::basic_string<char>&’} binds to a temporary
constructed from type ‘const char* const’
```
Change-Id: I1139899b2664e47d01ebc44f2e972fc4c0ec212d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5331756
Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/main@{#92615}

Refs: v8/v8@c4be0a9

nodejs-github-bot · 2024-03-21T19:42:48Z

Review requested:

@nodejs/gyp
@nodejs/security-wg
@nodejs/v8-update

Original commit message: Fix build with older versions of GCC. This ports the change from bazel on v8: https://crrev.com/c/3368869 Compilation errors started showing after this CL: https://crrev.com/c/5199515 Change-Id: I8c161a0d9ad5c04d452c444ef4feafae2ef4f6db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5280535 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#92252} Refs: v8/v8@f8d5e57

Original commit message: Fix build with gcc12 - A number of erroneous flags have been added to BUILD.gn - wasm-init-expr.cc is creating an 8 byte buffer witch may be much smaller than max size_t output. We also need to make room for the `f` character and the terminating null character - inspector_protocol currently generates the following error ``` error: loop variable ‘json_in’ of type ‘const std::string&’ {aka ‘const std::__cxx11::basic_string<char>&’} binds to a temporary constructed from type ‘const char* const’ ``` Change-Id: I1139899b2664e47d01ebc44f2e972fc4c0ec212d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5331756 Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#92615} Refs: v8/v8@c4be0a9

nodejs-github-bot · 2024-03-21T21:54:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57882/

nodejs-github-bot · 2024-03-21T21:54:54Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5865/

nodejs-github-bot · 2024-03-21T21:54:54Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5865/

nodejs-github-bot · 2024-03-21T21:56:59Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5865/

nodejs-github-bot · 2024-03-22T00:33:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57884/

nodejs-github-bot · 2024-03-22T02:36:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57886/

nodejs-github-bot · 2024-03-22T03:44:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57888/

nodejs-github-bot · 2024-03-22T04:12:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57890/

nodejs-github-bot · 2024-03-23T19:49:44Z

Landed in 305375a...f6996ee

Original commit message: Fix build with older versions of GCC. This ports the change from bazel on v8: https://crrev.com/c/3368869 Compilation errors started showing after this CL: https://crrev.com/c/5199515 Change-Id: I8c161a0d9ad5c04d452c444ef4feafae2ef4f6db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5280535 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#92252} Refs: v8/v8@f8d5e57 PR-URL: #52183 Refs: v8/v8@c4be0a9 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: Fix build with gcc12 - A number of erroneous flags have been added to BUILD.gn - wasm-init-expr.cc is creating an 8 byte buffer witch may be much smaller than max size_t output. We also need to make room for the `f` character and the terminating null character - inspector_protocol currently generates the following error ``` error: loop variable ‘json_in’ of type ‘const std::string&’ {aka ‘const std::__cxx11::basic_string<char>&’} binds to a temporary constructed from type ‘const char* const’ ``` Change-Id: I1139899b2664e47d01ebc44f2e972fc4c0ec212d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5331756 Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#92615} Refs: v8/v8@c4be0a9 PR-URL: #52183 Refs: v8/v8@f8d5e57 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: Fix build with older versions of GCC. This ports the change from bazel on v8: https://crrev.com/c/3368869 Compilation errors started showing after this CL: https://crrev.com/c/5199515 Change-Id: I8c161a0d9ad5c04d452c444ef4feafae2ef4f6db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5280535 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#92252} Refs: v8/v8@f8d5e57 PR-URL: nodejs#52183 Refs: v8/v8@c4be0a9 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: Fix build with gcc12 - A number of erroneous flags have been added to BUILD.gn - wasm-init-expr.cc is creating an 8 byte buffer witch may be much smaller than max size_t output. We also need to make room for the `f` character and the terminating null character - inspector_protocol currently generates the following error ``` error: loop variable ‘json_in’ of type ‘const std::string&’ {aka ‘const std::__cxx11::basic_string<char>&’} binds to a temporary constructed from type ‘const char* const’ ``` Change-Id: I1139899b2664e47d01ebc44f2e972fc4c0ec212d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5331756 Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#92615} Refs: v8/v8@c4be0a9 PR-URL: nodejs#52183 Refs: v8/v8@f8d5e57 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: Fix build with older versions of GCC. This ports the change from bazel on v8: https://crrev.com/c/3368869 Compilation errors started showing after this CL: https://crrev.com/c/5199515 Change-Id: I8c161a0d9ad5c04d452c444ef4feafae2ef4f6db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5280535 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#92252} Refs: v8/v8@f8d5e57 PR-URL: #52183 Refs: v8/v8@c4be0a9 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> PR-URL: #51362 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Original commit message: Fix build with gcc12 - A number of erroneous flags have been added to BUILD.gn - wasm-init-expr.cc is creating an 8 byte buffer witch may be much smaller than max size_t output. We also need to make room for the `f` character and the terminating null character - inspector_protocol currently generates the following error ``` error: loop variable ‘json_in’ of type ‘const std::string&’ {aka ‘const std::__cxx11::basic_string<char>&’} binds to a temporary constructed from type ‘const char* const’ ``` Change-Id: I1139899b2664e47d01ebc44f2e972fc4c0ec212d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5331756 Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#92615} Refs: v8/v8@c4be0a9 PR-URL: #52183 Refs: v8/v8@f8d5e57 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> PR-URL: #51362 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Original commit message: Fix build with gcc12 - A number of erroneous flags have been added to BUILD.gn - wasm-init-expr.cc is creating an 8 byte buffer witch may be much smaller than max size_t output. We also need to make room for the `f` character and the terminating null character - inspector_protocol currently generates the following error ``` error: loop variable ‘json_in’ of type ‘const std::string&’ {aka ‘const std::__cxx11::basic_string<char>&’} binds to a temporary constructed from type ‘const char* const’ ``` Change-Id: I1139899b2664e47d01ebc44f2e972fc4c0ec212d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5331756 Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#92615} Refs: v8/v8@c4be0a9 PR-URL: nodejs#52183 Refs: v8/v8@f8d5e57 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: Fix build with gcc12 - A number of erroneous flags have been added to BUILD.gn - wasm-init-expr.cc is creating an 8 byte buffer witch may be much smaller than max size_t output. We also need to make room for the `f` character and the terminating null character - inspector_protocol currently generates the following error ``` error: loop variable ‘json_in’ of type ‘const std::string&’ {aka ‘const std::__cxx11::basic_string<char>&’} binds to a temporary constructed from type ‘const char* const’ ``` Change-Id: I1139899b2664e47d01ebc44f2e972fc4c0ec212d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5331756 Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#92615} Refs: v8/v8@c4be0a9 PR-URL: #52183 Refs: v8/v8@f8d5e57 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> PR-URL: #52293 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>

Original commit message: Fix build with older versions of GCC. This ports the change from bazel on v8: https://crrev.com/c/3368869 Compilation errors started showing after this CL: https://crrev.com/c/5199515 Change-Id: I8c161a0d9ad5c04d452c444ef4feafae2ef4f6db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5280535 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#92252} Refs: v8/v8@f8d5e57 PR-URL: #52183 Refs: v8/v8@c4be0a9 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Original commit message: Fix build with gcc12 - A number of erroneous flags have been added to BUILD.gn - wasm-init-expr.cc is creating an 8 byte buffer witch may be much smaller than max size_t output. We also need to make room for the `f` character and the terminating null character - inspector_protocol currently generates the following error ``` error: loop variable ‘json_in’ of type ‘const std::string&’ {aka ‘const std::__cxx11::basic_string<char>&’} binds to a temporary constructed from type ‘const char* const’ ``` Change-Id: I1139899b2664e47d01ebc44f2e972fc4c0ec212d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5331756 Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#92615} Refs: v8/v8@c4be0a9 PR-URL: #52183 Refs: v8/v8@f8d5e57 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Mar 21, 2024

This was referenced Mar 21, 2024
use gcc 12 on rhel8-s390x for Node.js 22 nodejs/build#3659
Merged
Update compiler on Linux s390x nodejs/build#3630
Closed

richardlau added 2 commits March 21, 2024 20:07

richardlau force-pushed the v8-gcc12 branch from 639e481 to d1cb8c1Compare March 21, 2024 20:14

richardlau changed the title ~~deps: V8: backport c4be0a97f981~~deps: V8: backports for gcc 12Mar 21, 2024

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2024

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2024

gengjiawen approved these changes Mar 22, 2024
View reviewed changes

richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2024

marco-ippolito approved these changes Mar 22, 2024
View reviewed changes

targos approved these changes Mar 22, 2024
View reviewed changes

lpinca approved these changes Mar 22, 2024
View reviewed changes

richardlau added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Mar 22, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 23, 2024

nodejs-github-bot closed this Mar 23, 2024

richardlau deleted the v8-gcc12 branch March 23, 2024 19:50

RafaelGSS mentioned this pull request Apr 15, 2024
2024-04-24, Version 22.0.0 (Current) #52505
Merged

marco-ippolito mentioned this pull request May 23, 2024
v20.14.0 proposal #53120
Merged

Navigation Menu

Uh oh!

Uh oh!

deps: V8: backports for gcc 12 - #52183

deps: V8: backports for gcc 12#52183
richardlau wants to merge 2 commits into
nodejs:mainfrom
richardlau:v8-gcc12

richardlau commented Mar 21, 2024•
edited
Loading

Uh oh!

nodejs-github-bot commented Mar 21, 2024

Uh oh!

nodejs-github-bot commented Mar 21, 2024

Uh oh!

nodejs-github-bot commented Mar 21, 2024

Uh oh!

nodejs-github-bot commented Mar 21, 2024

Uh oh!

nodejs-github-bot commented Mar 21, 2024

Uh oh!

nodejs-github-bot commented Mar 22, 2024

Uh oh!

nodejs-github-bot commented Mar 22, 2024

Uh oh!

nodejs-github-bot commented Mar 22, 2024

Uh oh!

nodejs-github-bot commented Mar 22, 2024

Uh oh!

nodejs-github-bot commented Mar 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

richardlau commented Mar 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 21, 2024

Uh oh!

nodejs-github-bot commented Mar 21, 2024

Uh oh!

nodejs-github-bot commented Mar 21, 2024

Uh oh!

nodejs-github-bot commented Mar 21, 2024

Uh oh!

nodejs-github-bot commented Mar 21, 2024

Uh oh!

nodejs-github-bot commented Mar 22, 2024

Uh oh!

nodejs-github-bot commented Mar 22, 2024

Uh oh!

nodejs-github-bot commented Mar 22, 2024

Uh oh!

nodejs-github-bot commented Mar 22, 2024

Uh oh!

nodejs-github-bot commented Mar 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

richardlau commented Mar 21, 2024•
edited
Loading