Uh oh!
There was an error while loading. Please reload this page.
tools: run test-asan on ubuntu-24.04 - #52374
Conversation
nodejs-github-bot
commented
Apr 5, 2024
Review requested:
|
If it still fails, I hope we can use this PR to collaborate on finding a real fix for #45578. |
targos
commented
Apr 5, 2024
Details |
aduh95
commented
Apr 7, 2024
/cc @nodejs/single-executable |
targos
commented
Apr 8, 2024
I hoped to get more information from a debug build but it's not reproducible with it! |
aduh95
commented
Apr 8, 2024
Should we try with |
targos
commented
Apr 9, 2024
|
targos
commented
Apr 9, 2024
I suggest to wait for #52406 and retry. |
anonrig
commented
Apr 10, 2024
targos
commented
Apr 10, 2024
Guess based on the stack trace: |
targos
commented
Apr 17, 2024
@nodejs/cpp-reviewers Does this make sense to you? |
targos
commented
Apr 17, 2024
What I understand is it points to Lines 119 to 123 in 97627da Where an array is allocated. Then somewhere we use |
lemire
commented
Apr 17, 2024
lemire
commented
Apr 18, 2024
What I see are reports about an issue in old code contributed by @addaleax It seems unclear to me (though not impossible) there there is a defect in this code. Possibly we are encountering a false positive. |
lemire
commented
Apr 18, 2024
Something does not add up. The trace has... But |
nodejs-github-bot
commented
Apr 18, 2024
lemire
commented
Apr 19, 2024
Let us try to rerun the tests. |
targos
commented
Apr 23, 2024
rebased |
targos
commented
Apr 24, 2024
Since the problem only happens with SEA tests, where the binary is patched, it's possible that the debug output is a red herring. |
lemire
commented
Apr 24, 2024
Right. So we are being mislead as to where the issue is actually happening? |
targos
commented
Apr 24, 2024
It's a hypothesis. I don't really know what's happening. |
targos
commented
May 16, 2024
Oh, results with latest Clang are much more interesting! https://github.com/nodejs/node/actions/runs/9106598364/job/25034057819?pr=52374 |
targos
commented
May 21, 2024
Here are all the errors from the above actions run |
It is running on ubuntu-20.04, which will inevitably be removed from GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04 and ubuntu-24.04 have failed. It is now blocking V8 updates because of errors that happen only with the `test-asan` job. Refs: nodejs#52374 Refs: nodejs#53651 (comment)
It is running on ubuntu-20.04, which will inevitably be removed from GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04 and ubuntu-24.04 have failed. It is now blocking V8 updates because of errors that happen only with the `test-asan` job. Refs: #52374 Refs: #53651 (comment) PR-URL: #53844 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
It is running on ubuntu-20.04, which will inevitably be removed from GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04 and ubuntu-24.04 have failed. It is now blocking V8 updates because of errors that happen only with the `test-asan` job. Refs: nodejs#52374 Refs: nodejs#53651 (comment) PR-URL: nodejs#53844 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
It is running on ubuntu-20.04, which will inevitably be removed from GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04 and ubuntu-24.04 have failed. It is now blocking V8 updates because of errors that happen only with the `test-asan` job. Refs: #52374 Refs: #53651 (comment) PR-URL: #53844 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
It is running on ubuntu-20.04, which will inevitably be removed from GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04 and ubuntu-24.04 have failed. It is now blocking V8 updates because of errors that happen only with the `test-asan` job. Refs: #52374 Refs: #53651 (comment) PR-URL: #53844 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closes: #45578
The only way to know if it works is to try.