Uh oh!
There was an error while loading. Please reload this page.
repl: print errors in red - #52503
Conversation
avivkeller
commented
Apr 12, 2024
The tests failed due to them not prepared for the color scheme. I can change them once this PR is approved/reveiwed |
lemire
commented
Apr 12, 2024
I don't know what others think, but I personally think that it would be best to also change the tests. |
avivkeller
commented
Apr 12, 2024
The only issue with this (so far) is that when the user
But, the user would have to directly throw an object within the REPL, which almost never happens |
avivkeller
commented
Apr 12, 2024
I'm not quite sure what went wrong here |
Uh oh!
There was an error while loading. Please reload this page.
avivkeller
commented
Apr 13, 2024
I don't think I'll end up merging this PR, as I'm trying to merge nodejs/repl into the main NodeJS, which will redo all of this anyway.
|
This change will have NodeJS REPLs print errors in red, so that they are easily distinguishable from traditional loggings. This change will not affect
console.error