Uh oh!
There was an error while loading. Please reload this page.
Drop Some Dependencies - #54
Conversation
avivkeller
commented
Apr 13, 2024
After some hard work, I managed to (in my PR): Drop Dependencies (The main goal)
Little FixesThese just came up when I was updating the codebase
|
avivkeller
commented
Apr 13, 2024
|
VoltrexKeyva
commented
Apr 13, 2024
What is the reason for removing the development dependencies ( |
avivkeller
commented
Apr 13, 2024
Oops! That must've been my bad, sorry! I'll fix it now |
devsnek
commented
Apr 13, 2024
why? using |
avivkeller
commented
Apr 13, 2024
As far as I could tell, |
The latest commits allows the preview of the line to preview based on the autofill, similar to how nodejs does it. |
avivkeller
commented
Apr 13, 2024
@devsnek, if you remember any other bugs, I can work on fixing them as well (if you don't mind) |
(and make some little changes)
avivkeller
commented
Apr 14, 2024
If I find any other bug fixes, would you prefer I stash them locally and wait for this PR to be resolved, or just push them into this? |
avivkeller
commented
Apr 16, 2024
Hi, @devsnek; sorry for bugging you (again), but how are you feeling about this PR. I'd love some feedback so I can make it (and my other PRs) better for the future! |
This PR drops a few dependencies to make this package smaller. This will help with the eventual movement to include this in NodeJS core.
This PR does NOT drop emphasize (5.5MB)
See nodejs/node#52510