src: sync NODE_REPL_EXTERNAL_MODULE and kDisableNodeOptionsEnv

[RafaelGSS]

Fixes: #51227

Currently, I'm throwing kBootstrapError, but I'm almost sure this is not the appropriate error. In this case, should I create a new error?

Technically, this is a fix for kDisableNodeOptionsEnv, but it can be considered a breaking change for the ones relying on the current behavior (which is unlikely).

[nodejs-github-bot]

Review requested:

• @nodejs/startup

[avivkeller]

IMO if it's a breaking change it should be semver-minor or notable-change

(But as a triage member, this isn't my decision, nor my place)

[github-actions]

Failed to start CI

 ⚠ No approving reviews found
✘ Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/9008046172

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59055/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59062/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59085/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59173/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59198/

[Trott]

No opinion from me on semver for this, but the code change LGTM.

[Trott]

No opinion from me on semver for this, but the code change LGTM.

Actually, with a little more thought, I think this is semver patch, so I agree with @RafaelGSS. But I'll defer to Releasers who think otherwise or collaborators more knowledgable about how these features are used.

[avivkeller]

No opinion from me on semver for this, but the code change LGTM.

Actually, with a little more thought, I think this is semver patch

Whatever you say I'm happy with, I'm not a collaborator, so I really don't have much of an opinion (and experience) to really weigh in

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59247/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59267/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59352/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/52905
✔ Done loading data for nodejs/node/pull/52905
----------------------------------- PR info ------------------------------------
Title src: sync NODE_REPL_EXTERNAL_MODULE and kDisableNodeOptionsEnv (#52905)
Author Rafael Gonzaga (@RafaelGSS)
Branch RafaelGSS:disable-external-module -> nodejs:main
Labels c++, repl, author ready, needs-ci, commit-queue-squash
Commits 2
- src: fix external module env and kDisableNodeOptionsEnv
- fixup! src: fix external module env and kDisableNodeOptionsEnv
Committers 1
- RafaelGSS PR-URL: https://github.com/nodejs/node/pull/52905
Fixes: https://github.com/nodejs/node/issues/51227
Reviewed-By: Rich Trott Reviewed-By: Joyee Cheung ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52905
Fixes: https://github.com/nodejs/node/issues/51227
Reviewed-By: Rich Trott Reviewed-By: Joyee Cheung --------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - fixup! src: fix external module env and kDisableNodeOptionsEnv
ℹ This PR was created on Wed, 08 May 2024 17:55:32 GMT
✔ Approvals: 2
✔ - Rich Trott (@Trott): https://github.com/nodejs/node/pull/52905#pullrequestreview-2056494543
✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/52905#pullrequestreview-2069699196
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2024-05-22T14:10:03Z: https://ci.nodejs.org/job/node-test-pull-request/59352/
- Querying data for job/node-test-pull-request/59352/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/9200620708

[nodejs-github-bot]

Landed in b9ad94b