Uh oh!
There was an error while loading. Please reload this page.
test: fix Windows native test suites - #53173
Merged
nodejs-github-bot merged 1 commit intoMay 27, 2024
Merged
Conversation
Contributor
Fast-track has been requested by @StefanStojanovic. Please 👍 to approve. |
targos
approved these changes
May 27, 2024
targos
left a comment
Member
There was a problem hiding this comment.
LGTM if an issue is open so we don't forget to fix it.
StefanStojanovic
commented
May 27, 2024
ContributorAuthor
I stumbled upon this issue while working on nodejs/build#3739, but I'm not sure this should close it (I thought changes I made yesterday would be enough, but this popped up), so I'll monitor the CI for few days after all is back to normal and close the issue manually. At least that's the plan. |
targos
commented
May 27, 2024
Member
I mean an issue about fixing and re-enabling the test on Windows |
joyeecheung
approved these changes
May 27, 2024
joyeecheung
commented
May 27, 2024
Member
Hmm, it seems strange why the test case is failing on Windows, AFAICT there isn't anything Windows specific about the test case. But let's skip it on Windows for now to unbreak CI first. |
anonrig
reviewed
May 27, 2024
Uh oh!
There was an error while loading. Please reload this page.
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: nodejs#52905 Refs: nodejs#52646
StefanStojanovicforce-pushed
the
mefi-native-suites-fix
branch
from
May 27, 2024 14:10
169b0f8 to
6735452Comparenodejs-github-bot
commented
May 27, 2024
Collaborator
RafaelGSS
approved these changes
May 27, 2024
nodejs-github-bot
commented
May 27, 2024
Collaborator
nodejs-github-bot
commented
May 27, 2024
Collaborator
nodejs-github-bot
commented
May 27, 2024
Collaborator
Landed in 8e9686d |
targos pushed a commit
that referenced
this pull request
Jun 1, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: #52905 Refs: #52646 PR-URL: #53173 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
soophoo pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: nodejs#52905 Refs: nodejs#52646 PR-URL: nodejs#53173 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito pushed a commit
that referenced
this pull request
Jul 19, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: #52905 Refs: #52646 PR-URL: #53173 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4 days ago, 2 PRs that landed independently around the same time caused this issue causing every native test suite run in CI to fail on Windows. This is just a quick patch to unblock the CI.
One PR added running
test\embedding\test-embedding.json Windows, and the other one added a new test case in the same file. As it turned out, that case is failing on Windows. This is a simple fix to reenable CI as without it no PRs can be merged and a follow-on PR actually fixing this issue is welcome.I've already run my branch against the CI to make sure native suites are fixed and they are: https://ci.nodejs.org/job/node-test-commit-windows-fanned/63233/
Tagging @RafaelGSS and @vmoroz as they opened the 2 PRs in question
Refs: #52905
Refs: #52646