deps: fix V8 compilation on GCC 12 by joyeecheung · Pull Request #53728 · nodejs/node

joyeecheung · 2024-07-04T17:34:40Z

I am not sure if this is acceptable in the upstream considering they are dropping support for MSVC and GCC support would also be limited in the near future. But this should address the problem of not being able to build Node.js with GCC 12 on certain Linux distros.

EDIT: it has been merged in the upstream in https://chromium-review.googlesource.com/c/v8/v8/+/5679182

Refs: #45427
Refs: nodejs/help#4406
Refs: #53633
Refs: nodejs/help#4430
Refs: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=aeba3e009b0abfccaf01797556445dbf891cc8dc

cc @targos

nodejs-github-bot · 2024-07-04T17:34:45Z

Review requested:

@nodejs/security-wg
@nodejs/v8-update

joyeecheung · 2024-07-04T17:44:45Z

Upstreamed https://chromium-review.googlesource.com/c/v8/v8/+/5679182 to see if it's acceptable in the upstream...if not I think we should float it to prevent a hole in our GCC >= 10.1 on Linux support matrix?

richardlau · 2024-07-04T18:41:51Z

I can confirm this fixes building Node.js with the 12.2.0 gcc Docker container (main fails without this in that container, succeeds in the gcc:12.3.0 container).

joyeecheung · 2024-07-05T20:07:43Z

Extended the range check to include 12.1 which is also broken. Also changed the referenced link to the GCC fix.

Original commit message: [base] fix builds with GCC 12 on certain Linux distributions With GCC 12 on certain Linux distributions (at least Debian 12, Alpine 3.18, Fedora 37, that ships GCC 12.2), std::is_trivially_copyable is broken and as a result, V8 fails to compile. This patch uses the same polyfill on MSVC to make it compile with GCC 12.2. See nodejs#45427 for more context. Refs: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=aeba3e009b0abfccaf01797556445dbf891cc8dc Change-Id: Ie0ab1bb1ec105bacbd80b341adf7dbd8569f031f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5679182 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#95181} Refs: v8/v8@35888fe

joyeecheung · 2024-07-24T19:06:21Z

The V8 upstream patch has landed, so updated this PR to be a proper V8 backport.

Can you take a look again? Thanks! @jasnell @santigimeno @lpinca @gengjiawen @richardlau @daeyeon @legendecas

nodejs-github-bot · 2024-07-24T19:22:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/60599/

nodejs-github-bot · 2024-07-24T19:22:17Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6094/

nodejs-github-bot · 2024-07-24T19:22:47Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6094/

nodejs-github-bot · 2024-07-24T19:31:42Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6094/

nodejs-github-bot · 2024-07-25T10:08:10Z

Landed in 8027a7b

Original commit message: [base] fix builds with GCC 12 on certain Linux distributions With GCC 12 on certain Linux distributions (at least Debian 12, Alpine 3.18, Fedora 37, that ships GCC 12.2), std::is_trivially_copyable is broken and as a result, V8 fails to compile. This patch uses the same polyfill on MSVC to make it compile with GCC 12.2. See #45427 for more context. Refs: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=aeba3e009b0abfccaf01797556445dbf891cc8dc Change-Id: Ie0ab1bb1ec105bacbd80b341adf7dbd8569f031f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5679182 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#95181} Refs: v8/v8@35888fe PR-URL: #53728 Refs: #45427 Refs: nodejs/help#4406 Refs: #53633 Refs: nodejs/help#4430 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: nodejs#3806 Refs: nodejs/node#53728

Original commit message: [base] fix builds with GCC 12 on certain Linux distributions With GCC 12 on certain Linux distributions (at least Debian 12, Alpine 3.18, Fedora 37, that ships GCC 12.2), std::is_trivially_copyable is broken and as a result, V8 fails to compile. This patch uses the same polyfill on MSVC to make it compile with GCC 12.2. See #45427 for more context. Refs: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=aeba3e009b0abfccaf01797556445dbf891cc8dc Change-Id: Ie0ab1bb1ec105bacbd80b341adf7dbd8569f031f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5679182 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#95181} Refs: v8/v8@35888fe PR-URL: #53728 Refs: #45427 Refs: nodejs/help#4406 Refs: #53633 Refs: nodejs/help#4430 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: #3806 Refs: nodejs/node#53728

Original commit message: [base] fix builds with GCC 12 on certain Linux distributions With GCC 12 on certain Linux distributions (at least Debian 12, Alpine 3.18, Fedora 37, that ships GCC 12.2), std::is_trivially_copyable is broken and as a result, V8 fails to compile. This patch uses the same polyfill on MSVC to make it compile with GCC 12.2. See nodejs#45427 for more context. Refs: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=aeba3e009b0abfccaf01797556445dbf891cc8dc Change-Id: Ie0ab1bb1ec105bacbd80b341adf7dbd8569f031f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5679182 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#95181} Refs: v8/v8@35888fe PR-URL: nodejs#53728 Refs: nodejs#45427 Refs: nodejs/help#4406 Refs: nodejs#53633 Refs: nodejs/help#4430 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Original commit message: [base] fix builds with GCC 12 on certain Linux distributions With GCC 12 on certain Linux distributions (at least Debian 12, Alpine 3.18, Fedora 37, that ships GCC 12.2), std::is_trivially_copyable is broken and as a result, V8 fails to compile. This patch uses the same polyfill on MSVC to make it compile with GCC 12.2. See #45427 for more context. Refs: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=aeba3e009b0abfccaf01797556445dbf891cc8dc Change-Id: Ie0ab1bb1ec105bacbd80b341adf7dbd8569f031f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5679182 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#95181} Refs: v8/v8@35888fe PR-URL: #53728 Refs: #45427 Refs: nodejs/help#4406 Refs: #53633 Refs: nodejs/help#4430 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: #54077 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jul 4, 2024

joyeecheung force-pushed the fix-gcc-12 branch 3 times, most recently from 0a9e556 to c896192Compare July 4, 2024 18:07

richardlau approved these changes Jul 4, 2024
View reviewed changes

santigimeno approved these changes Jul 4, 2024
View reviewed changes

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024

This comment was marked as outdated.
Sign in to view

daeyeon approved these changes Jul 4, 2024
View reviewed changes

gengjiawen approved these changes Jul 5, 2024
View reviewed changes

This comment was marked as outdated.
Sign in to view

richardlau mentioned this pull request Jul 5, 2024
move minimum supported gcc to gcc 12 for Node.js 23 nodejs/build#3806
Closed

legendecas reviewed Jul 5, 2024
View reviewed changes

Comment threaddeps/v8/src/base/macros.h Outdated

lpinca approved these changes Jul 5, 2024
View reviewed changes

joyeecheung force-pushed the fix-gcc-12 branch from c896192 to 373864bCompare July 5, 2024 20:06

richardlau reviewed Jul 5, 2024
View reviewed changes

Comment threaddeps/v8/src/base/macros.h Outdated

joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 5, 2024

richardlau approved these changes Jul 5, 2024
View reviewed changes

legendecas approved these changes Jul 5, 2024
View reviewed changes

joyeecheung force-pushed the fix-gcc-12 branch from 75a4d43 to 23faf6aCompare July 24, 2024 19:05

richardlau approved these changes Jul 24, 2024
View reviewed changes

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2024

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 24, 2024

legendecas approved these changes Jul 24, 2024
View reviewed changes

gengjiawen approved these changes Jul 24, 2024
View reviewed changes

joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 25, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 25, 2024

nodejs-github-bot merged commit 8027a7b into nodejs:mainJul 25, 2024

targos added a commit to targos/nodejs-build that referenced this pull request Jul 28, 2024
ansible,jenkins: revert to default gcc-12 on debian12
7faae1f
Refs: nodejs#3806 Refs: nodejs/node#53728

targos mentioned this pull request Jul 28, 2024
ansible,jenkins: revert to default gcc-12 on debian12 nodejs/build#3845
Merged

RafaelGSS mentioned this pull request Jul 30, 2024
v22.6.0 proposal #54123
Merged

targos added a commit to nodejs/build that referenced this pull request Aug 6, 2024
ansible,jenkins: revert to default gcc-12 on debian12 (#3845)
c806876
Refs: #3806 Refs: nodejs/node#53728

targos added the dont-land-on-v20.x label Sep 21, 2024

wdconinc mentioned this pull request Dec 8, 2024
node-js: patch for %gcc@12.[1-2] when @22.2:22.5 spack/spack#47979
Merged

Uh oh!

Uh oh!

Conversation

joyeecheung commented Jul 4, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 4, 2024

Uh oh!

joyeecheung commented Jul 4, 2024

Uh oh!

richardlau commented Jul 4, 2024

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

joyeecheung commented Jul 5, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

joyeecheung commented Jul 24, 2024

Uh oh!

nodejs-github-bot commented Jul 24, 2024

Uh oh!

nodejs-github-bot commented Jul 24, 2024

Uh oh!

nodejs-github-bot commented Jul 24, 2024

Uh oh!

nodejs-github-bot commented Jul 24, 2024

Uh oh!

nodejs-github-bot commented Jul 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

joyeecheung commented Jul 4, 2024•
edited
Loading

joyeecheung commented Jul 5, 2024•
edited
Loading