Skip to content

module: use amaro default transform values - #54517

Closed
marco-ippolito wants to merge 1 commit into
nodejs:mainfrom
marco-ippolito:use-amaro-defaults
Closed

module: use amaro default transform values#54517
marco-ippolito wants to merge 1 commit into
nodejs:mainfrom
marco-ippolito:use-amaro-defaults

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Aug 23, 2024

Copy link
Copy Markdown
Member

Fixes: #54514

Moves the configuration of transformation into amaro but can always be override by node.

@nodejs/typescript

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Aug 23, 2024
@avivkelleravivkeller added blocked PRs that are blocked by other issues or PRs. strip-types Issues or PRs related to strip-types support labels Aug 23, 2024
@avivkeller

avivkeller commented Aug 23, 2024

Copy link
Copy Markdown
Member

I've added the blocked label, as this can't land until nodejs/amaro#71 does in #54520

@VoltrexKeyva

Copy link
Copy Markdown
Contributor

Removing the blockedPRs that are blocked by other issues or PRs. label as #54520 has landed.

@VoltrexKeyvaVoltrexKeyva removed the blocked PRs that are blocked by other issues or PRs. label Aug 25, 2024
@marco-ippolito
marco-ippolito marked this pull request as ready for review August 26, 2024 06:42
@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecovBot commented Aug 26, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.32%. Comparing base (1399d4e) to head (0365c1a).
Report is 323 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #54517 +/- ##
==========================================
- Coverage 87.33% 87.32% -0.02% 
==========================================
Files 649 649 Lines 182626 182622 -4 Branches 35041 35037 -4 ==========================================
- Hits 159503 159479 -24 - Misses 16394 16411 +17 - Partials 6729 6732 +3 
Files with missing linesCoverage Δ
lib/internal/modules/helpers.js97.61% <ø> (-0.03%)⬇️

... and 23 files with indirect coverage changes

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@marco-ippolitomarco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 27, 2024
@marco-ippolitomarco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 27, 2024
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 27, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/54517
✔ Done loading data for nodejs/node/pull/54517
----------------------------------- PR info ------------------------------------
Title module: use amaro default transform values (#54517)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch marco-ippolito:use-amaro-defaults -> nodejs:main
Labels module, author ready, needs-ci, strip-types
Commits 1
- module: use amaro default transform values
Committers 1
- Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/54517
Fixes: https://github.com/nodejs/node/issues/54514
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54517
Fixes: https://github.com/nodejs/node/issues/54514
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
ℹ This PR was created on Fri, 23 Aug 2024 08:02:56 GMT
✔ Approvals: 2
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/54517#pullrequestreview-2257588131
✔ - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/54517#pullrequestreview-2263527893
✘ Last GitHub CI failed
ℹ Last Full PR CI on 2024-08-27T11:46:10Z: https://ci.nodejs.org/job/node-test-pull-request/61542/
- Querying data for job/node-test-pull-request/61542/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/10580234930

@marco-ippolitomarco-ippolito removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 27, 2024
marco-ippolito added a commit that referenced this pull request Aug 27, 2024
PR-URL: #54517Fixes: #54514
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@marco-ippolito

Copy link
Copy Markdown
MemberAuthor

Landed in 5e6aab0

RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
PR-URL: #54517Fixes: #54514
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@RafaelGSSRafaelGSS mentioned this pull request Aug 30, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.moduleIssues and PRs related to the module subsystem.needs-ciPRs that need a full CI run.strip-typesIssues or PRs related to strip-types support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Module detection treats typescript import ... = require as ES module syntax

7 participants

@marco-ippolito@nodejs-github-bot@avivkeller@VoltrexKeyva@ShogunPanda@benjamingr@targos