Uh oh!
There was an error while loading. Please reload this page.
deps: update amaro to 0.1.8 - #54520
Merged
Merged
Conversation
nodejs-github-bot
commented
Aug 23, 2024
CollaboratorAuthor
Review requested:
|
marco-ippolito
approved these changes
Aug 23, 2024
marco-ippolito
commented
Aug 23, 2024
Member
this update, adds the correct default configuration https://github.com/nodejs/node/pull/54520/files#diff-2eb38b7205bf0f3655deb5fd6ce17d625dce1cfe78d204d16c89a67f35c146e6R492-R499 |
nodejs-github-bot
commented
Aug 23, 2024
CollaboratorAuthor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #54520 +/- ##
=======================================
Coverage 87.34% 87.34% =======================================
Files 649 649 Lines 182576 182576 Branches 35036 35041 +5 =======================================
+ Hits 159467 159471 +4 + Misses 16381 16379 -2 + Partials 6728 6726 -2 |
nodejs-github-bot
commented
Aug 23, 2024
CollaboratorAuthor
benjamingr
approved these changes
Aug 23, 2024
ovflowd
approved these changes
Aug 24, 2024
RafaelGSS
approved these changes
Aug 24, 2024
ovflowd
commented
Aug 24, 2024
Member
@marco-ippolito do you feel like fast-tracking this PR is necessary? |
marco-ippolito
commented
Aug 24, 2024
Member
Its ok Ivr added commit queue |
nodejs-github-bot
commented
Aug 25, 2024
CollaboratorAuthor
Landed in c3fe2d6 |
RafaelGSS pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54520 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of amaro to 0.1.8.