Skip to content

test: mark test-esm-loader-hooks-inspect-wait as flaky - #54806

Closed
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:mark-test-esm-loader-hooks-inspect-wait-flaky
Closed

test: mark test-esm-loader-hooks-inspect-wait as flaky#54806
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:mark-test-esm-loader-hooks-inspect-wait-flaky

Conversation

@jasnell

Copy link
Copy Markdown
Member

Have been unable to reproduce the failure locally.

See: #54346

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 6, 2024
@jasnell

Copy link
Copy Markdown
MemberAuthor

Hehe, looks like we duplicated some effort @anonrig ;-) ...

Closing in favor of #54802

@jasnelljasnell closed this Sep 6, 2024
@codecov

codecovBot commented Sep 6, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.62%. Comparing base (e4fdd0b) to head (7e0838b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #54806 +/- ##
=======================================
Coverage 87.61% 87.62% =======================================
Files 650 650 Lines 182945 182945 Branches 35397 35394 -3 =======================================
+ Hits 160279 160297 +18 + Misses 15923 15908 -15 + Partials 6743 6740 -3 

see 23 files with indirect coverage changes

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jasnell@nodejs-github-bot