Skip to content

set several tests as flaky - #54802

Closed
anonrig wants to merge 16 commits into
nodejs:mainfrom
anonrig:set-flaky-tests-2024
Closed

set several tests as flaky#54802
anonrig wants to merge 16 commits into
nodejs:mainfrom
anonrig:set-flaky-tests-2024

Conversation

@anonrig

@anonriganonrig commented Sep 6, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Sets several tests (16) as flaky

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 6, 2024
This was referenced Sep 6, 2024
Closed
Closed
@anonriganonrig added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Sep 6, 2024
richardlau
richardlau reviewed Sep 6, 2024
View reviewed changes
Comment threadtest/parallel/parallel.status Outdated
lpinca
lpinca reviewed Sep 6, 2024
View reviewed changes
Comment threadtest/parallel/parallel.status Outdated
@anonrig
anonrigforce-pushed the set-flaky-tests-2024 branch from 1e25402 to 778d91aCompareSeptember 6, 2024 15:16
lpinca
lpinca reviewed Sep 6, 2024
View reviewed changes
Comment threadtest/async-hooks/async-hooks.status Outdated
jasnell
jasnell reviewed Sep 6, 2024
View reviewed changes
Comment threadtest/parallel/parallel.status Outdated
avivkeller
avivkeller reviewed Sep 6, 2024
View reviewed changes
Comment threadtest/parallel/test-module-loading-globalpaths.js Outdated
@anonrig
anonrigforce-pushed the set-flaky-tests-2024 branch from 41836e2 to 70d3abcCompareSeptember 6, 2024 15:43
@anonrig
anonrigforce-pushed the set-flaky-tests-2024 branch from 70d3abc to b17ef12CompareSeptember 6, 2024 15:48
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@anonrig@aduh95
test: set test-http-server-request-timeouts-mixed as flaky
8291de1
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@anonrig@aduh95
test: set test-runner-run-watch as flaky
56238de
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@anonrig@aduh95
test: set test-worker-arraybuffer-zerofill as flaky
1e1ac48
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@anonrig@aduh95
test: set test-http2-socket-close as flaky
41682c7
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@RafaelGSSRafaelGSS mentioned this pull request Sep 16, 2024
Merged
targos pushed a commit that referenced this pull request Sep 22, 2024
@anonrig@targos
test: set test-debugger-heap-profiler as flaky
0b0864d
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 22, 2024
@anonrig@targos
test: set test-performance-function as flaky
5214a9f
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 22, 2024
@anonrig@targos
test: set test-runner-watch-mode-complex as flaky
925b876
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 22, 2024
@anonrig@targos
test: set test-http2-large-file as flaky
3751a56
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 22, 2024
@anonrig@targos
test: set test-esm-loader-hooks-inspect-wait as flaky
235b975
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 22, 2024
@anonrig@targos
test: set test-async-context-frame as flaky
8f0eb3e
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 22, 2024
@anonrig@targos
test: set test-writewrap as flaky
82c7af2
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 22, 2024
@anonrig@targos
test: set test-runner-run-watch as flaky
78c2205
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 22, 2024
@anonrig@targos
test: set test-fs-utimes as flaky
515dc67
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 22, 2024
@anonrig@targos
test: set test-macos-app-sandbox as flaky
2e2b5fa
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 22, 2024
@anonrig@targos
test: set test-single-executable-application-empty as flaky
3633ef1
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 22, 2024
@anonrig@targos
test: set test-http-server-request-timeouts-mixed as flaky
6ca6fe8
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 22, 2024
@anonrig@targos
test: set test-worker-arraybuffer-zerofill as flaky
b54c0e7
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 26, 2024
@anonrig@targos
test: set test-debugger-heap-profiler as flaky
83d6356
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 26, 2024
@anonrig@targos
test: set test-performance-function as flaky
aa727c9
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this pull request Sep 26, 2024
@anonrig@targos
test: set test-runner-watch-mode-complex as flaky
c54b104
PR-URL: #54802
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@targostargos mentioned this pull request Sep 30, 2024
Merged
This was referenced Nov 28, 2024
Merged
Merged
Merged
Merged
@lpincalpinca mentioned this pull request Jan 9, 2025
Closed
This was referenced Jan 28, 2025
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@avivkelleravivkelleravivkeller left review comments
@KhafraDevKhafraDevKhafraDev approved these changes
@mcollinamcollinaAwaiting requested review from mcollina
@targostargosAwaiting requested review from targos
@aduh95aduh95Awaiting requested review from aduh95
@richardlaurichardlauAwaiting requested review from richardlau
@lpincalpincaAwaiting requested review from lpinca
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@anonrig@nodejs-github-bot@richardlau@tniessen@jasnell@lpinca@targos@mhdawson@aduh95@avivkeller@KhafraDev