Uh oh!
There was an error while loading. Please reload this page.
test: move test-fs-utimes to sequential - #54844
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Sep 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #54844 +/- ##
=======================================
Coverage 88.07% 88.07% =======================================
Files 651 651 Lines 183396 183375 -21 Branches 35795 35802 +7 =======================================
- Hits 161523 161507 -16 + Misses 15161 15150 -11 - Partials 6712 6718 +6 |
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
commented
Sep 8, 2024
Member
Did you get a timeout in #37692 (comment)? Because that is what was happening in our CI and only on ppc64le. |
jasnell
commented
Sep 8, 2024
MemberAuthor
Yes. When I ran enough concurrently load the test timed out locally. It wasn't easy but I was able to reproduce. |
Attempt to deal with flaky failures in CI by moving this to the sequential suite rather than the parallel suite
jasnellforce-pushed
the
move-test-fs-utimes-sequential
branch
from
September 11, 2024 14:44
21957c4 to
dc88b56Compare
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Sep 11, 2024
Collaborator
Member
Some tests time out due to a deadlock during process shutdown, see #52550 (comment). I think that the underlying issue is the same here. We could revert this when a fix lands. |
jasnell
commented
Sep 26, 2024
MemberAuthor
Closing this while we see if fixes to the deadlock resolve the issue |
lpinca added a commit
to lpinca/node
that referenced
this pull request
Dec 1, 2024
The issue is likely the same as other tests that time out. Refs: nodejs#54918 Refs: nodejs#54844 Refs: nodejs#54802
nodejs-github-bot pushed a commit
that referenced
this pull request
Dec 6, 2024
targos pushed a commit
that referenced
this pull request
Dec 6, 2024
aduh95 pushed a commit
that referenced
this pull request
Dec 13, 2024
aduh95 pushed a commit
that referenced
this pull request
Dec 18, 2024
ruyadorno pushed a commit
that referenced
this pull request
Jan 5, 2025
marco-ippolito pushed a commit
that referenced
this pull request
Jan 22, 2025
marco-ippolito pushed a commit
that referenced
this pull request
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to deal with flaky failures in CI by moving this to the sequential suite rather than the parallel suite