esm: do not interpret `"main"` as a URL by aduh95 · Pull Request #55003 · nodejs/node

aduh95 · 2024-09-19T09:30:30Z

As documented, its value is a path.

Lines 1210 to 1211 in c42d846

 The `"main"` field defines the entry point of a package when imported by name 
 via a `node_modules` lookup. Its value is a path. 

As documented, its value is a path.

nodejs-github-bot · 2024-09-19T09:30:35Z

Review requested:

@nodejs/loaders

codecov · 2024-09-19T12:03:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (c42d846) to head (f0c3a2c).
Report is 480 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #55003 +/- ##
=======================================
Coverage 88.03% 88.03% =======================================
Files 652 652 Lines 183759 183744 -15 Branches 35861 35853 -8 =======================================
- Hits 161770 161766 -4 + Misses 15239 15229 -10 + Partials 6750 6749 -1

Files with missing lines	Coverage Δ
lib/internal/modules/esm/resolve.js	`96.62% <100.00%> (-0.01%)`	⬇️
src/node_file.cc	`77.36% <100.00%> (+0.26%)`	⬆️

... and 31 files with indirect coverage changes

nodejs-github-bot · 2024-09-20T08:41:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62587/

nodejs-github-bot · 2024-09-27T10:05:51Z

Landed in fb85279

As documented, its value is a path. PR-URL: #55003 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

nodejs/node#55003

* chore: bump node in DEPS to v22.11.0 * src: move evp stuff to ncrypto nodejs/node#54911 * crypto: add Date fields for validTo and validFrom nodejs/node#54159 * module: fix discrepancy between .ts and .js nodejs/node#54461 * esm: do not interpret "main" as a URL nodejs/node#55003 * src: modernize likely/unlikely hints nodejs/node#55155 * chore: update patch indices * crypto: add validFromDate and validToDate fields to X509Certificate nodejs/node#54159 * chore: fixup perfetto patch * fix: clang warning in simdjson * src: add receiver to fast api callback methods nodejs/node#54408 * chore: fixup revert patch * fixup! esm: do not interpret "main" as a URL * fixup! crypto: add Date fields for validTo and validFrom * fix: move ArrayBuffer test patch * src: fixup Error.stackTraceLimit during snapshot building nodejs/node#55121 * fix: bad rebase * chore: fixup amaro * chore: address feedback from review * src: revert filesystem::path changes nodejs/node#55015 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs/node#55003

* chore: bump node in DEPS to v22.13.0 * chore: bump node in DEPS to v22.13.1 * src: move evp stuff to ncrypto nodejs/node#54911 * crypto: add Date fields for validTo and validFrom nodejs/node#54159 * module: fix discrepancy between .ts and .js nodejs/node#54461 * esm: do not interpret "main" as a URL nodejs/node#55003 * src: modernize likely/unlikely hints nodejs/node#55155 * chore: update patch indices * crypto: add validFromDate and validToDate fields to X509Certificate nodejs/node#54159 * chore: fixup perfetto patch * fix: clang warning in simdjson * src: add receiver to fast api callback methods nodejs/node#54408 * chore: fixup revert patch * fixup! esm: do not interpret "main" as a URL * fixup! crypto: add Date fields for validTo and validFrom * fix: move ArrayBuffer test patch * src: fixup Error.stackTraceLimit during snapshot building nodejs/node#55121 * fix: bad rebase * chore: fixup amaro * chore: address feedback from review * src: revert filesystem::path changes nodejs/node#55015 * chore: fixup GN build file * nodejs/node#55529 * nodejs/node#55798 * nodejs/node#55530 * module: simplify --inspect-brk handling nodejs/node#55679 * src: fix outdated js2c.cc references nodejs/node#56133 * crypto: include openssl/rand.h explicitly nodejs/node#55425 * build: use variable for crypto dep path nodejs/node#55928 * crypto: fix RSA_PKCS1_PADDING error message nodejs/node#55629 * build: use variable for simdutf path nodejs/node#56196 * test,crypto: make crypto tests work with BoringSSL nodejs/node#55491 * fix: suppress clang -Wdeprecated-declarations in libuv libuv/libuv#4486 * deps: update libuv to 1.49.1 nodejs/node#55114 * test: make test-node-output-v8-warning more flexible nodejs/node#55401 * [v22.x] Revert "v8: enable maglev on supported architectures" nodejs/node#54384 * fix: potential WIN32_LEAN_AND_MEAN redefinition c-ares/c-ares#869 * deps: update nghttp2 to 1.64.0 nodejs/node#55559 * src: provide workaround for container-overflow nodejs/node#55591 * build: use variable for simdutf path nodejs/node#56196 * chore: fixup patch indices * fixup! module: simplify --inspect-brk handling * lib: fix fs.readdir recursive async nodejs/node#56041 * lib: avoid excluding symlinks in recursive fs.readdir with filetypes nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up * test: disable CJS permission test for config.main This has diverged as a result of our revert of src,lb: reducing C++ calls of esm legacy main resolve * fixup! lib: fix fs.readdir recursive async * deps: update libuv to 1.49.1 nodejs/node#55114 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

esm: do not interpret "main" as a URL
7e25f19
As documented, its value is a path.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Sep 19, 2024

aduh95 added 2 commits September 19, 2024 11:32

fixup! esm: do not interpret "main" as a URL
f69157c

fixup! esm: do not interpret "main" as a URL
f0c3a2c

avivkeller reviewed Sep 19, 2024
View reviewed changes

Comment threadtest/es-module/test-cjs-legacyMainResolve.js

benjamingr approved these changes Sep 19, 2024
View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 20, 2024

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 20, 2024

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2024

nodejs-github-bot merged commit fb85279 into nodejs:mainSep 27, 2024

aduh95 deleted the main-is-a-path branch September 27, 2024 14:45

targos pushed a commit that referenced this pull request Oct 4, 2024
esm: do not interpret "main" as a URL
fe866e3
As documented, its value is a path. PR-URL: #55003 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

targos pushed a commit that referenced this pull request Oct 4, 2024
esm: do not interpret "main" as a URL
0fb446e
As documented, its value is a path. PR-URL: #55003 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

aduh95 mentioned this pull request Oct 9, 2024
V22.10.0 proposal #55343
Merged

marco-ippolito added the backport-blocked-v20.x label Nov 16, 2024

codebytere added a commit to electron/electron that referenced this pull request Nov 20, 2024
esm: do not interpret "main" as a URL
3d8221c
nodejs/node#55003

codebytere added a commit to electron/electron that referenced this pull request Nov 20, 2024
esm: do not interpret "main" as a URL
af06538
nodejs/node#55003

codebytere added a commit to electron/electron that referenced this pull request Nov 21, 2024
esm: do not interpret "main" as a URL
0dbd423
nodejs/node#55003

codebytere added a commit to electron/electron that referenced this pull request Dec 3, 2024
esm: do not interpret "main" as a URL
98f1f75
nodejs/node#55003

codebytere added a commit to electron/electron that referenced this pull request Dec 4, 2024
esm: do not interpret "main" as a URL
b80cd2b
nodejs/node#55003

codebytere added a commit to electron/electron that referenced this pull request Jan 22, 2025
esm: do not interpret "main" as a URL
2a1c1ec
nodejs/node#55003

codebytere added a commit to electron/electron that referenced this pull request Feb 3, 2025
esm: do not interpret "main" as a URL
29d6935
nodejs/node#55003

codebytere added a commit to electron/electron that referenced this pull request Feb 10, 2025
esm: do not interpret "main" as a URL
fee60cd
nodejs/node#55003

codebytere added a commit to electron/electron that referenced this pull request Feb 10, 2025
esm: do not interpret "main" as a URL
91a5be1
nodejs/node#55003

codebytere added a commit to electron/electron that referenced this pull request Feb 14, 2025
esm: do not interpret "main" as a URL
cc6f2a5
nodejs/node#55003

Navigation Menu

Uh oh!

Uh oh!

esm: do not interpret `"main"` as a URL - #55003

esm: do not interpret `"main"` as a URL#55003
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
aduh95:main-is-a-path

aduh95 commented Sep 19, 2024

Uh oh!

nodejs-github-bot commented Sep 19, 2024

Uh oh!

Uh oh!

codecovBot commented Sep 19, 2024•
edited
Loading

Uh oh!

nodejs-github-bot commented Sep 20, 2024

Uh oh!

nodejs-github-bot commented Sep 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	The `"main"` field defines the entry point of a package when imported by name
	via a `node_modules` lookup. Its value is a path.

Uh oh!

Uh oh!

Conversation

aduh95 commented Sep 19, 2024

Uh oh!

nodejs-github-bot commented Sep 19, 2024

Uh oh!

Uh oh!

codecovBot commented Sep 19, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Sep 20, 2024

Uh oh!

nodejs-github-bot commented Sep 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecovBot commented Sep 19, 2024•
edited
Loading