src: modernize likely/unlikely hints by anonrig · Pull Request #55155 · nodejs/node

anonrig · 2024-09-28T17:56:41Z

An attempt to modernize C++ code to use [[likely]] and [[unlikely]] available after C++20.

Reference: https://en.cppreference.com/w/cpp/language/attributes/likely

This pull-request also disables readability/braces rule from cpplint, since it doesn't support C++20. Main branch of cpplint supports it, but unfortunately they didn't release a new version in the last 2 years.

nodejs-github-bot · 2024-09-28T17:56:46Z

Review requested:

@nodejs/crypto
@nodejs/http2
@nodejs/net
@nodejs/startup

anonrig · 2024-09-28T17:57:21Z

cc @nodejs/cpp-reviewers

nodejs-github-bot · 2024-09-28T19:08:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/62832/

codecov · 2024-09-28T19:40:48Z

Codecov Report

Attention: Patch coverage is 34.59716% with 138 lines in your changes missing coverage. Please review.

Project coverage is 88.23%. Comparing base (3800d60) to head (0b257ca).
Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
src/crypto/crypto_tls.cc	15.38%	6 Missing and 16 partials ⚠️
src/cares_wrap.cc	0.00%	8 Missing and 5 partials ⚠️
src/quic/session.cc	0.00%	10 Missing ⚠️
src/quic/packet.cc	0.00%	8 Missing ⚠️
src/crypto/crypto_cipher.cc	0.00%	0 Missing and 7 partials ⚠️
src/crypto/crypto_hash.cc	12.50%	0 Missing and 7 partials ⚠️
src/node_http2.cc	63.15%	2 Missing and 5 partials ⚠️
src/crypto/crypto_dh.cc	0.00%	0 Missing and 6 partials ⚠️
src/crypto/crypto_sig.cc	28.57%	0 Missing and 5 partials ⚠️
src/quic/endpoint.cc	0.00%	5 Missing ⚠️
... and 25 more

Additional details and impacted files

@@ Coverage Diff @@## main #55155 +/- ##
==========================================
- Coverage 88.24% 88.23% -0.02% 
==========================================
Files 651 651 Lines 183937 183911 -26 Branches 35861 35833 -28 ==========================================
- Hits 162318 162274 -44 - Misses 14911 14945 +34 + Partials 6708 6692 -16

Files with missing lines	Coverage Δ
src/api/callback.cc	`78.10% <100.00%> (ø)`
src/api/environment.cc	`76.00% <100.00%> (-0.49%)`	⬇️
src/base_object.cc	`84.61% <100.00%> (-0.97%)`	⬇️
src/crypto/crypto_keys.cc	`73.06% <ø> (-0.35%)`	⬇️
src/crypto/crypto_spkac.cc	`88.88% <100.00%> (ø)`
src/env-inl.h	`96.80% <100.00%> (+<0.01%)`	⬆️
src/env.cc	`85.65% <100.00%> (+0.02%)`	⬆️
src/node_contextify.cc	`81.45% <100.00%> (+0.10%)`	⬆️
src/node_modules.cc	`78.64% <100.00%> (+0.53%)`	⬆️
src/permission/permission.h	`80.00% <100.00%> (+2.22%)`	⬆️
... and 42 more

... and 15 files with indirect coverage changes

nodejs-github-bot · 2024-09-30T18:04:18Z

Landed in 317d245

PR-URL: #55155 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

aaronliu0130 · 2024-10-07T21:31:58Z

We've recently released 2.0. Let us know if the [[(un)likely]] detection works!

nodejs/node#55155

* chore: bump node in DEPS to v22.11.0 * src: move evp stuff to ncrypto nodejs/node#54911 * crypto: add Date fields for validTo and validFrom nodejs/node#54159 * module: fix discrepancy between .ts and .js nodejs/node#54461 * esm: do not interpret "main" as a URL nodejs/node#55003 * src: modernize likely/unlikely hints nodejs/node#55155 * chore: update patch indices * crypto: add validFromDate and validToDate fields to X509Certificate nodejs/node#54159 * chore: fixup perfetto patch * fix: clang warning in simdjson * src: add receiver to fast api callback methods nodejs/node#54408 * chore: fixup revert patch * fixup! esm: do not interpret "main" as a URL * fixup! crypto: add Date fields for validTo and validFrom * fix: move ArrayBuffer test patch * src: fixup Error.stackTraceLimit during snapshot building nodejs/node#55121 * fix: bad rebase * chore: fixup amaro * chore: address feedback from review * src: revert filesystem::path changes nodejs/node#55015 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs/node#55155

* chore: bump node in DEPS to v22.13.0 * chore: bump node in DEPS to v22.13.1 * src: move evp stuff to ncrypto nodejs/node#54911 * crypto: add Date fields for validTo and validFrom nodejs/node#54159 * module: fix discrepancy between .ts and .js nodejs/node#54461 * esm: do not interpret "main" as a URL nodejs/node#55003 * src: modernize likely/unlikely hints nodejs/node#55155 * chore: update patch indices * crypto: add validFromDate and validToDate fields to X509Certificate nodejs/node#54159 * chore: fixup perfetto patch * fix: clang warning in simdjson * src: add receiver to fast api callback methods nodejs/node#54408 * chore: fixup revert patch * fixup! esm: do not interpret "main" as a URL * fixup! crypto: add Date fields for validTo and validFrom * fix: move ArrayBuffer test patch * src: fixup Error.stackTraceLimit during snapshot building nodejs/node#55121 * fix: bad rebase * chore: fixup amaro * chore: address feedback from review * src: revert filesystem::path changes nodejs/node#55015 * chore: fixup GN build file * nodejs/node#55529 * nodejs/node#55798 * nodejs/node#55530 * module: simplify --inspect-brk handling nodejs/node#55679 * src: fix outdated js2c.cc references nodejs/node#56133 * crypto: include openssl/rand.h explicitly nodejs/node#55425 * build: use variable for crypto dep path nodejs/node#55928 * crypto: fix RSA_PKCS1_PADDING error message nodejs/node#55629 * build: use variable for simdutf path nodejs/node#56196 * test,crypto: make crypto tests work with BoringSSL nodejs/node#55491 * fix: suppress clang -Wdeprecated-declarations in libuv libuv/libuv#4486 * deps: update libuv to 1.49.1 nodejs/node#55114 * test: make test-node-output-v8-warning more flexible nodejs/node#55401 * [v22.x] Revert "v8: enable maglev on supported architectures" nodejs/node#54384 * fix: potential WIN32_LEAN_AND_MEAN redefinition c-ares/c-ares#869 * deps: update nghttp2 to 1.64.0 nodejs/node#55559 * src: provide workaround for container-overflow nodejs/node#55591 * build: use variable for simdutf path nodejs/node#56196 * chore: fixup patch indices * fixup! module: simplify --inspect-brk handling * lib: fix fs.readdir recursive async nodejs/node#56041 * lib: avoid excluding symlinks in recursive fs.readdir with filetypes nodejs/node#55714 This doesn't currently play well with ASAR - this should be fixed in a follow up * test: disable CJS permission test for config.main This has diverged as a result of our revert of src,lb: reducing C++ calls of esm legacy main resolve * fixup! lib: fix fs.readdir recursive async * deps: update libuv to 1.49.1 nodejs/node#55114 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

anonrig added dont-land-on-v18.x labels Sep 28, 2024

anonrig requested review from jasnell, joyeecheung, targos and tniessen September 28, 2024 17:56

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 28, 2024

anonrig requested a review from addaleax September 28, 2024 17:57

anonrig force-pushed the modernize-unlikely-likely branch from 97535a9 to 4eb873dCompare September 28, 2024 18:04

anonrig mentioned this pull request Sep 28, 2024
Release 2.0 cpplint/cpplint#238
Closed

anonrig force-pushed the modernize-unlikely-likely branch from 4eb873d to 3e75ed9Compare September 28, 2024 18:08

src: modernize likely/unlikely hints
0b257ca

anonrig force-pushed the modernize-unlikely-likely branch from 3e75ed9 to 0b257caCompare September 28, 2024 18:10

anonrig requested a review from RafaelGSS September 28, 2024 18:10

tniessen approved these changes Sep 28, 2024
View reviewed changes

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2024

jasnell approved these changes Sep 28, 2024
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2024

RafaelGSS approved these changes Sep 28, 2024
View reviewed changes

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 28, 2024

mertcanaltin approved these changes Sep 29, 2024
View reviewed changes

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2024

nodejs-github-bot merged commit 317d245 into nodejs:mainSep 30, 2024

targos pushed a commit that referenced this pull request Oct 4, 2024
src: modernize likely/unlikely hints
5978257
PR-URL: #55155 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

targos pushed a commit that referenced this pull request Oct 4, 2024
src: modernize likely/unlikely hints
d6bcc44
PR-URL: #55155 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

aduh95 mentioned this pull request Oct 9, 2024
V22.10.0 proposal #55343
Merged

codebytere added a commit to electron/electron that referenced this pull request Nov 20, 2024
src: modernize likely/unlikely hints
684f539
nodejs/node#55155

codebytere added a commit to electron/electron that referenced this pull request Nov 20, 2024
src: modernize likely/unlikely hints
9ba7a5b
nodejs/node#55155

codebytere added a commit to electron/electron that referenced this pull request Nov 21, 2024
src: modernize likely/unlikely hints
694182b
nodejs/node#55155

codebytere added a commit to electron/electron that referenced this pull request Dec 3, 2024
src: modernize likely/unlikely hints
e0717a4
nodejs/node#55155

codebytere added a commit to electron/electron that referenced this pull request Dec 4, 2024
src: modernize likely/unlikely hints
d60f548
nodejs/node#55155

codebytere added a commit to electron/electron that referenced this pull request Jan 22, 2025
src: modernize likely/unlikely hints
8eec4e0
nodejs/node#55155

codebytere added a commit to electron/electron that referenced this pull request Feb 3, 2025
src: modernize likely/unlikely hints
27a2c64
nodejs/node#55155

codebytere added a commit to electron/electron that referenced this pull request Feb 10, 2025
src: modernize likely/unlikely hints
0254630
nodejs/node#55155

codebytere added a commit to electron/electron that referenced this pull request Feb 10, 2025
src: modernize likely/unlikely hints
5caec25
nodejs/node#55155

codebytere added a commit to electron/electron that referenced this pull request Feb 14, 2025
src: modernize likely/unlikely hints
23ebaa2
nodejs/node#55155

Navigation Menu

Uh oh!

Uh oh!

src: modernize likely/unlikely hints - #55155

src: modernize likely/unlikely hints#55155
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:modernize-unlikely-likely

anonrig commented Sep 28, 2024•
edited
Loading

Uh oh!

nodejs-github-bot commented Sep 28, 2024

Uh oh!

anonrig commented Sep 28, 2024

Uh oh!

nodejs-github-bot commented Sep 28, 2024

Uh oh!

codecovBot commented Sep 28, 2024•
edited
Loading

Uh oh!

nodejs-github-bot commented Sep 30, 2024

Uh oh!

aaronliu0130 commented Oct 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

anonrig commented Sep 28, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Sep 28, 2024

Uh oh!

anonrig commented Sep 28, 2024

Uh oh!

nodejs-github-bot commented Sep 28, 2024

Uh oh!

codecovBot commented Sep 28, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Sep 30, 2024

Uh oh!

aaronliu0130 commented Oct 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

anonrig commented Sep 28, 2024•
edited
Loading

codecovBot commented Sep 28, 2024•
edited
Loading