Uh oh!
There was an error while loading. Please reload this page.
[v20.x backport] lib: move Symbol[Async]Dispose polyfills to internal/util - #55264
Closed
aduh95 wants to merge 2 commits into
Closed
[v20.x backport] lib: move Symbol[Async]Dispose polyfills to internal/util#55264aduh95 wants to merge 2 commits into
Symbol[Async]Dispose polyfills to internal/util#55264aduh95 wants to merge 2 commits into
Conversation
nodejs-github-bot
commented
Oct 4, 2024
Collaborator
Review requested:
|
Member
I take the opportunity to ask: how is it that when applied to node/lib/internal/quic/quic.js Lines 19 to 21 in d2ad9b4 |
aduh95
commented
Oct 4, 2024
ContributorAuthor
I'm not sure, I guess the test doesn't cover that method, or it's being inherited from somewhere else 🤔 |
Member
I've checked and Opened #55276 |
nodejs-github-bot
commented
Nov 16, 2024
Collaborator
PR-URL: nodejs#54853 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95force-pushed
the
symbol-async-dispose
branch
from
November 16, 2024 11:06
8c960bc to
d6d91f2ComparePR-URL: nodejs#55318 Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-github-bot
commented
Nov 16, 2024
Collaborator
nodejs-github-bot
commented
Nov 16, 2024
Collaborator
nodejs-github-bot
commented
Nov 17, 2024
Collaborator
marco-ippolito pushed a commit
that referenced
this pull request
Nov 18, 2024
PR-URL: #54853 Backport-PR-URL: #55264 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito
commented
Nov 18, 2024
Member
Landed in f25a5b6...0b3fb34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #54853 and #55318