Skip to content

lib: remove Symbol[Async]Dispose polyfills - #55276

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:rm-symbol-dispose-polyfill
Oct 7, 2024
Merged

lib: remove Symbol[Async]Dispose polyfills#55276
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:rm-symbol-dispose-polyfill

Conversation

@targos

@targostargos commented Oct 5, 2024

Copy link
Copy Markdown
Member

No description provided.

@targostargos added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Oct 5, 2024
@nodejs-github-bot

nodejs-github-bot commented Oct 5, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net
  • @nodejs/streams
  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 5, 2024
@targostargos mentioned this pull request Oct 5, 2024
Closed
@codecov

codecovBot commented Oct 5, 2024•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (bbdfeeb) to head (9ccc762).
Report is 8 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #55276 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.02% 
==========================================
Files 652 652 Lines 186612 186573 -39 Branches 36062 36058 -4 ==========================================
- Hits 165001 164943 -58 - Misses 14885 14894 +9 - Partials 6726 6736 +10
Files with missing linesCoverage Δ
lib/_http_server.js96.74% <100.00%> (+0.08%)⬆️
lib/child_process.js97.74% <100.00%> (ø)
lib/dgram.js97.32% <100.00%> (+<0.01%)⬆️
lib/events.js99.83% <100.00%> (+<0.01%)⬆️
lib/https.js99.30% <100.00%> (ø)
lib/inspector.js96.27% <100.00%> (-0.06%)⬇️
lib/internal/child_process.js95.07% <100.00%> (+<0.01%)⬆️
lib/internal/events/abort_listener.js100.00% <100.00%> (ø)
lib/internal/fs/promises.js98.24% <100.00%> (ø)
lib/internal/http2/core.js95.53% <100.00%> (ø)
... and 15 more

... and 36 files with indirect coverage changes

Qard
Qard approved these changes Oct 5, 2024
View reviewed changes
@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2024
@nodejs-github-bot

nodejs-github-bot commented Oct 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62926/

mcollina
mcollina approved these changes Oct 5, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@avivkelleravivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 5, 2024
@nodejs-github-bot

nodejs-github-bot commented Oct 5, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62930/

mertcanaltin
mertcanaltin approved these changes Oct 5, 2024
View reviewed changes

@mertcanaltinmertcanaltin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62942/

@atlowChemiatlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2024
@nodejs-github-bot
nodejs-github-bot merged commit d5eb9a3 into nodejs:mainOct 7, 2024
@nodejs-github-bot

nodejs-github-bot commented Oct 7, 2024

Copy link
Copy Markdown
Collaborator

Landed in d5eb9a3

This was referenced Oct 8, 2024
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@QardQardQard approved these changes
@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@MoLowMoLowMoLow approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes
+1 more reviewer
@mertcanaltinmertcanaltinmertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@targos@nodejs-github-bot@mcollina@Qard@lpinca@anonrig@MoLow@mertcanaltin@atlowChemi@avivkeller