Skip to content

[wip] test: Migrate tests to use node:test module for better test structure - #56024

Closed
mertcanaltin wants to merge 1 commit into
nodejs:mainfrom
mertcanaltin:test/refactor-node-test-usage
Closed

[wip] test: Migrate tests to use node:test module for better test structure#56024
mertcanaltin wants to merge 1 commit into
nodejs:mainfrom
mertcanaltin:test/refactor-node-test-usage

Conversation

@mertcanaltin

Copy link
Copy Markdown
Member

hello I am converting old tests to node:test and I continue to work on it now fyi

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. test Issues and PRs related to the tests. labels Nov 27, 2024
@mertcanaltin
mertcanaltinforce-pushed the test/refactor-node-test-usage branch from f8848ba to 91ea1edCompareNovember 27, 2024 15:52
@mertcanaltin
mertcanaltinforce-pushed the test/refactor-node-test-usage branch from 39a2917 to c0d09d1CompareNovember 27, 2024 15:59
@anonrig

Copy link
Copy Markdown
Member

Please wait for #56027 before continuing on this work.

@anonrig

Copy link
Copy Markdown
Member

Also, a single pull-request with 1000 lines changes is extremely hard to review. I recommend splitting this, and justifying the reasoning behind this change.

@mertcanaltin

Copy link
Copy Markdown
MemberAuthor

thank you very much for the suggestion, I will divide this pr as you said, I can even link it into a topic or tasks @anonrig

@codecov

codecovBot commented Nov 27, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (9029aec) to head (c0d09d1).
Report is 149 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #56024 +/- ##
=======================================
Coverage 87.95% 87.96% =======================================
Files 656 656 Lines 188372 188372 Branches 35979 35975 -4 =======================================
+ Hits 165687 165694 +7 + Misses 15851 15839 -12 - Partials 6834 6839 +5 

see 26 files with indirect coverage changes

@anonrig

Copy link
Copy Markdown
Member

thank you very much for the suggestion, I will divide this pr as you said, I can even link it into a topic or tasks @anonrig

@mertcanaltin I've asked you to wait on progressing such changes due to the pending PR and discussion around refactoring node test usage. We are not in alignment to make these kind of changes, yet.

@mertcanaltin

mertcanaltin commented Nov 27, 2024

Copy link
Copy Markdown
MemberAuthor

thank you very much for the suggestion, I will divide this pr as you said, I can even link it into a topic or tasks @anonrig

@mertcanaltin I've asked you to wait on progressing such changes due to the pending PR and discussion around refactoring node test usage. We are not in alignment to make these kind of changes, yet.

I understand, I'm very sorry. Should I consider closing these pull requests? 🙏

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.reportIssues and PRs related to process.report.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mertcanaltin@anonrig@nodejs-github-bot