Uh oh!
There was an error while loading. Please reload this page.
[wip] test: Migrate tests to use node:test module for better test structure - #56024
[wip] test: Migrate tests to use node:test module for better test structure#56024mertcanaltin wants to merge 1 commit into
Conversation
f8848ba to
91ea1edCompare39a2917 to
c0d09d1Compareanonrig
commented
Nov 27, 2024
Please wait for #56027 before continuing on this work. |
anonrig
commented
Nov 27, 2024
Also, a single pull-request with 1000 lines changes is extremely hard to review. I recommend splitting this, and justifying the reasoning behind this change. |
mertcanaltin
commented
Nov 27, 2024
thank you very much for the suggestion, I will divide this pr as you said, I can even link it into a topic or tasks @anonrig |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #56024 +/- ##
=======================================
Coverage 87.95% 87.96% =======================================
Files 656 656 Lines 188372 188372 Branches 35979 35975 -4 =======================================
+ Hits 165687 165694 +7 + Misses 15851 15839 -12 - Partials 6834 6839 +5 |
anonrig
commented
Nov 27, 2024
@mertcanaltin I've asked you to wait on progressing such changes due to the pending PR and discussion around refactoring node test usage. We are not in alignment to make these kind of changes, yet. |
I understand, I'm very sorry. Should I consider closing these pull requests? 🙏 |
hello I am converting old tests to node:test and I continue to work on it now fyi