Skip to content

test: migrate tests to use node:test module for better test structure for eventtarget once twice - #56035

Closed
mertcanaltin wants to merge 1 commit into
nodejs:mainfrom
mertcanaltin:test/refactor-eventtarget-once-twice
Closed

test: migrate tests to use node:test module for better test structure for eventtarget once twice#56035
mertcanaltin wants to merge 1 commit into
nodejs:mainfrom
mertcanaltin:test/refactor-eventtarget-once-twice

Conversation

@mertcanaltin

Copy link
Copy Markdown
Member

Updated eventtarget-once-twice tests to use the node:test module for improved structure and consistency.

this is part of a long pull request: #56024

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 27, 2024
@mertcanaltinmertcanaltin changed the title test: migrate tests to use node:test module for better test structuretest: migrate tests to use node:test module for better test structure for eventtarget once twiceNov 27, 2024
@codecov

codecovBot commented Nov 27, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (9029aec) to head (91952ae).
Report is 680 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #56035 +/- ##
=======================================
Coverage 87.95% 87.96% =======================================
Files 656 656 Lines 188372 188372 Branches 35979 35977 -2 =======================================
+ Hits 165687 165699 +12 + Misses 15851 15841 -10 + Partials 6834 6832 -2 

see 30 files with indirect coverage changes

@mertcanaltinmertcanaltin added the blocked PRs that are blocked by other issues or PRs. label Dec 24, 2024
@mertcanaltin

Copy link
Copy Markdown
MemberAuthor

#54796, #56027, #55716
I added a blocker tag because it is linked

@lpincalpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm blocking this because there is an approval now and as discussed in other places this is not an improvement in my opinion. I will remove the block once TSC officially decides that a mass refactor to node:test is good for the project.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blockedPRs that are blocked by other issues or PRs.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mertcanaltin@jasnell@lpinca@nodejs-github-bot