Skip to content

test: use spawnSyncAndExit{,WithoutError}()#56529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lpinca wants to merge 1 commit into from
Closed

test: use spawnSyncAndExit{,WithoutError}() #56529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 23 additions & 22 deletions test/parallel/test-macos-app-sandbox.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,11 +7,13 @@ if (process.config.variables.node_builtin_modules_path)

const fixtures = require('../common/fixtures');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');
const child_process = require('child_process');
const path = require('path');
const fs = require('fs');
const os = require('os');
const {
spawnSyncAndExit,
spawnSyncAndExitWithoutError
} = require('../common/child_process');

const nodeBinary = process.execPath;

Expand DownExpand Up@@ -42,30 +44,29 @@ fs.copyFileSync(
nodeBinary,
appExecutablePath);


// Sign the app bundle with sandbox entitlements:
assert.strictEqual(
child_process.spawnSync('/usr/bin/codesign', [
'--entitlements', fixtures.path(
'macos-app-sandbox', 'node_sandboxed.entitlements'),
'--force', '-s', '-',
appBundlePath,
]).status,
0);
spawnSyncAndExitWithoutError('codesign', [
'--entitlements',
fixtures.path('macos-app-sandbox', 'node_sandboxed.entitlements'),
'--force',
'-s',
'-',
appBundlePath,
]);

// Sandboxed app shouldn't be able to read the home dir
assert.notStrictEqual(
child_process.spawnSync(appExecutablePath, [
'-e', 'fs.readdirSync(process.argv[1])', os.homedir(),
]).status,
0);
spawnSyncAndExit(
appExecutablePath,
['-e', 'fs.readdirSync(process.argv[1])', os.homedir()],
{
status: 1,
signal: null,
},
);

if (process.stdin.isTTY) {
// Run the sandboxed node instance with inherited tty stdin
const spawnResult = child_process.spawnSync(
appExecutablePath, ['-e', ''],
{ stdio: 'inherit' }
);

assert.strictEqual(spawnResult.signal, null);
spawnSyncAndExitWithoutError(appExecutablePath, ['-e', ''], {
stdio: 'inherit',
});
}