Skip to content

test: use spawnSyncAndExit{,WithoutError}() - #56529

Closed
lpinca wants to merge 1 commit into
nodejs:mainfrom
lpinca:improve/test-macos-app-sandbox
Closed

test: use spawnSyncAndExit{,WithoutError}()#56529
lpinca wants to merge 1 commit into
nodejs:mainfrom
lpinca:improve/test-macos-app-sandbox

Conversation

@lpinca

@lpincalpinca commented Jan 9, 2025

Copy link
Copy Markdown
Member

Use spawnSyncAndExit() and spawnSyncAndExitWithoutError() in
test/parallel/test-macos-app-sandbox.js.

Refs: #54802 (comment)

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 9, 2025
@lpinca
lpincaforce-pushed the improve/test-macos-app-sandbox branch from 3871b83 to 01e4d77CompareJanuary 9, 2025 09:00
@codecov

codecovBot commented Jan 9, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (dc5d0f9) to head (b6a59dd).
Report is 11 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #56529 +/- ##
==========================================
- Coverage 89.16% 89.16% -0.01% 
==========================================
Files 662 662 Lines 191668 191672 +4 Branches 36884 36883 -1 ==========================================
- Hits 170908 170905 -3 - Misses 13621 13627 +6 - Partials 7139 7140 +1 

see 42 files with indirect coverage changes

@lpinca
lpincaforce-pushed the improve/test-macos-app-sandbox branch 3 times, most recently from 396e17c to c57b24aCompareJanuary 9, 2025 13:06
Use `spawnSyncAndExit()` and `spawnSyncAndExitWithoutError()` in
`test/parallel/test-macos-app-sandbox.js`.
Refs: nodejs#54802 (comment)
@lpinca
lpincaforce-pushed the improve/test-macos-app-sandbox branch from c57b24a to b6a59ddCompareJanuary 9, 2025 13:11
@lpincalpinca changed the title test: use spawnSyncAndExitWithoutError()test: use spawnSyncAndExit{,WithoutError}()Jan 9, 2025
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 9, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@lpinca

Copy link
Copy Markdown
MemberAuthor

spawnSyncAndExit() is not very useful here as the process is terminated with SIGTRAP or SIGKILL in CI. It's not worth the effort. I'm closing this.

@lpincalpinca closed this Jan 10, 2025
@lpinca
lpinca deleted the improve/test-macos-app-sandbox branch January 10, 2025 12:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lpinca@nodejs-github-bot