Skip to content

src: initialize privateSymbols for per_context - #57479

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
jazelly:expose-isolate-data
Apr 6, 2025
Merged

src: initialize privateSymbols for per_context#57479
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
jazelly:expose-isolate-data

Conversation

@jazelly

@jazellyjazelly commented Mar 15, 2025•
edited
Loading

Copy link
Copy Markdown
Member

In some cases, per_context files need to access privateSymbols. This commit lets GetPerContextExports to be able to pass down IsolateData to InitializePrimordials, so it can compile per_context files with privateSymbols from IsolateData.

With this change we can access privateSymbols in per_context/domexception.js like

const { transfer_mode_private_symbol } = privateSymbols;

@nodejs-github-bot

nodejs-github-bot commented Mar 15, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 15, 2025
@jazelly
jazellyforce-pushed the expose-isolate-data branch 2 times, most recently from 4044d5d to 4c9445fCompareMarch 15, 2025 05:27
@jazellyjazelly changed the title src,startup: expose isolate_data even before envsrc,bootstrap: expose isolate_data even before envMar 15, 2025
@jazelly
jazellyforce-pushed the expose-isolate-data branch from 4c9445f to f4643b9CompareMarch 15, 2025 05:32
@jazellyjazelly mentioned this pull request Mar 15, 2025
Closed
@codecov

codecovBot commented Mar 15, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 75.75758% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (a6d3585) to head (40c0219).
Report is 380 commits behind head on main.

Files with missing linesPatch %Lines
src/api/environment.cc73.91%2 Missing and 4 partials ⚠️
src/node_messaging.cc75.00%0 Missing and 2 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #57479 +/- ##
=======================================
Coverage 90.23% 90.23% =======================================
Files 630 630 Lines 185129 185077 -52 Branches 36234 36222 -12 =======================================
- Hits 167049 167008 -41 - Misses 11037 11039 +2 + Partials 7043 7030 -13
Files with missing linesCoverage Δ
src/node_builtins.cc79.41% <100.00%> (+0.29%)⬆️
src/node_internals.h81.03% <ø> (ø)
src/node_realm.cc73.41% <100.00%> (ø)
src/node_messaging.cc83.49% <75.00%> (+0.38%)⬆️
src/api/environment.cc75.18% <73.91%> (-0.63%)⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jazellyjazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2025
@nodejs-github-bot

nodejs-github-bot commented Mar 16, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65779/

@nodejs-github-bot

nodejs-github-bot commented Mar 17, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65796/

legendecas
legendecas reviewed Mar 17, 2025
View reviewed changes
Comment threadsrc/node.h Outdated
@jazellyjazelly added blocked PRs that are blocked by other issues or PRs. and removed blocked PRs that are blocked by other issues or PRs. labels Mar 19, 2025
@jazelly
jazellyforce-pushed the expose-isolate-data branch from f4643b9 to 0b6c017CompareMarch 24, 2025 20:47
@jazellyjazelly changed the title src,bootstrap: expose isolate_data even before envsrc: initialize privateSymbols for per_contextMar 24, 2025
@jazelly
jazellyforce-pushed the expose-isolate-data branch from 0b6c017 to 22cdadeCompareMarch 24, 2025 20:57
legendecas
legendecas reviewed Mar 25, 2025
View reviewed changes
Comment threadsrc/api/environment.cc Outdated
@jazelly
jazellyforce-pushed the expose-isolate-data branch from 22cdade to e518bf4CompareMarch 25, 2025 12:01
legendecas
legendecas reviewed Mar 25, 2025
View reviewed changes
Comment threadsrc/api/environment.cc
legendecas
legendecas approved these changes Mar 26, 2025
View reviewed changes

@legendecaslegendecas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % a small nit

Comment threadsrc/api/environment.cc Outdated
@jazellyjazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 27, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2025
@aduh95aduh95 added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 6, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 6, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 79eddc6 into nodejs:mainApr 6, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 6, 2025

Copy link
Copy Markdown
Collaborator

Landed in 79eddc6

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@jazelly@RafaelGSS
src: initialize privateSymbols for per_context
496a3cb
PR-URL: #57479
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@jazelly@RafaelGSS
src: initialize privateSymbols for per_context
3ff37a8
PR-URL: #57479
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@aduh95aduh95 added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label May 6, 2025
@aduh95

aduh95 commented May 6, 2025

Copy link
Copy Markdown
Contributor

This doesn't build on v22.x-staging, could you open a backport PR or add the dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x. label please?

@jazelly

jazelly commented May 7, 2025

Copy link
Copy Markdown
MemberAuthor

blocked by the backport of #57519, but I don't see this should not land on v22.x, so I'll wait.

@aduh95

aduh95 commented May 7, 2025

Copy link
Copy Markdown
Contributor

If you'd like to open a backport PR that includes both PRs, that'd be awesome – otherwise it might never happen

@jazellyjazelly mentioned this pull request May 7, 2025
Closed
@jazellyjazelly added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. and removed backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels May 10, 2025
aduh95 pushed a commit to jazelly/node that referenced this pull request May 18, 2025
@jazelly@aduh95
src: initialize privateSymbols for per_context
1af7dd2
PR-URL: nodejs#57479
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request May 19, 2025
@jazelly@aduh95
src: initialize privateSymbols for per_context
a376d10
PR-URL: #57479
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@jazelly@aduh95
src: initialize privateSymbols for per_context
4c5555d
PR-URL: #57479
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 left review comments
@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.backport-requested-v22.xPRs awaiting manual backport to the v22.x-staging branch.c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jazelly@nodejs-github-bot@aduh95@legendecas