Uh oh!
There was an error while loading. Please reload this page.
[v18.x] deps: update undici to v5.29.0 - #57557
Closed
mcollina wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
commented
Mar 20, 2025
MemberAuthor
cc @nodejs/releasers |
nodejs-github-bot
commented
Mar 20, 2025
Collaborator
Review requested:
|
richardlau
approved these changes
Mar 20, 2025
nodejs-github-bot
commented
Mar 20, 2025
Collaborator
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Mar 20, 2025
Collaborator
Contributor
Fast-track has been requested by @richardlau. Please 👍 to approve. |
richardlau
commented
Mar 20, 2025
Member
I'd like to fast track this so that I can include it in the Node.js 18 release that I'm preparing for next week. I don't think the coverage failures are related to this change -- I've opened #57565 to see if backporting a change fixes that. |
marco-ippolito
approved these changes
Mar 21, 2025
RafaelGSS
approved these changes
Mar 23, 2025
Charlesnorris509
left a comment
There was a problem hiding this comment.
It looks like overall all your changes follow SWE best practices, however I would add comments on the code to make sure its readable
richardlau pushed a commit
that referenced
this pull request
Mar 26, 2025
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #57557 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
richardlau
commented
Mar 26, 2025
Member
Landed in 69d661d. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates Undici to v5.29.0 in Node v18.