Uh oh!
There was an error while loading. Please reload this page.
[v18.x backport] build: update gcovr to 7.2 and codecov config - #57565
Closed
richardlau wants to merge 1 commit into
Closed
[v18.x backport] build: update gcovr to 7.2 and codecov config#57565richardlau wants to merge 1 commit into
richardlau wants to merge 1 commit into
Conversation
PR-URL: #54019 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-github-bot
commented
Mar 20, 2025
Collaborator
Review requested:
|
Contributor
Fast-track has been requested by @richardlau. Please 👍 to approve. |
richardlau
commented
Mar 20, 2025
MemberAuthor
cc @nodejs/releasers It looks like this fixes the failing coverage builds on v18.x-staging (see #57557). Requesting fast track so I can include it in the Node.js 18 I am preparing, or we can decide not to fix it this close to Node.js 18's End-of-Life. |
nodejs-github-bot
commented
Mar 20, 2025
Collaborator
targos
approved these changes
Mar 20, 2025
nodejs-github-bot
commented
Mar 20, 2025
Collaborator
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Mar 21, 2025
Collaborator
BridgeAR
approved these changes
Mar 21, 2025
nodejs-github-bot
commented
Mar 21, 2025
Collaborator
nodejs-github-bot
commented
Mar 21, 2025
Collaborator
nodejs-github-bot
commented
Mar 21, 2025
Collaborator
richardlau
commented
Mar 26, 2025
MemberAuthor
Landed in fce923b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #54019
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Opening to see if backporting this fixes the coverage workflows for
v18.x-staging.