src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> by Aditi-1400 · Pull Request #57578 · nodejs/node

Aditi-1400 · 2025-03-21T14:22:03Z

According to V8's public API documentation, local handles (i.e., objects of type v8::Local) "should never be allocated on the heap". This replaces the usage of heap-allocated data structures containing instances of v8::Local, specifically the std::vector<v8::Local<v8::String>> with recently introduced v8::LocalVector<T>.

This is first of the series of commits to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>.

nodejs-github-bot · 2025-03-21T14:22:08Z

Review requested:

@nodejs/startup

codecov · 2025-03-21T15:41:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (922ce9d) to head (c8f2584).
Report is 183 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #57578 +/- ##
==========================================
- Coverage 90.23% 90.22% -0.02% 
==========================================
Files 629 630 +1 Lines 184939 185054 +115 Branches 36232 36249 +17 ==========================================
+ Hits 166885 166961 +76 - Misses 11011 11036 +25 - Partials 7043 7057 +14

Files with missing lines	Coverage Δ
src/node_builtins.cc	`79.12% <100.00%> (+1.13%)`	⬆️
src/node_builtins.h	`100.00% <ø> (ø)`

... and 57 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

According to V8's public API documentation, local handles (i.e., objects of type v8::Local<T>) "should never be allocated on the heap". This replaces the usage of heap-allocated data structures containing instances of `v8::Local`, specifically the `std::vector<v8::Local<v8::String>>` with recently introduced `v8::LocalVector<T>`. This is first of the series of commits to replace all `std::vector<v8::Local<T>>` to use `v8::LocalVector<T>`.

Refs: nodejs#57578

A follow up of nodejs#57578 to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T>

Refs: #57578 PR-URL: #57733 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

nodejs-github-bot · 2025-04-10T16:46:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66190/

Refs: #57578 PR-URL: #57646 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

According to V8's public API documentation, local handles (i.e., objects of type v8::Local<T>) "should never be allocated on the heap". This replaces the usage of heap-allocated data structures containing instances of `v8::Local`, specifically the `std::vector<v8::Local<v8::String>>` with recently introduced `v8::LocalVector<T>`. This is first of the series of commits to replace all `std::vector<v8::Local<T>>` to use `v8::LocalVector<T>`. PR-URL: #57578 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

A follow up of #57578 to replace all std::vector<v8::Local<T>> to use v8::LocalVector<T> PR-URL: #57642 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>