buffer: define global v8::CFunction objects as const by mertcanaltin · Pull Request #57676 · nodejs/node

mertcanaltin · 2025-03-29T16:35:57Z

objects I defined them as const so that they cannot be changed.

codecov · 2025-03-29T19:03:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (af75d04) to head (c4540be).
Report is 59 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #57676 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01% 
==========================================
Files 630 630 Lines 185055 185055 Branches 36221 36226 +5 ==========================================
- Hits 166984 166983 -1 + Misses 11043 11040 -3 - Partials 7028 7032 +4

Files with missing lines	Coverage Δ
src/node_buffer.cc	`67.13% <ø> (ø)`

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2025-04-01T11:46:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/65927/

nodejs-github-bot · 2025-04-05T15:40:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66049/

nodejs-github-bot · 2025-04-06T01:54:30Z

Landed in 74722a5

PR-URL: #57676 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

nodejs/node#57676

* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * src: disable abseil deadlock detection nodejs/node#57582 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs/node#57676

* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * src: disable abseil deadlock detection nodejs/node#57582 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs/node#57676

* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 * chore: fix out of date patch --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * src: disable abseil deadlock detection nodejs/node#57582 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

buffer: define global v8::CFunction objects as const
c4540be

nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 29, 2025

RaisinTen approved these changes Mar 30, 2025
View reviewed changes

jasnell approved these changes Apr 1, 2025
View reviewed changes

RaisinTen added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2025

addaleax approved these changes Apr 1, 2025
View reviewed changes

jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2025

RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 6, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 6, 2025

nodejs-github-bot merged commit 74722a5 into nodejs:mainApr 6, 2025

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
buffer: define global v8::CFunction objects as const
38368fb
PR-URL: #57676 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

RafaelGSS mentioned this pull request May 1, 2025
2025-05-06, Version 24.0.0 (Current) #57609
Merged

RafaelGSS pushed a commit that referenced this pull request May 2, 2025
buffer: define global v8::CFunction objects as const
619bf86
PR-URL: #57676 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

aduh95 pushed a commit that referenced this pull request May 6, 2025
buffer: define global v8::CFunction objects as const
2213b4b
PR-URL: #57676 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

RafaelGSS pushed a commit that referenced this pull request May 14, 2025
buffer: define global v8::CFunction objects as const
c85883f
PR-URL: #57676 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

aduh95 pushed a commit that referenced this pull request May 16, 2025
buffer: define global v8::CFunction objects as const
3e84588
PR-URL: #57676 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

aduh95 pushed a commit that referenced this pull request May 17, 2025
buffer: define global v8::CFunction objects as const
e589d32
PR-URL: #57676 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

github-actionsBot mentioned this pull request May 19, 2025
2025-05-21, Version 22.16.0 'Jod' (LTS) #58388
Merged

aduh95 pushed a commit that referenced this pull request May 19, 2025
buffer: define global v8::CFunction objects as const
d7d8e8e
PR-URL: #57676 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

codebytere added a commit to electron/electron that referenced this pull request May 23, 2025
buffer: define global v8::CFunction objects as const
1f57933
nodejs/node#57676

codebytere added a commit to electron/electron that referenced this pull request May 26, 2025
buffer: define global v8::CFunction objects as const
8fb7853
nodejs/node#57676

codebytere added a commit to electron/electron that referenced this pull request May 29, 2025
buffer: define global v8::CFunction objects as const
3dcabd6
nodejs/node#57676

codebytere added a commit to electron/electron that referenced this pull request Jun 2, 2025
buffer: define global v8::CFunction objects as const
62fef4c
nodejs/node#57676

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025
buffer: define global v8::CFunction objects as const
d80d402
nodejs/node#57676

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025
buffer: define global v8::CFunction objects as const
1b4a1c6
nodejs/node#57676

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025
buffer: define global v8::CFunction objects as const
72589fc
nodejs/node#57676

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025
buffer: define global v8::CFunction objects as const
e8ef4f4
nodejs/node#57676

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025
buffer: define global v8::CFunction objects as const
324b3ee
nodejs/node#57676

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025
buffer: define global v8::CFunction objects as const
1eb8e4a
nodejs/node#57676

codebytere added a commit to electron/electron that referenced this pull request Jun 6, 2025
buffer: define global v8::CFunction objects as const
99257ab
nodejs/node#57676

ghost mentioned this pull request Jun 8, 2025
### Notable Changes autofix-ci/action#28
Closed

codebytere added a commit to electron/electron that referenced this pull request Jun 18, 2025
buffer: define global v8::CFunction objects as const
1b7dba8
nodejs/node#57676

Navigation Menu

Uh oh!

Uh oh!

buffer: define global v8::CFunction objects as const - #57676

buffer: define global v8::CFunction objects as const#57676
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mertcanaltin:mert/fix/const-global-cfunctions

mertcanaltin commented Mar 29, 2025•
edited
Loading

Uh oh!

codecovBot commented Mar 29, 2025•
edited
Loading

Uh oh!

nodejs-github-bot commented Apr 1, 2025

Uh oh!

nodejs-github-bot commented Apr 5, 2025

Uh oh!

nodejs-github-bot commented Apr 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

mertcanaltin commented Mar 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecovBot commented Mar 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Apr 1, 2025

Uh oh!

nodejs-github-bot commented Apr 5, 2025

Uh oh!

nodejs-github-bot commented Apr 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mertcanaltin commented Mar 29, 2025•
edited
Loading

codecovBot commented Mar 29, 2025•
edited
Loading