src,lib,test: unflag --experimental-webstorage by default by danielmbrasil · Pull Request #57666 · nodejs/node

danielmbrasil · 2025-03-28T17:31:57Z

Added Web Storage support enabled by default, with the option to disable via --no-webstorage.

nodejs-github-bot · 2025-03-28T17:32:02Z

Review requested:

@nodejs/config

mcollina · 2025-03-28T18:00:00Z

To fix the failing test, I would change the error being throw in lib/internal/webstorage.js in a warning, and have localStorage be undefined in that case.

@cjihrig wdyt?

cjihrig · 2025-03-28T18:27:46Z

I would be OK with that behavior. However, the global checking logic in test/common/index.js would probably need to be updated. Otherwise, the new warning will probably be printed for every test that doesn't use localStorage.

danielmbrasil · 2025-03-28T20:28:21Z

I just pushed the suggested changes, and the tests are now passing. @cjihrig, could you please review whether the changes in test/common/index.js make sense?

cjihrig · 2025-03-28T20:32:58Z

Without running the code, it doesn't look correct to me:

globalThis[val] === undefined

By the time we find out that the value is undefined, the warning will have already been emitted, right?

danielmbrasil · 2025-03-28T20:37:00Z

By the time we find out that the value is undefined, the warning will have already been emitted, right?

Yeah, that's right. I'll take a look on how to avoid the warning to be emitted in those cases.

danielmbrasil · 2025-04-02T17:16:05Z

@cjihrig Could you take a look now and see if this is closer to what you were expecting? I added a new check to test/common/index.js that overrides the localStorage getter with an empty object. This prevents the warning from being emitted, and the tests are passing locally.

danielmbrasil · 2025-04-04T18:12:38Z

Moving this as ready for review. I think we should possibly also update doc/api/cli.md and doc/api/globals.md, but I'm not sure how to update those docs for now.

codecov · 2025-04-04T19:06:43Z

Codecov Report

❌ Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.28%. Comparing base (73b5022) to head (890a794).
⚠️ Report is 116 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/webstorage.js	80.00%	5 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #57666 +/- ##
==========================================
+ Coverage 88.26% 88.28% +0.02% 
==========================================
Files 701 701 Lines 206644 206676 +32 Branches 39737 39738 +1 ==========================================
+ Hits 182386 182472 +86 + Misses 16279 16237 -42 + Partials 7979 7967 -12

Files with missing lines	Coverage Δ
lib/internal/process/pre_execution.js	`97.15% <100.00%> (-0.28%)`	⬇️
src/node_options.cc	`77.89% <100.00%> (+0.02%)`	⬆️
src/node_options.h	`97.89% <100.00%> (ø)`
lib/internal/webstorage.js	`91.30% <80.00%> (-8.70%)`	⬇️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina · 2025-04-07T13:58:38Z

A few tests needs fixing but this is good progress!

geeksilva97 · 2025-05-26T13:33:01Z

This PR has some conflicts

mcollina

lgtm

geeksilva97

Appreciate your effort here, Daniel

assert: * (SEMVER-MAJOR) move assert.fail with multiple arguments to eol (James M Snell) #58532 * (SEMVER-MAJOR) move CallTracker to EOL (James M Snell) #58006 assert,util: * (SEMVER-MAJOR) fail promise comparison in deep equal checks (Ruben Bridgewater) #59448 * (SEMVER-MAJOR) handle invalid dates as equal in deep comparison (Ruben Bridgewater) #57627 async_hooks: * (SEMVER-MAJOR) move `asyncResource` property on bound function to EOL (James M Snell) #58618 buffer: * (SEMVER-MAJOR) move SlowBuffer to EOL (Filip Skokan) #58220 build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #59805 * (SEMVER-MAJOR) bump minimum Clang version to 19 (Michaël Zasso) #59048 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #58064 * (SEMVER-MAJOR) stop distributing Corepack (Antoine du Hamel) #57617 child_process: * (SEMVER-MAJOR) move _channel to end-of-life (James M Snell) #58527 crypto: * (SEMVER-MAJOR) runtime-deprecate default shake128/256 output lengths (Filip Skokan) #59008 * (SEMVER-MAJOR) move deprecated hash and mgf1Hash options to EOL (James M Snell) #58706 * (SEMVER-MAJOR) runtime deprecate ECDH.setPublicKey() (James M Snell) #58620 deps: * (SEMVER-MAJOR) patch V8 for illumos (Dan McDonald) #59805 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #54077 * (SEMVER-MAJOR) update V8 to 14.1.146.11 (Michaël Zasso) #59805 * (SEMVER-MAJOR) V8: backport 1d3362c55396 (Shu-yu Guo) #58064 * (SEMVER-MAJOR) V8: cherry-pick 4f38995c8295 (Shu-yu Guo) #58064 * (SEMVER-MAJOR) V8: cherry-pick 044b9b6f589d (Rezvan Mahdavi Hezaveh) #58064 * (SEMVER-MAJOR) V8: cherry-pick d2ad518a0b57 (Joyee Cheung) #58064 * (SEMVER-MAJOR) V8: revert 6d6c1e680c7b (Michaël Zasso) #58064 * (SEMVER-MAJOR) V8: revert e3cddbedb205 (Michaël Zasso) #58064 * (SEMVER-MAJOR) use std::map in MSVC STL for EphemeronRememberedSet (Joyee Cheung) #58064 * (SEMVER-MAJOR) patch V8 for illumos (Dan McDonald) #58064 * (SEMVER-MAJOR) remove problematic comment from v8-internal (Michaël Zasso) #58064 * (SEMVER-MAJOR) define V8_PRESERVE_MOST as no-op on Windows (Stefan Stojanovic) #58064 * (SEMVER-MAJOR) fix FP16 bitcasts.h (Stefan Stojanovic) #58064 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #58064 * (SEMVER-MAJOR) update V8 to 13.7.152.9 (Michaël Zasso) #58064 dgram: * (SEMVER-MAJOR) move deprecated APIs to EOL (James M Snell) #58474 dns: * (SEMVER-MAJOR) move falsy hostname in lookup to end-of-life (James M Snell) #58619 doc,src,test: * (SEMVER-MAJOR) replace use of deprecated `GetIsolate` (Michaël Zasso) #59805 fs: * (SEMVER-MAJOR) move FileHandle close on GC to EOL (James M Snell) #58536 * (SEMVER-MAJOR) move rmdir recursive option to end-of-life (James M Snell) #58616 * (SEMVER-MAJOR) make `processReadResult()` and `readSyncRecursive()` private (Livia Medeiros) #58672 * (SEMVER-MAJOR) move fs stream open method to eol (James M Snell) #58529 * (SEMVER-MAJOR) remove `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) #55862 http: * (SEMVER-MAJOR) deprecate writeHeader (Sebastian Beltran) #59060 lib: * (SEMVER-MAJOR) use validators for argument validation (Nam Yooseong) #59416 * (SEMVER-MAJOR) expose global ErrorEvent (Richie Bendall) #58920 * (SEMVER-MAJOR) deprecate `_stream_*` modules (Dario Piotrowicz) #58337 * (SEMVER-MAJOR) deprecate _tls_common and _tls_wrap (Dario Piotrowicz) #57643 module: * (SEMVER-MAJOR) move Module._debug to end-of-life (James M Snell) #58473 node-api: * (SEMVER-MAJOR) add warning for NAPI_EXPERIMENTAL (Miguel Marcondes Filho) #58280 perf_hooks: * (SEMVER-MAJOR) move deprecated accessors to EOF (James M Snell) #58531 process: * (SEMVER-MAJOR) move multipleResolves event to EOL (James M Snell) #58707 repl: * (SEMVER-MAJOR) eol deprecate instantiating without new (Aviv Keller) #59495 src: * (SEMVER-MAJOR) update crypto.getCipherInfo() to use DictionaryTemplate (James M Snell) #60036 * (SEMVER-MAJOR) fix calls to v8::Object::wrap (Andreas Haas) #59805 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 141 (Michaël Zasso) #59805 * (SEMVER-MAJOR) improve performance of dotenv ToObject (James M Snell) #60038 * (SEMVER-MAJOR) use std::string_view from node_report (iknoom) #60006 * (SEMVER-MAJOR) unflag --experimental-webstorage by default (Daniel M Brasil) #57666 * (SEMVER-MAJOR) store `Local` for `CallbackScope` on stack (Anna Henningsen) #59705 * (SEMVER-MAJOR) remove node.h APIs to make callback without an async context (Chengzhong Wu) #58471 * (SEMVER-MAJOR) remove deprecated node::EmitBeforeExit and node::EmitExit (Chengzhong Wu) #58469 * (SEMVER-MAJOR) remove deprecated node::CreatePlatform and node::FreePlatform (Chengzhong Wu) #58470 * (SEMVER-MAJOR) remove deprecated node::InitializeNodeWithArgs (Chengzhong Wu) #58470 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 138 (Michaël Zasso) #58064 src,permission: * (SEMVER-MAJOR) add --allow-net permission (Rafael Gonzaga) #58517 test: * (SEMVER-MAJOR) update cppgc-object addon config (StefanStojanovic) #59805 * (SEMVER-MAJOR) spin longer for sequential/test-worker-prof (Michaël Zasso) #59805 * (SEMVER-MAJOR) remove `--always-turbofan` flag (Michaël Zasso) #59805 * (SEMVER-MAJOR) update snapshot for V8 14.1 (Michaël Zasso) #59805 test,win: * (SEMVER-MAJOR) split addon tests (StefanStojanovic) #59805 tls: * (SEMVER-MAJOR) move IP-address servername deprecation to eol (James M Snell) #58533 tools: * (SEMVER-MAJOR) update V8 gypfiles for 14.0 (Michaël Zasso) #59805 * (SEMVER-MAJOR) update V8 gypfiles for 13.9 (Michaël Zasso) #59805 * (SEMVER-MAJOR) update V8 gypfiles for 13.8 (Michaël Zasso) #59805 * (SEMVER-MAJOR) enable leaptiering for aix/ibmi (Abdirahim Musse) #59805 * (SEMVER-MAJOR) update V8 gypfiles for 13.7 (Michaël Zasso) #58064 url: * (SEMVER-MAJOR) move bad port deprecation in legacy url to end-of-life (James M Snell) #58617 util,console: * (SEMVER-MAJOR) colorize regexp groups, character classes, etc (Ruben Bridgewater) #59710 worker: * (SEMVER-MAJOR) move terminate callback to end-of-life (James M Snell) #58528 PR-URL: #59896 Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>

Node.js 25 became "current" and our CI is now testing it. We now have a failure because "localStorage" is now a thing in Node.js but it's not properly enabled without the arg. So @typescript/vfs, which in the browser detects a "localStorage" and tries to use it (but previously in Node.js wouldn't find it so wouldn't try) finds an implementation that's incomplete. This change activates it, so we don't get the error. But we don't really need it, so this can be wound back when we have a fix in vfs or somewhere else in the stack. Ref: nodejs/node#57666 Ref: microsoft/TypeScript-Website#3449 Ref: microsoft/TypeScript-Website#3450

For now, web storage is enabled by default. Refs: nodejs#57666

For now, web storage is enabled by default. Refs: #57666 PR-URL: #60363 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

因 nodejs/node#57666 原因，与 webStorage 相关的测试暂时不兼容。

…Ozone#329) Node.js 25 became "current" and our CI is now testing it. We now have a failure because "localStorage" is now a thing in Node.js but it's not properly enabled without the arg. So @typescript/vfs, which in the browser detects a "localStorage" and tries to use it (but previously in Node.js wouldn't find it so wouldn't try) finds an implementation that's incomplete. This change activates it, so we don't get the error. But we don't really need it, so this can be wound back when we have a fix in vfs or somewhere else in the stack. Ref: nodejs/node#57666 Ref: microsoft/TypeScript-Website#3449 Ref: microsoft/TypeScript-Website#3450

…rkers The Node 26.x leg added in the previous commit failed CI: Node >=25 enables a native `localStorage` global by default (nodejs/node#57666), which throws a DOMException without --localstorage-file and shadows jsdom's own window.localStorage before vitest-environment-jsdom can install it. Every test touching localStorage saw it as undefined (WhatsNewModal.test.tsx, page.test.tsx's BITB-029 case), while 22.x was unaffected since the global is opt-in-only before Node 25. Pass --no-experimental-webstorage to vitest's worker processes via the now-flat `execArgv` option (Vitest 4 removed the old `poolOptions.threads/forks.execArgv` nesting) so jsdom's localStorage wins again. Verified 773/773 unit tests, lint, and type-check pass locally with the flag applied; confirmed via Node's own changelog that the flag was introduced alongside --experimental-webstorage in v22.4.0, so it's a recognized no-op on the 22.x leg too. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NQfpC1H5MQRgQWuTfyWSMp

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Mar 28, 2025

danielmbrasil mentioned this pull request Mar 28, 2025
Unflag --experimental-webstorage #57658
Closed

danielmbrasil force-pushed the src/unflag-experimental-webstorage branch from b925ca4 to db0cda3Compare April 2, 2025 17:11

danielmbrasil changed the title ~~src: unflag --experimental-webstorage by default~~src,lib,test: unflag --experimental-webstorage by defaultApr 4, 2025

danielmbrasil marked this pull request as ready for review April 4, 2025 18:12

danielmbrasil force-pushed the src/unflag-experimental-webstorage branch 2 times, most recently from 67c3460 to 1857c7fCompare April 7, 2025 16:51

danielmbrasil commented Apr 7, 2025
View reviewed changes

Comment threadtest/common/index.js Outdated

danielmbrasil force-pushed the src/unflag-experimental-webstorage branch 2 times, most recently from 3cda35a to f075423Compare May 26, 2025 18:50

geeksilva97 reviewed May 26, 2025
View reviewed changes

Comment threaddoc/api/globals.md Outdated

geeksilva97 reviewed May 27, 2025
View reviewed changes

Comment threadtest/parallel/test-webstorage.js Outdated

mcollina approved these changes May 27, 2025
View reviewed changes

danielmbrasil force-pushed the src/unflag-experimental-webstorage branch from 6a4ce9f to 6f567abCompare May 27, 2025 12:37

geeksilva97 approved these changes May 27, 2025
View reviewed changes

cjihrig reviewed May 27, 2025
View reviewed changes

Comment threadlib/internal/webstorage.js Outdated

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2025

This was referenced Oct 17, 2025
@typescript/vfs is not Node.js 25 compatible (localStorage.getItem is not a function) microsoft/TypeScript-Website#3449
Closed
Add proper localStorage availability checks to support Node v25 in @typescript/vfs microsoft/TypeScript-Website#3450
Merged

Renegade334 mentioned this pull request Oct 17, 2025
localStorage's behaviour when no or invalid --localstorage-file provided #60303
Closed

rvagg mentioned this pull request Oct 20, 2025
docs(ci): enable localStorage in Node.js 25 to avoid build error FilOzone/synapse-sdk#329
Merged

simonmysun mentioned this pull request Oct 22, 2025
Node v25 breaks tests with Web Storage API vitest-dev/vitest#8757
Closed
6 tasks

Renegade334 mentioned this pull request Oct 22, 2025
lib: throw from localStorage getter on missing storage path #60351
Merged

deokjinkim added a commit to deokjinkim/node that referenced this pull request Oct 22, 2025
doc: remove unnecessary statement of web storage
88bf5a5
For now, web storage is enabled by default. Refs: nodejs#57666

deokjinkim mentioned this pull request Oct 22, 2025
doc: remove unnecessary statement of web storage #60363
Merged

Yovach mentioned this pull request Oct 24, 2025
Update @typescript/vfs to version 1.6.2 bufbuild/protobuf-es#1274
Merged

brianhelba mentioned this pull request Nov 12, 2025
Issues with Node 25 capricorn86/happy-dom#1950
Open

aduh95 mentioned this pull request Nov 13, 2025
doc,src,lib: clarify experimental status of Web Storage support #60708
Merged

caixw added a commit to issue9/cmfx that referenced this pull request Nov 18, 2025
refactor: actions 将 node 改为 24
c644cf1
因 nodejs/node#57666 原因，与 webStorage 相关的测试暂时不兼容。

coderabbitaiBot mentioned this pull request Mar 27, 2026
Replace Node.js built-ins with Web APIs for browser compatibility airframesio/acars-decoder-typescript#380
Merged
5 tasks

derekpierre mentioned this pull request Apr 10, 2026
Min dev node version nucypher/taco-web#773
Merged
7 tasks

Conduitry mentioned this pull request Apr 17, 2026
fix: Fix 500 error due to undefined storage sveltejs/svelte.dev#1939
Closed
3 tasks

E-Lop mentioned this pull request Jun 16, 2026
test: localStorage funzionante nei test jsdom su Node 25+ (closes #40) E-Lop/entro#42
Merged

kevinswiber mentioned this pull request Jul 7, 2026
test: shield the web suite from Node's built-in web storage withpointbreak/pointbreak#416
Merged

coderabbitaiBot mentioned this pull request Jul 9, 2026
test: clean web runner warnings terarush/ping-uptime#49
Merged

This was referenced Aug 3, 2026
Standardise on Node 24 LTS across Docker, CI and engines rusahu/chordvault#121
Closed
Standardise on Node 24 LTS across Docker, CI and engines rusahu/chordvault#122
Merged

Uh oh!

Uh oh!

Conversation

danielmbrasil commented Mar 28, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 28, 2025

Uh oh!

mcollina commented Mar 28, 2025

Uh oh!

cjihrig commented Mar 28, 2025

Uh oh!

danielmbrasil commented Mar 28, 2025

Uh oh!

cjihrig commented Mar 28, 2025

Uh oh!

danielmbrasil commented Mar 28, 2025

Uh oh!

danielmbrasil commented Apr 2, 2025

Uh oh!

danielmbrasil commented Apr 4, 2025

Uh oh!

codecovBot commented Apr 4, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mcollina commented Apr 7, 2025

Uh oh!

Uh oh!

geeksilva97 commented May 26, 2025

Uh oh!

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

geeksilva97 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

danielmbrasil commented Mar 28, 2025•
edited
Loading

codecovBot commented Apr 4, 2025•
edited
Loading