Skip to content

tools: update ESLint to 9.23 - #57673

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:update-eslint
Mar 31, 2025
Merged

tools: update ESLint to 9.23#57673
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:update-eslint

Conversation

@aduh95

@aduh95aduh95 commented Mar 29, 2025

Copy link
Copy Markdown
Contributor

Not sure why Dependabot is not picking it up 🤷‍♂️

@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Mar 29, 2025
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 29, 2025
@aduh95aduh95 mentioned this pull request Mar 29, 2025
Merged
@codecov

codecovBot commented Mar 29, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (af75d04) to head (deb6f3f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57673 +/- ##
==========================================
- Coverage 90.23% 90.22% -0.01% 
==========================================
Files 630 630 Lines 185055 185055 Branches 36221 36221 ==========================================
- Hits 166984 166967 -17 - Misses 11043 11046 +3 - Partials 7028 7042 +14

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65909/

@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 31, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 5812a61 into nodejs:mainMar 31, 2025
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2025

Copy link
Copy Markdown
Collaborator

Landed in 5812a61

@aduh95
aduh95 deleted the update-eslint branch March 31, 2025 18:36
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@aduh95@RafaelGSS
tools: update ESLint to 9.23
f11293e
PR-URL: #57673
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@aduh95@RafaelGSS
tools: update ESLint to 9.23
cf02cdb
PR-URL: #57673
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 added a commit that referenced this pull request May 6, 2025
@aduh95
tools: update ESLint to 9.23
b9ddc41
PR-URL: #57673
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@aduh95@RafaelGSS
tools: update ESLint to 9.23
b88cd0e
PR-URL: #57673
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
tools: update ESLint to 9.23
fe52133
PR-URL: #57673
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request May 19, 2025
Merged
aduh95 added a commit that referenced this pull request May 19, 2025
@aduh95
tools: update ESLint to 9.23
f4d7cba
PR-URL: #57673
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
@ghostghost mentioned this pull request Jun 8, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@geeksilva97geeksilva97geeksilva97 approved these changes
@jakecastellijakecastellijakecastelli approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95@nodejs-github-bot@lpinca@cjihrig@geeksilva97@jakecastelli