Skip to content

tools: enable linter on some fixtures file - #57674

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:lint-snapshot-files-passing
Apr 1, 2025
Merged

tools: enable linter on some fixtures file#57674
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:lint-snapshot-files-passing

Conversation

@aduh95

@aduh95aduh95 commented Mar 29, 2025

Copy link
Copy Markdown
Contributor

Those files used to be linted, until b6738c1 moved them to the fixtures/ dir, which is excluded from lint rules (for good reasons, we have there files that are purposefully testing e.g. edge-case syntax which would be forbidden in the other areas of the codebase). However, with the recent addition of globalIgnores (pending #57673), it's now possible for us to define more precise rules regarding which files are ignored.

(I've chosen to enable it only on subfolder where the files are already passing the linter, I'll open follow-up PRs to enable it in more areas, but the diff is too large for a single PR, see https://github.com/nodejs/node/compare/main...aduh95:node:lint-snapshot-files?expand=1)

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Mar 29, 2025
@codecov

codecovBot commented Mar 29, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (5812a61) to head (a3caa87).
Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #57674 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01% 
==========================================
Files 630 630 Lines 185055 185055 Branches 36220 36218 -2 ==========================================
- Hits 166986 166985 -1 - Misses 11039 11040 +1 
Partials 7030 7030 

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
aduh95force-pushed the lint-snapshot-files-passing branch from e8baca1 to a3caa87CompareMarch 31, 2025 18:36
@aduh95aduh95 removed the needs-ci PRs that need a full CI run. label Mar 31, 2025
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 31, 2025
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 1, 2025
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 1, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/57674
✔ Done loading data for nodejs/node/pull/57674
----------------------------------- PR info ------------------------------------
Title tools: enable linter on some fixtures file (#57674)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch aduh95:lint-snapshot-files-passing -> nodejs:main
Labels tools, author ready
Commits 1
- tools: enable linter on some fixtures file
Committers 1
- Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/57674
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57674
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
--------------------------------------------------------------------------------
ℹ This PR was created on Sat, 29 Mar 2025 13:52:29 GMT
✔ Approvals: 2
✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/57674#pullrequestreview-2730474037
✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/57674#pullrequestreview-2731759969
✔ Last GitHub CI successful
✘ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/14190984322

@aduh95
aduh95 merged commit 0d91070 into nodejs:mainApr 1, 2025
@aduh95

Copy link
Copy Markdown
ContributorAuthor

Landed in 0d91070

@aduh95
aduh95 deleted the lint-snapshot-files-passing branch April 1, 2025 08:36
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
PR-URL: #57674
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
PR-URL: #57674
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 added a commit that referenced this pull request May 6, 2025
PR-URL: #57674
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
PR-URL: #57674
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 added a commit that referenced this pull request May 17, 2025
PR-URL: #57674
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 added a commit that referenced this pull request May 19, 2025
PR-URL: #57674
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@ghostghost mentioned this pull request Jun 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@nodejs-github-bot@targos@MoLow