esm: implement import.meta.main by Lordfirespeed · Pull Request #57804 · nodejs/node

Lordfirespeed · 2025-04-09T12:12:47Z

Implements #57226

This PR supersedes #32223

nodejs-github-bot · 2025-04-09T12:12:52Z

Review requested:

@nodejs/loaders

Lordfirespeed · 2025-04-09T12:17:55Z

@ljharb I would appreciate your review on this r.e. performance - I am particularly concerned about my changes in lib/internal/modules/esm/translators.js, since I'm not familiar with implications of assignment to a JS object associated with a native object.

codecov · 2025-04-09T15:50:14Z

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.22%. Comparing base (b197355) to head (41d80f0).
Report is 222 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/main/worker_thread.js	92.85%	1 Missing ⚠️
lib/internal/modules/esm/loader.js	80.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #57804 +/- ##
==========================================
- Coverage 90.23% 90.22% -0.02% 
==========================================
Files 633 633 Lines 186818 186844 +26 Branches 36668 36682 +14 ==========================================
- Hits 168578 168575 -3 - Misses 11036 11045 +9 - Partials 7204 7224 +20

Files with missing lines	Coverage Δ
lib/internal/modules/esm/initialize_import_meta.js	`100.00% <100.00%> (ø)`
lib/internal/modules/esm/translators.js	`91.59% <100.00%> (+0.01%)`	⬆️
lib/internal/modules/esm/utils.js	`98.94% <100.00%> (+0.02%)`	⬆️
lib/internal/worker.js	`99.82% <100.00%> (-0.01%)`	⬇️
lib/internal/main/worker_thread.js	`94.40% <92.85%> (-0.08%)`	⬇️
lib/internal/modules/esm/loader.js	`95.98% <80.00%> (-0.09%)`	⬇️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Lordfirespeed · 2025-04-10T10:54:35Z

@ljharb I've moved the assignment into compileSourceTextModule, but I'm a bit confused

I think I can see where the cache is populated, but not where it is hit in compileSourceTextModule (unless it's in CPP?)
That leads me to think the cache gets hit at some point before the standard moduleStrategy function is used, which would mean moving the assignment either has no effect or is detrimental.

What am I missing?

Lordfirespeed · 2025-04-17T12:08:19Z

I think CI should pass now. make -j$(nproc) test is passing locally.

Lordfirespeed · 2025-04-17T15:45:42Z

I checked locally, it seems the test no longer fails with unusual character names using a relative import path.

mcollina

lgtm

github-actions · 2025-04-18T09:21:03Z

The notable-changePRs with changes that should be highlighted in changelogs. label has been added by @mcollina.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

nodejs-github-bot · 2025-04-18T09:33:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66343/

targos · 2025-04-18T09:37:00Z

There's a test for import.meta.main === false, but not for true, I think?

LiviaMedeiros · 2025-04-18T10:47:11Z

There's a test for import.meta.main === false, but not for true, I think?

There is: https://github.com/nodejs/node/blob/37091e661b0d048252389d894858f42d960c3df1/test/es-module/test-esm-import-meta-main.mjs#L4

But it would still be nice to cover more cases, e.g.:

worker threads
child process (exec, fork)
--eval

nodejs-github-bot · 2025-04-19T15:24:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/66367/

Notable changes: deps: * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350 doc: * add islandryu to collaborators (Shima Ryuhei) #58714 esm: * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490 module: * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350 * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853 sqlite: * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697 src,permission: * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951 url: * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719 worker: * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385 PR-URL: #59256 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Notable changes: deps: * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) nodejs#56350 doc: * add islandryu to collaborators (Shima Ryuhei) nodejs#58714 esm: * (SEMVER-MINOR) implement `import.meta.main` (Joe) nodejs#57804 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) nodejs#58490 module: * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) nodejs#56350 * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) nodejs#56350 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) nodejs#58853 sqlite: * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) nodejs#58697 src,permission: * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) nodejs#58951 url: * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) nodejs#58700 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) nodejs#58719 worker: * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) nodejs#58385 PR-URL: nodejs#59256 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Apr 9, 2025

Lordfirespeed force-pushed the import-meta-main branch from 135a7a1 to f31d130Compare April 9, 2025 12:15

aduh95 reviewed Apr 9, 2025
View reviewed changes

Comment threadtest/es-module/test-esm-import-meta.mjs Outdated

Lordfirespeed force-pushed the import-meta-main branch from 5452731 to b677069Compare April 9, 2025 13:55

marco-ippolito reviewed Apr 9, 2025
View reviewed changes

Comment threaddoc/api/esm.md Outdated

Lordfirespeed force-pushed the import-meta-main branch from 6bdcad8 to 6613f1dCompare April 9, 2025 14:04

ljharb reviewed Apr 9, 2025
View reviewed changes

Comment threadlib/internal/modules/esm/translators.js Outdated

JakobJingleheimer reviewed Apr 9, 2025
View reviewed changes

Comment threadlib/internal/modules/esm/translators.js Outdated
Comment threadlib/internal/modules/esm/initialize_import_meta.js Outdated

Lordfirespeed force-pushed the import-meta-main branch from c4619a4 to eb4e8a7Compare April 10, 2025 02:29

ljharb reviewed Apr 14, 2025
View reviewed changes

Comment threadlib/internal/modules/esm/translators.js Outdated

joyeecheung mentioned this pull request Apr 15, 2025
import.meta.main #57226
Closed

jasnell approved these changes Apr 17, 2025
View reviewed changes

mcollina approved these changes Apr 18, 2025
View reviewed changes

mcollina added notable-change PRs with changes that should be highlighted in changelogs. semver-minor PRs that contain new features and should be released in the next minor version. labels Apr 18, 2025

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2025

aduh95 reviewed Apr 19, 2025
View reviewed changes

Comment threadlib/internal/modules/esm/utils.js Outdated

github-actionsBot mentioned this pull request Jul 28, 2025
2025-07-29, Version 22.18.0 'Jod' (LTS) #59256
Merged

sosoba mentioned this pull request Aug 12, 2025
How to determine whether a file has been run directly inside ES module nodejs/help#2065
Closed

connorjclark mentioned this pull request Aug 27, 2025
Bump minimum supported Node to 22 GoogleChrome/lighthouse#16643
Closed

secustor mentioned this pull request Sep 2, 2025
[@backstage/cli] repo start fails to detect ES module state with Node.JS 22.17.0 backstage/backstage#31042
Closed
2 tasks

TheAlexLichter mentioned this pull request Sep 10, 2025
refactor!: avoid import.meta polyfill nitrojs/nitro#3213
Merged

coderabbitaiBot mentioned this pull request Sep 22, 2025
build: Enable live reloading using web-ext, esbuild, and chokidar dvanoni/notero#738
Merged

charlesbodman mentioned this pull request Dec 6, 2025
Massimo cli not working platformatic/massimo#12
Closed

erickzhao mentioned this pull request Mar 18, 2026
fix: prune final require calls electron/forge#4176
Merged

coderabbitaiBot mentioned this pull request Mar 20, 2026
[PET-42] Replace @expo/vector-icons with lucide-react-nativezigcccc/petka-app#43
Merged

This was referenced Mar 27, 2026
fix(create-agentuity): match dist-tag logic with publish script agentuity/sdk#1288
Merged
chore: initial monorepo setup KumarSashank/AI-Product-Manager#1
Merged

This was referenced Apr 14, 2026
feat(ci): migration safety lint + Conventional Commits enforcement (Phase 1+2) kkzakaria/netereka#155
Merged
feat: brewing system for architectural-invariant proposals ms2sato/agent-console#665
Merged

This was referenced May 2, 2026
Add npm package distribution infrastructure kjanat/runner#5
Merged
feat: add create-mulmoclaude-plugin CLI scaffold (PR1 of #1159) receptron/mulmoclaude#1163
Merged

AlCalzone mentioned this pull request May 13, 2026
Consider further Node.js version bumps zwave-js/zwave-js#8820
Closed

Uh oh!

Uh oh!

Conversation

Lordfirespeed commented Apr 9, 2025• edited by aduh95 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 9, 2025

Uh oh!

Lordfirespeed commented Apr 9, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Apr 9, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lordfirespeed commented Apr 10, 2025

Uh oh!

Uh oh!

Lordfirespeed commented Apr 17, 2025

Uh oh!

Lordfirespeed commented Apr 17, 2025

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Apr 18, 2025

Uh oh!

nodejs-github-bot commented Apr 18, 2025

Uh oh!

targos commented Apr 18, 2025

Uh oh!

LiviaMedeiros commented Apr 18, 2025

Uh oh!

nodejs-github-bot commented Apr 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Lordfirespeed commented Apr 9, 2025•
edited by aduh95
Loading

Lordfirespeed commented Apr 9, 2025•
edited
Loading

codecovBot commented Apr 9, 2025•
edited
Loading