New SQlite database options by miguelmarcondesf · Pull Request #58697 · nodejs/node

miguelmarcondesf · 2025-06-12T18:50:36Z

This introduces new SQLite database options that can be set at the database connection level.

cc @geeksilva97

…ection

nodejs-github-bot · 2025-06-12T18:50:40Z

Review requested:

@nodejs/sqlite

codecov · 2025-06-13T12:23:39Z

Codecov Report

Attention: Patch coverage is 94.59459% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.11%. Comparing base (5457443) to head (5693d3c).
Report is 67 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	92.00%	0 Missing and 4 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #58697 +/- ##
==========================================
+ Coverage 90.03% 90.11% +0.07% 
==========================================
Files 635 639 +4 Lines 187688 188262 +574 Branches 36761 36924 +163 ==========================================
+ Hits 168991 169654 +663 + Misses 11499 11326 -173 - Partials 7198 7282 +84

Files with missing lines	Coverage Δ
src/node_sqlite.h	`83.67% <100.00%> (+15.67%)`	⬆️
src/node_sqlite.cc	`81.06% <92.00%> (+0.26%)`	⬆️

... and 78 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

geeksilva97 · 2025-06-17T13:02:20Z

~~Since it's addressing a TODO comment, you need to remove it from the code. I was unable to see it~~

I'm wrong

geeksilva97 · 2025-06-18T14:47:57Z

There are a few tests I think we don't need because they are redundant, e.g., those that handle the default scenario. Here, for example, the default is false already, which is already covered.

Other than that, I think you addressed the left comments as expected. Thank you.

I will just ping @nodejs/cpp-reviewers to get a more experienced C++ review.

RafaelGSS

cpp code LGTM.

lemire

My suggested changes are optional.

Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>

nodejs-github-bot · 2025-06-24T03:45:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/67630/

nodejs-github-bot · 2025-06-24T14:26:09Z

Landed in d08513d

PR-URL: #58697 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

Notable changes: crypto: * (SEMVER-MINOR) support outputLength option in crypto.hash for XOF functions (Aditi) #58121 doc: * (SEMVER-MINOR) add all watch-mode related flags to node.1 (Dario Piotrowicz) #58719 fs: * (SEMVER-MINOR) add disposable mkdtempSync (Kevin Gibbons) #58516 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853 sqlite: * (SEMVER-MINOR) add support for readBigInts option in db connection level (Miguel Marcondes Filho) #58697 src,permission: * (SEMVER-MINOR) add support to permission.has(addon) (Rafael Gonzaga) #58951 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719 PR-URL: #58993

PR-URL: #58697 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>

Notable changes: deps: * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) #56350 doc: * add islandryu to collaborators (Shima Ryuhei) #58714 esm: * (SEMVER-MINOR) implement `import.meta.main` (Joe) #57804 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) #58490 module: * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) #56350 * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) #56350 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) #58853 sqlite: * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) #58697 src,permission: * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) #58951 url: * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) #58700 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) #58719 worker: * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) #58385 PR-URL: #59256 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Notable changes: deps: * (SEMVER-MINOR) update amaro to 1.1.0 (Node.js GitHub Bot) nodejs#56350 doc: * add islandryu to collaborators (Shima Ryuhei) nodejs#58714 esm: * (SEMVER-MINOR) implement `import.meta.main` (Joe) nodejs#57804 fs: * (SEMVER-MINOR) allow correct handling of burst in fs-events with AsyncIterator (Philipp Dunkel) nodejs#58490 module: * (SEMVER-MINOR) remove experimental warning from type stripping (Marco Ippolito) nodejs#56350 * (SEMVER-MINOR) unflag `--experimental-strip-types` (Marco Ippolito) nodejs#56350 permission: * (SEMVER-MINOR) propagate permission model flags on spawn (Rafael Gonzaga) nodejs#58853 sqlite: * (SEMVER-MINOR) add support for `readBigInts` option in db connection level (Miguel Marcondes Filho) nodejs#58697 src,permission: * (SEMVER-MINOR) add support to `permission.has(addon)` (Rafael Gonzaga) nodejs#58951 url: * (SEMVER-MINOR) add `fileURLToPathBuffer` API (James M Snell) nodejs#58700 watch: * (SEMVER-MINOR) add `--watch-kill-signal` flag (Dario Piotrowicz) nodejs#58719 worker: * (SEMVER-MINOR) make `Worker` async disposable (James M Snell) nodejs#58385 PR-URL: nodejs#59256 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

miguelmarcondesf added 6 commits June 11, 2025 17:52

sqlite: add support for readBigInts option in db connection level
6836df6

sqlite: add readBigInts as env property
68889b1

sqlite: add support for returnArrays option in db connection
2f589fa

sqlite: add support for allowBareNamedParameters option in db connection
88be767

sqlite: add support for allowUnknownNamedParameters option in db conn…
917a093
…ection

doc: document new options for database connection
1aca01e

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 12, 2025

miguelmarcondesf marked this pull request as ready for review June 13, 2025 11:29

geeksilva97 reviewed Jun 17, 2025
View reviewed changes

Comment threadtest/parallel/test-sqlite-database-sync.js Outdated

geeksilva97 reviewed Jun 17, 2025
View reviewed changes

Comment threadtest/parallel/test-sqlite-database-sync.js Outdated

doc: update SQLite documentation with changes
7f0c06b

miguelmarcondesf requested a review from geeksilva97 June 17, 2025 20:05

geeksilva97 added the sqlite Issues and PRs related to the SQLite subsystem. label Jun 18, 2025

RafaelGSS reviewed Jun 18, 2025
View reviewed changes

Comment threaddoc/api/sqlite.md Outdated

RafaelGSS added semver-minor PRs that contain new features and should be released in the next minor version. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 18, 2025

RafaelGSS approved these changes Jun 18, 2025
View reviewed changes

lemire reviewed Jun 18, 2025
View reviewed changes

Comment threadsrc/node_sqlite.cc Outdated

lemire reviewed Jun 18, 2025
View reviewed changes

Comment threadsrc/node_sqlite.cc Outdated

lemire reviewed Jun 18, 2025
View reviewed changes

Comment threadsrc/node_sqlite.cc Outdated

lemire reviewed Jun 18, 2025
View reviewed changes

Comment threadsrc/node_sqlite.cc Outdated

lemire approved these changes Jun 18, 2025
View reviewed changes

miguelmarcondesfand others added 2 commits June 18, 2025 12:28

test: remove redundant default values tests
d7f08c0

doc: fix replacemme
a0d04ad
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>

This comment was marked as outdated.
Sign in to view

geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2025

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2025

This comment was marked as outdated.
Sign in to view

geeksilva97 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 20, 2025

This comment was marked as outdated.
Sign in to view

geeksilva97 requested a review from cjihrig June 23, 2025 13:37

geeksilva97 added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jun 24, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 24, 2025

nodejs-github-bot merged commit d08513d into nodejs:mainJun 24, 2025
36 checks passed

github-actionsBot mentioned this pull request Jul 8, 2025
2025-07-09, Version 24.4.0 (Current) #58993
Merged

github-actionsBot mentioned this pull request Jul 28, 2025
2025-07-29, Version 22.18.0 'Jod' (LTS) #59256
Merged

varanauskas mentioned this pull request Nov 19, 2025
node:sqlite is missing options present since Node v24.4.0 (backported to v22.18.0) denoland/deno#31346
Closed

Uh oh!

Uh oh!

Conversation

miguelmarcondesf commented Jun 12, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 12, 2025

Uh oh!

codecovBot commented Jun 13, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

geeksilva97 commented Jun 17, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

geeksilva97 commented Jun 18, 2025

Uh oh!

Uh oh!

RafaelGSS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lemire left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Jun 24, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

miguelmarcondesf commented Jun 12, 2025•
edited
Loading

codecovBot commented Jun 13, 2025•
edited
Loading

geeksilva97 commented Jun 17, 2025•
edited
Loading