Skip to content

[v22.x backport] tools: extract target abseil to abseil.gyp - #57982

Merged
aduh95 merged 2 commits into
nodejs:v22.x-stagingfrom
legendecas:backport-57289-to-22
May 18, 2025
Merged

[v22.x backport] tools: extract target abseil to abseil.gyp#57982
aduh95 merged 2 commits into
nodejs:v22.x-stagingfrom
legendecas:backport-57289-to-22

Conversation

@legendecas

@legendecaslegendecas commented Apr 22, 2025

Copy link
Copy Markdown
Member

Both V8 and perfetto depends on abseil. When perfetto support is enabled, V8 also depends on perfetto.

In order to share abseil between perfetto and V8 targets, and avoid cycle dependencies between v8.gyp and perfetto.gyp, this extracts target abseil from v8.gyp to an independent file abseil.gyp.

PR-URL: #57289
Refs: nodejs/diagnostics#654
Reviewed-By: Richard Lau rlau@redhat.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com

@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@legendecaslegendecas changed the title tools: extract target abseil to abseil.gyp[v22.x] tools: extract target abseil to abseil.gypApr 22, 2025
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Apr 22, 2025
@aduh95aduh95 changed the title [v22.x] tools: extract target abseil to abseil.gyp[v22.x backport] tools: extract target abseil to abseil.gypMay 6, 2025
@aduh95aduh95 mentioned this pull request May 6, 2025
Merged
@aduh95

aduh95 commented May 6, 2025

Copy link
Copy Markdown
Contributor

Can you add #57582 and #57870 to this PR please?

@legendecas
legendecasforce-pushed the backport-57289-to-22 branch from b6af552 to ee5f46aCompareMay 12, 2025 12:56
@legendecas

legendecas commented May 12, 2025

Copy link
Copy Markdown
MemberAuthor

Added #57582 to this backport.

#57870 should not be backported though. Removed backport label on it.

@RafaelGSS
RafaelGSS requested a review from a team as a code ownerMay 14, 2025 20:50
@aduh95
aduh95force-pushed the backport-57289-to-22 branch from ee5f46a to c8e3383CompareMay 17, 2025 12:36
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2025
@nodejs-github-bot

nodejs-github-bot commented May 17, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66860/

@aduh95
aduh95force-pushed the v22.x-staging branch 3 times, most recently from e0a025a to d03f13aCompareMay 17, 2025 13:54
@aduh95
aduh95force-pushed the backport-57289-to-22 branch from c8e3383 to 3149aafCompareMay 17, 2025 13:55
@nodejs-github-bot

nodejs-github-bot commented May 17, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66862/

@aduh95
aduh95force-pushed the backport-57289-to-22 branch from 3149aaf to bd43b7bCompareMay 17, 2025 15:24
@nodejs-github-bot

nodejs-github-bot commented May 17, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66869/

@nodejs-github-bot

nodejs-github-bot commented May 17, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66871/

@legendecas@aduh95
tools: extract target abseil to abseil.gyp
a23f57f
Both V8 and perfetto depends on abseil. When perfetto support is
enabled, V8 also depends on perfetto.
In order to share abseil between perfetto and V8 targets, and avoid
cycle dependencies between `v8.gyp` and `perfetto.gyp`, this extracts
target `abseil` from `v8.gyp` to an independent file `abseil.gyp`.
PR-URL: nodejs#57289
Backport-PR-URL: nodejs#57982
Refs: nodejs/diagnostics#654
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@legendecas@aduh95
src: disable abseil deadlock detection
6ea250e
Abseil deadlock detection is reporting false positives in tests.
Disable it for now.
PR-URL: nodejs#57582
Backport-PR-URL: nodejs#57982
Refs: nodejs/node-v8#301
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@aduh95
aduh95force-pushed the backport-57289-to-22 branch from bd43b7b to 6ea250eCompareMay 18, 2025 20:35
@nodejs-github-bot

nodejs-github-bot commented May 18, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66907/

@nodejs-github-bot

nodejs-github-bot commented May 18, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66912/

@aduh95
aduh95 merged commit 6ea250e into nodejs:v22.x-stagingMay 18, 2025
@aduh95

aduh95 commented May 18, 2025

Copy link
Copy Markdown
Contributor

Landed in cd4e09d...6ea250e

@legendecas
legendecas deleted the backport-57289-to-22 branch May 19, 2025 10:08
aduh95 pushed a commit that referenced this pull request May 19, 2025
@legendecas@aduh95
tools: extract target abseil to abseil.gyp
c56f495
Both V8 and perfetto depends on abseil. When perfetto support is
enabled, V8 also depends on perfetto.
In order to share abseil between perfetto and V8 targets, and avoid
cycle dependencies between `v8.gyp` and `perfetto.gyp`, this extracts
target `abseil` from `v8.gyp` to an independent file `abseil.gyp`.
PR-URL: #57289
Backport-PR-URL: #57982
Refs: nodejs/diagnostics#654
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95 pushed a commit that referenced this pull request May 19, 2025
@legendecas@aduh95
src: disable abseil deadlock detection
06179be
Abseil deadlock detection is reporting false positives in tests.
Disable it for now.
PR-URL: #57582
Backport-PR-URL: #57982
Refs: nodejs/node-v8#301
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
pld-gitsync pushed a commit to pld-linux/nodejs that referenced this pull request Jun 17, 2025
@jpalus
upstream fix to correct flags used for internal abseil
d380d6b
from: nodejs/node#58678fixes: nodejs/node#58569
regressed by: nodejs/node#57982
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.v22.xIssues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legendecas@nodejs-github-bot@aduh95@RafaelGSS