Skip to content

tools: include toolchain.gypi in abseil.gyp - #58678

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:v8-gyp-abseil
Jun 20, 2025
Merged

tools: include toolchain.gypi in abseil.gyp#58678
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:v8-gyp-abseil

Conversation

@legendecas

@legendecaslegendecas commented Jun 11, 2025•
edited
Loading

Copy link
Copy Markdown
Member

This sets proper SIMD build flags for abseil on ia32. Also moves include_dirs of V8_ROOT from toolchain.gyp to v8.gyp as it is mainly for V8 targets.

Fixes: #58569

@nodejs-github-bot

nodejs-github-bot commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Jun 11, 2025
@legendecas
legendecas marked this pull request as draft June 11, 2025 14:17
pld-gitsync pushed a commit to pld-linux/nodejs that referenced this pull request Jun 17, 2025
@jpalus
upstream fix to correct flags used for internal abseil
d380d6b
from: nodejs/node#58678fixes: nodejs/node#58569
regressed by: nodejs/node#57982
@legendecas

legendecas commented Jun 19, 2025

Copy link
Copy Markdown
MemberAuthor

I don't think we have CI coverage on the reported platforms in #58569 as they are not supported. This patch could still be a good addition as this sets up proper build flags.

@legendecas
legendecas marked this pull request as ready for review June 19, 2025 10:12
@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67526/

@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67531/

targos
targos reviewed Jun 19, 2025
View reviewed changes
Comment threadtools/v8_gypfiles/abseil.gyp Outdated
@legendecas
tools: include toolchain.gypi in abseil.gyp
733d872
This sets proper SIMD build flags for abseil on ia32.
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67533/

@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6619/

@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6619/

@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6619/

@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67541/

@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67546/

@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67550/

@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67557/

@legendecaslegendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 4623d46 into nodejs:mainJun 20, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 20, 2025

Copy link
Copy Markdown
Collaborator

Landed in 4623d46

@legendecas
legendecas deleted the v8-gyp-abseil branch June 20, 2025 09:33
RafaelGSS pushed a commit that referenced this pull request Jun 23, 2025
@legendecas@RafaelGSS
tools: include toolchain.gypi in abseil.gyp
b5ff3f4
This sets proper SIMD build flags for abseil on ia32.
PR-URL: #58678Fixes: #58569
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This was referenced Jun 23, 2025
Closed
Merged
@legendecaslegendecas added the lts-watch-v22.x PRs that may need to be released in v22.x label Jun 25, 2025
@legendecaslegendecas mentioned this pull request Jun 25, 2025
Closed
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@legendecas@aduh95
tools: include toolchain.gypi in abseil.gyp
0745d8e
This sets proper SIMD build flags for abseil on ia32.
PR-URL: #58678Fixes: #58569
Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@legendecas@aduh95
tools: include toolchain.gypi in abseil.gyp
cc8b9aa
This sets proper SIMD build flags for abseil on ia32.
PR-URL: #58678Fixes: #58569
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@aduh95aduh95 removed the lts-watch-v22.x PRs that may need to be released in v22.x label Jul 28, 2025
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

node 22.16.0 on OpenBSD: building a module with node-gyp spins in a tight loop

4 participants

@legendecas@nodejs-github-bot@targos@aduh95