Skip to content

test: fix URL v8 fast api tests - #58021

Closed
anonrig wants to merge 1 commit into
nodejs:mainfrom
anonrig:yagiz/fix-url-canparse-tests
Closed

test: fix URL v8 fast api tests#58021
anonrig wants to merge 1 commit into
nodejs:mainfrom
anonrig:yagiz/fix-url-canparse-tests

Conversation

@anonrig

Copy link
Copy Markdown
Member

Fixes v8 fast api tests in test-whatwg-url-canparse.js

@anonrig
anonrig requested review from jasnell and targosApril 25, 2025 14:19
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 25, 2025
@codecov

codecovBot commented Apr 25, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (9cc0195) to head (ef8da6e).
Report is 7 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58021 +/- ##
==========================================
- Coverage 90.28% 90.27% -0.01% 
==========================================
Files 630 630 Lines 186158 186158 Branches 36484 36475 -9 ==========================================
- Hits 168067 168051 -16 - Misses 10974 10988 +14 - Partials 7117 7119 +2 

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anonrig
anonrig requested review from aduh95 and lemireApril 25, 2025 18:17
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 25, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2025
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Comment on lines +23 to +24
// Only javascript methods can be optimized through %OptimizeFunctionOnNextCall
// This is why we surround the C++ method we want to optimize with a JS function.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is worthy to update the fast api docs to add this note, and maybe the exception when it's called with C++, just to be easy to find the docs when someone receive this error

@anonrig

Copy link
Copy Markdown
MemberAuthor

Closing in favor of #58023

@anonriganonrig closed this Apr 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@anonrig@nodejs-github-bot@jasnell@H4ad@aduh95