Uh oh!
There was an error while loading. Please reload this page.
doc: fix formatting of import.meta.filename section - #58079
Merged
Conversation
nodejs-github-bot
commented
Apr 29, 2025
Collaborator
Review requested:
|
jsumners-nr
approved these changes
Apr 29, 2025
And `import.meta.dirname`.
aduh95force-pushed
the
fix-filename-format
branch
from
April 29, 2025 21:52
1623a77 to
b3bdc4bCompareJakobJingleheimer
approved these changes
Apr 30, 2025
trivikr
approved these changes
Apr 30, 2025
Contributor
Fast-track has been requested by @mcollina. Please 👍 to approve. |
nodejs-github-bot
commented
May 1, 2025
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/58079 ✔ Done loading data for nodejs/node/pull/58079 ----------------------------------- PR info ------------------------------------ Title doc: fix formatting of `import.meta.filename` section (#58079) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:fix-filename-format -> nodejs:main Labels doc, esm, fast-track, author ready, dont-land-on-v20.x Commits 1 - doc: fix formatting of `import.meta.filename` section Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/58079 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58079 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 29 Apr 2025 15:57:36 GMT ✔ Approvals: 3 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/58079#pullrequestreview-2805909682 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/58079#pullrequestreview-2805929707 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/58079#pullrequestreview-2809661061 ℹ This PR is being fast-tracked ✘ This PR needs to wait 3 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14775013802 |
atlowChemi
approved these changes
May 1, 2025
legendecas
approved these changes
May 1, 2025
nodejs-github-bot
commented
May 1, 2025
Collaborator
Landed in 430027c |
RafaelGSS pushed a commit
that referenced
this pull request
May 2, 2025
And `import.meta.dirname`. PR-URL: #58079 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit
that referenced
this pull request
May 6, 2025
And `import.meta.dirname`. PR-URL: #58079 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit
that referenced
this pull request
May 6, 2025
And `import.meta.dirname`. PR-URL: #58079 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
May 14, 2025
And `import.meta.dirname`. PR-URL: #58079 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit
that referenced
this pull request
May 16, 2025
And `import.meta.dirname`. PR-URL: #58079 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit
that referenced
this pull request
May 17, 2025
And `import.meta.dirname`. PR-URL: #58079 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit
that referenced
this pull request
May 18, 2025
And `import.meta.dirname`. PR-URL: #58079 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit
that referenced
this pull request
May 19, 2025
And `import.meta.dirname`. PR-URL: #58079 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.