Skip to content

[v22.x backport] worker: make Worker async disposable - #58455

Merged
aduh95 merged 2 commits into
nodejs:v22.x-stagingfrom
jasnell:jasnell/backport-worker-dispose
Jul 28, 2025
Merged

[v22.x backport] worker: make Worker async disposable#58455
aduh95 merged 2 commits into
nodejs:v22.x-stagingfrom
jasnell:jasnell/backport-worker-dispose

Conversation

@jasnell

@jasnelljasnell commented May 26, 2025

Copy link
Copy Markdown
Member

Backport of #58385

@jasnell
jasnell requested a review from aduh95May 26, 2025 01:04
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. worker Issues and PRs related to Worker support. labels May 26, 2025
@jasnelljasnell changed the title worker: make Worker async disposable[Backport] worker: make Worker async disposableMay 26, 2025
@jasnelljasnell mentioned this pull request May 26, 2025
Closed
@juanarbol

juanarbol commented May 26, 2025

Copy link
Copy Markdown
Member

Maybe it is quite irrelevant, but this backport diverges a bit from the original PR (one extra commit) and each commit is missing its metadata (trailing, same as the original PR).

@jasnell

jasnell commented May 26, 2025

Copy link
Copy Markdown
MemberAuthor

This was a manual commit put together before the other one landed. Will update it with the metadata later.

@jasnell
jasnellforce-pushed the jasnell/backport-worker-dispose branch from 23474ab to a8ffbcdCompareMay 26, 2025 01:19
juanarbol
juanarbol approved these changes May 26, 2025
View reviewed changes

@juanarboljuanarbol left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a manual commit put together before the other one landed. Will update it with the metadata later.

Oh, I see. Although, all commits needs its trailers. I think a rebase and a ncu command for each patch will fix it. I'm approving considering that you'll add the git trailers for each commit as it should be.

@jasnell

jasnell commented May 26, 2025

Copy link
Copy Markdown
MemberAuthor

i'm not planning on back porting both of the original commits since one is only relevant for 24.x. This one commit combines the base change along the 22.x version of the test that landed in the original.

@aduh95aduh95 changed the title [Backport] worker: make Worker async disposable[v22.x backport] worker: make Worker async disposableMay 26, 2025
aduh95
aduh95 reviewed Jun 10, 2025
View reviewed changes
Comment threaddoc/api/worker_threads.md Outdated
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67390/

@nodejs-github-bot

nodejs-github-bot commented Jun 15, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67462/

@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 21, 2025
@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68065/

@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68089/

@nodejs-github-bot

nodejs-github-bot commented Jul 22, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68123/

@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68175/

@nodejs-github-bot

nodejs-github-bot commented Jul 24, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68181/

@nodejs-github-bot

nodejs-github-bot commented Jul 27, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68245/

@nodejs-github-bot

nodejs-github-bot commented Jul 27, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68249/

@nodejs-github-bot

nodejs-github-bot commented Jul 28, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68258/

@nodejs-github-bot

nodejs-github-bot commented Jul 28, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68263/

@jasnell@aduh95
worker: make Worker async disposable
8dbc6b2
PR-URL: nodejs#58385
Backport-PR-URL: nodejs#58455
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@jasnell@aduh95
test: add test for async disposable worker thread
66fccc2
PR-URL: nodejs#58385
Backport-PR-URL: nodejs#58455
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@aduh95
aduh95force-pushed the jasnell/backport-worker-dispose branch from 514262c to 66fccc2CompareJuly 28, 2025 09:08
@aduh95

aduh95 commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

Landed in 6905258...66fccc2

@aduh95
aduh95 merged commit 66fccc2 into nodejs:v22.x-stagingJul 28, 2025
19 of 20 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes
@Ethan-ArrowoodEthan-ArrowoodEthan-Arrowood approved these changes
@juanarboljuanarboljuanarbol approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.v22.xIssues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jasnell@juanarbol@nodejs-github-bot@aduh95@Ethan-Arrowood