Skip to content

test: add known issue tests for fs.cp - #58883

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
jasnell:jasnell/fs-cp-known-issues
Jul 1, 2025
Merged

test: add known issue tests for fs.cp#58883
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
jasnell:jasnell/fs-cp-known-issues

Conversation

@jasnell

@jasnelljasnell commented Jun 29, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Refs: #58634
Refs: #58869

@nodejs/fs

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 29, 2025
jasnell
jasnell commented Jun 29, 2025
View reviewed changes
Comment threadtest/known_issues/test-fs-cp-async-buffer.js
jasnell
jasnell commented Jun 29, 2025
View reviewed changes
Comment threadtest/known_issues/test-fs-cp-filter.js
jasnell
jasnell commented Jun 29, 2025
View reviewed changes
Comment threadtest/known_issues/test-fs-cp-non-utf8.js
@nodejs-github-bot

nodejs-github-bot commented Jun 29, 2025•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67713/ 💛

@jasnelljasnell added the fs Issues and PRs related to the fs subsystem / file system. label Jun 29, 2025
@codecov

codecovBot commented Jun 29, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (4d5ee24) to head (3339b0c).
Report is 15 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58883 +/- ##
==========================================
- Coverage 90.10% 90.09% -0.02% 
==========================================
Files 640 640 Lines 188493 188493 Branches 36971 36972 +1 ==========================================
- Hits 169843 169820 -23 - Misses 11358 11401 +43 + Partials 7292 7272 -20

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dario-piotrowicz
dario-piotrowicz approved these changes Jun 29, 2025
View reviewed changes

@dario-piotrowiczdario-piotrowicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

Shall we create some tests for readdir as well? (#58634 (comment))

If you prefer I can also do that as a followup (should I actually create a dedicated GitHub issue for readdir? 🤔)

@jasnell

jasnell commented Jun 29, 2025

Copy link
Copy Markdown
MemberAuthor

Yeah, an issue and set of known issue tests would be good

@jasnelljasnell added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 29, 2025
@dario-piotrowicz

dario-piotrowicz commented Jun 29, 2025

Copy link
Copy Markdown
Member

Yeah, an issue and set of known issue tests would be good

Done 🙂👍

#58892
#58893

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 1, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 2022f83 into nodejs:mainJul 1, 2025
68 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 1, 2025

Copy link
Copy Markdown
Collaborator

Landed in 2022f83

targos pushed a commit that referenced this pull request Jul 3, 2025
@jasnell@targos
test: add known issue tests for fs.cp
c300f10
PR-URL: #58883
Refs: #58634
Refs: #58869
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnelljasnell mentioned this pull request Jul 3, 2025
Open
@jasnelljasnell linked an issue Jul 3, 2025 that may be closed by this pull request
fsPromises.cp(...) inconsistencies and bugs #58869
Open
@jasnelljasnell removed a link to an issue Jul 3, 2025
fsPromises.cp(...) inconsistencies and bugs #58869
Open
@github-actionsgithub-actionsBot mentioned this pull request Jul 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@jasnell@aduh95
test: add known issue tests for fs.cp
d8c8f04
PR-URL: #58883
Refs: #58634
Refs: #58869
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@jasnell@aduh95
test: add known issue tests for fs.cp
cd2a5d9
PR-URL: #58883
Refs: #58634
Refs: #58869
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@jazellyjazellyjazelly approved these changes
@dario-piotrowiczdario-piotrowiczdario-piotrowicz approved these changes
@LiviaMedeirosLiviaMedeirosLiviaMedeiros approved these changes
@anonriganonrigAwaiting requested review from anonrig
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.fsIssues and PRs related to the fs subsystem / file system.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jasnell@nodejs-github-bot@dario-piotrowicz@lpinca@jazelly@VoltrexKeyva@LiviaMedeiros