Skip to content

test: add known issue tests for recursive readdir calls with Buffer path - #58893

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/known-issues-58892-readdir-buffer
Jul 1, 2025
Merged

test: add known issue tests for recursive readdir calls with Buffer path#58893
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
dario-piotrowicz:dario/known-issues-58892-readdir-buffer

Conversation

@dario-piotrowicz

@dario-piotrowiczdario-piotrowicz commented Jun 29, 2025

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 29, 2025
@dario-piotrowiczdario-piotrowicz mentioned this pull request Jun 29, 2025
Merged
@dario-piotrowiczdario-piotrowicz added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 29, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 29, 2025
@nodejs-github-bot

nodejs-github-bot commented Jun 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67735/

@codecov

codecovBot commented Jun 29, 2025•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (f6a4305) to head (e457502).
Report is 13 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #58893 +/- ##
==========================================
- Coverage 90.10% 90.08% -0.03% 
==========================================
Files 640 640 Lines 188431 188425 -6 Branches 36957 36968 +11 ==========================================
- Hits 169786 169737 -49 - Misses 11358 11394 +36 - Partials 7287 7294 +7

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dario-piotrowiczdario-piotrowicz added request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 30, 2025
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 1, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 8d11399 into nodejs:mainJul 1, 2025
77 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jul 1, 2025

Copy link
Copy Markdown
Collaborator

Landed in 8d11399

@dario-piotrowicz
dario-piotrowicz deleted the dario/known-issues-58892-readdir-buffer branch July 2, 2025 00:19
targos pushed a commit that referenced this pull request Jul 3, 2025
@dario-piotrowicz@targos
test: add known issue tests for recursive readdir calls with Buffer path
b6ff6c8
PR-URL: #58893
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 8, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
@dario-piotrowicz@aduh95
test: add known issue tests for recursive readdir calls with Buffer path
4177131
PR-URL: #58893
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
@dario-piotrowicz@aduh95
test: add known issue tests for recursive readdir calls with Buffer path
7c54085
PR-URL: #58893
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@jakecastellijakecastellijakecastelli approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dario-piotrowicz@nodejs-github-bot@jasnell@lpinca@jakecastelli