Uh oh!
There was an error while loading. Please reload this page.
Make test-worker-message-port-infinite-message-loop.js fail when the port1.on('message' callback isn't called - #59885
Merged
Conversation
Add assertion to verify that the MessagePort's message event is actually emitted in test-worker-message-port-infinite-message-loop.js. Previously, the test could pass even if the event was not fired.
port1.on('message' callback isn't calledtest-worker-message-port-infinite-message-loop.js fail when the port1.on('message' callback isn't calledCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #59885 +/- ##
==========================================
- Coverage 88.29% 88.27% -0.02%
==========================================
Files 702 702 Lines 206875 206875 Branches 39806 39802 -4 ==========================================
- Hits 182667 182627 -40 - Misses 16218 16267 +49 + Partials 7990 7981 -9 🚀 New features to boost your workflow:
|
anonrig
approved these changes
Sep 14, 2025
nodejs-github-bot
commented
Sep 14, 2025
Collaborator
jasnell
reviewed
Sep 15, 2025
| common.mustCall(() => { | ||
| assert(count > 0, 'count should be greater than 0'); | ||
| }) | ||
| ); |
Member
There was a problem hiding this comment.
I think the more correct way to do this would be to wrap the callback to the port1.on in a common.mustCallAtLeast(...)?
addaleax
approved these changes
Oct 1, 2025
addaleax
left a comment
Member
There was a problem hiding this comment.
Just going to go ahead with this since it's strictly an improvement
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
Oct 1, 2025
Collaborator
Landed in 9790315 |
targos pushed a commit
that referenced
this pull request
Oct 6, 2025
Add assertion to verify that the MessagePort's message event is actually emitted in test-worker-message-port-infinite-message-loop.js. Previously, the test could pass even if the event was not fired. PR-URL: #59885 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
test-worker-message-port-infinite-message-loop.jscurrently passes if the MessagePort does not emit any messages.If the message port does not emit a
"message"event then the infinite message loop would never occur, therefore it's probably not the intent of the test.Context: this test was incorrectly passing in Bun when we currently do not start the MessagePort until the
startmethod is called. This test continues to pass in Node and now correctly fails in Bun (we will fix this later).