test: ensure that the message event is fired by lpinca · Pull Request #59952 · nodejs/node

lpinca · 2025-09-20T19:10:37Z

Use common.mustCallAtLeast() to verify that the 'message' event is fired.

lpinca · 2025-09-20T19:10:54Z

Alternative to #59885.

codecov · 2025-09-20T20:04:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.45%. Comparing base (6f941fc) to head (097b5ed).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #59952 +/- ##
==========================================
- Coverage 88.45% 88.45% -0.01% 
==========================================
Files 703 703 Lines 207826 207826 Branches 40030 40036 +6 ==========================================
- Hits 183842 183826 -16 - Misses 15973 15974 +1 - Partials 8011 8026 +15

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-09-23T18:42:36Z

Failed to start CI

 ⚠ Commits were pushed since the last approving review:
⚠ - test: ensure that the message event is fired
⚠ - Update test/parallel/test-worker-message-port-infinite-message-loop.js
✘ Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/17955820654

gurgunday

lgtm

Use `common.mustCallAtLeast()` to verify that the `'message'` event is fired.

lpinca · 2025-10-04T10:15:48Z

Rebased, this needs new approvals.

nodejs-github-bot · 2025-10-04T18:35:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/69561/

lpinca · 2025-10-05T16:06:48Z

It seems that #59885 was merged. I'll open a new PR to revert it.

This reverts commit 9790315. Refs: nodejs#59952

nodejs-github-bot · 2025-10-05T16:09:58Z

Landed in 307eaca

Use `common.mustCallAtLeast()` to verify that the `'message'` event is fired. PR-URL: #59952 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

This reverts commit 9790315. Refs: #59952 PR-URL: #60126 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Use `common.mustCallAtLeast()` to verify that the `'message'` event is fired. PR-URL: #59952 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

This reverts commit 9790315. Refs: #59952 PR-URL: #60126 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 20, 2025

aduh95 approved these changes Sep 23, 2025
View reviewed changes

Comment threadtest/parallel/test-worker-message-port-infinite-message-loop.js Outdated

jakecastelli approved these changes Sep 23, 2025
View reviewed changes

lpinca added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 23, 2025

github-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 23, 2025

aduh95 approved these changes Sep 23, 2025
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2025

This comment was marked as outdated.
Sign in to view

gurgunday approved these changes Oct 3, 2025
View reviewed changes

This comment was marked as outdated.
Sign in to view

test: ensure that the message event is fired
097b5ed
Use `common.mustCallAtLeast()` to verify that the `'message'` event is fired.

lpinca force-pushed the fix/test-worker-message-port-infinite-message-loop branch from d4d9c67 to 097b5edCompare October 4, 2025 10:15

This comment was marked as outdated.
Sign in to view

jakecastelli approved these changes Oct 5, 2025
View reviewed changes

lpinca added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 5, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2025

lpinca added a commit to lpinca/node that referenced this pull request Oct 5, 2025
Revert "test: ensure message event fires in worker message port test"
d10b98b
This reverts commit 9790315. Refs: nodejs#59952

lpinca mentioned this pull request Oct 5, 2025
Revert "test: ensure message event fires in worker message port test" #60126
Merged

nodejs-github-bot merged commit 307eaca into nodejs:mainOct 5, 2025
56 checks passed

lpinca deleted the fix/test-worker-message-port-infinite-message-loop branch October 5, 2025 16:10

github-actionsBot mentioned this pull request Oct 7, 2025
2025-10-08, Version 24.10.0 (Current) #60136
Merged

nodejs-github-bot pushed a commit that referenced this pull request Oct 13, 2025
Revert "test: ensure message event fires in worker message port test"
985e2fb
This reverts commit 9790315. Refs: #59952 PR-URL: #60126 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

github-actionsBot mentioned this pull request Oct 23, 2025
2025-10-28, Version 22.21.1 'Jod' (LTS) #60375
Merged

aduh95 pushed a commit that referenced this pull request Oct 31, 2025
Revert "test: ensure message event fires in worker message port test"
bc3ed49
This reverts commit 9790315. Refs: #59952 PR-URL: #60126 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 pushed a commit that referenced this pull request Nov 7, 2025
Revert "test: ensure message event fires in worker message port test"
635af55
This reverts commit 9790315. Refs: #59952 PR-URL: #60126 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Uh oh!

Uh oh!

Conversation

lpinca commented Sep 20, 2025

Uh oh!

lpinca commented Sep 20, 2025

Uh oh!

codecovBot commented Sep 20, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actionsBot commented Sep 23, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

lpinca commented Oct 4, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Oct 4, 2025

Uh oh!

lpinca commented Oct 5, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecovBot commented Sep 20, 2025•
edited
Loading

lpinca commented Oct 5, 2025•
edited
Loading