Skip to content

[v22.x-backport] lib: make domexception a native error - #59957

Closed
Renegade334 wants to merge 3 commits into
nodejs:v22.x-stagingfrom
Renegade334:v22.x-native-domexception
Closed

[v22.x-backport] lib: make domexception a native error#59957
Renegade334 wants to merge 3 commits into
nodejs:v22.x-stagingfrom
Renegade334:v22.x-native-domexception

Conversation

@Renegade334

@Renegade334Renegade334 commented Sep 21, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Backports c1c3673 to unblock the DOMException changes. Resolves#59852.

legendecasand others added 2 commits September 21, 2025 05:03
@legendecas@Renegade334
deps: V8: cherry-pick e3df60f3f5ab
2ec88e0
Original commit message:
[objects] allow host defined serializer of JSError
Allow host defined serializer and deserializer of JSError in
ValueSerializer API. This allows hosts that implement DOMException
in JS to support `Error.isError` proposal and `structuredClone`.
Refs: nodejs#58691
Change-Id: I022821c9abd659970c4d449b3c69c5fb54d0618a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6637876
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Chengzhong Wu <cwu631@bloomberg.net>
Cr-Commit-Position: refs/heads/main@{#100894}
Refs: v8/v8@e3df60f
PR-URL: nodejs#58691
Backport-PR-URL: nodejs#59957Fixes: nodejs#56497
Refs: nodejs#58138
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
@legendecas@petamoriken@Renegade334
lib: make domexception a native error
f8d1357
Co-Authored-By: Kenta Moriuchi <moriken@kimamass.com>
PR-URL: nodejs#58691
Backport-PR-URL: nodejs#59957Fixes: nodejs#56497
Refs: v8/v8@e3df60f
Refs: nodejs#58138
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Sep 21, 2025
@Renegade334Renegade334 changed the title V22.x native domexception[v22.x-backport] lib: make domexception a native errorSep 21, 2025
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2025
@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69309/

@legendecas

legendecas commented Sep 21, 2025

Copy link
Copy Markdown
Member

Would you mind cherry picking #59680 as well? Thanks!

@legendecaslegendecas mentioned this pull request Sep 21, 2025
Closed
@legendecas@Renegade334
lib: fix DOMException subclass support
d04e251
PR-URL: nodejs#59680
Backport-PR-URL: nodejs#59957
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2025
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2025
@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69312/

@nodejs-github-bot

nodejs-github-bot commented Sep 22, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69317/

@nodejs-github-bot

nodejs-github-bot commented Sep 22, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6768/

@nodejs-github-bot

nodejs-github-bot commented Sep 22, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6768/

@nodejs-github-bot

nodejs-github-bot commented Sep 22, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6768/

richardlau pushed a commit that referenced this pull request Sep 22, 2025
@legendecas@richardlau
deps: V8: cherry-pick e3df60f3f5ab
d289b1d
Original commit message:
[objects] allow host defined serializer of JSError
Allow host defined serializer and deserializer of JSError in
ValueSerializer API. This allows hosts that implement DOMException
in JS to support `Error.isError` proposal and `structuredClone`.
Refs: #58691
Change-Id: I022821c9abd659970c4d449b3c69c5fb54d0618a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6637876
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Chengzhong Wu <cwu631@bloomberg.net>
Cr-Commit-Position: refs/heads/main@{#100894}
Refs: v8/v8@e3df60f
PR-URL: #58691
Backport-PR-URL: #59957Fixes: #56497
Refs: #58138
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Sep 22, 2025
@legendecas@petamoriken@richardlau
lib: make domexception a native error
edb9248
Co-Authored-By: Kenta Moriuchi <moriken@kimamass.com>
PR-URL: #58691
Backport-PR-URL: #59957Fixes: #56497
Refs: v8/v8@e3df60f
Refs: #58138
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Sep 22, 2025
@legendecas@richardlau
lib: fix DOMException subclass support
a232989
PR-URL: #59680
Backport-PR-URL: #59957
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
@richardlau

richardlau commented Sep 22, 2025

Copy link
Copy Markdown
Member

Landed in da6e8cb...a232989.

@Renegade334
Renegade334 deleted the v22.x-native-domexception branch September 22, 2025 15:00
@legendecaslegendecas mentioned this pull request Sep 23, 2025
Closed
codebytere added a commit to electron/electron that referenced this pull request Oct 13, 2025
@codebytere
[v22.x-backport] lib: make domexception a native error
5475e14
nodejs/node#59957
codebytere added a commit to electron/electron that referenced this pull request Oct 14, 2025
@electron-roller@codebytere
chore: bump node to v22.20.0 (37-x-y) (#48380)
dfc60f0
* chore: bump node in DEPS to v22.20.0
* chore: fixup patch indices
* [v22.x-backport] lib: make domexception a native error
nodejs/node#59957
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau approved these changes
@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.v22.xIssues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Renegade334@nodejs-github-bot@legendecas@richardlau