Skip to content

inspector: fix compressed responses - #62630

Open
legendecas wants to merge 2 commits into
nodejs:mainfrom
legendecas:fix/inspector-compressed-responses
Open

inspector: fix compressed responses#62630
legendecas wants to merge 2 commits into
nodejs:mainfrom
legendecas:fix/inspector-compressed-responses

Conversation

@legendecas

Copy link
Copy Markdown
Member

This relands #61226 with a fix on racing in http2 inspector when there is a decompressor.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/inspector

@nodejs-github-botnodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Apr 8, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@codecov

codecovBot commented Apr 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.88268% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.80%. Comparing base (41afe9b) to head (9f54777).
⚠️ Report is 1108 commits behind head on main.

Files with missing linesPatch %Lines
lib/internal/inspector/network_http.js98.48%1 Missing ⚠️
lib/internal/inspector/network_http2.js98.79%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #62630 +/- ##
==========================================
+ Coverage 89.79% 89.80% +0.01% 
==========================================
Files 699 699 Lines 216163 216304 +141 Branches 41327 41343 +16 ==========================================
+ Hits 194110 194260 +150 + Misses 14173 14142 -31 - Partials 7880 7902 +22 
Files with missing linesCoverage Δ
lib/internal/inspector/network.js96.89% <100.00%> (+0.93%)⬆️
lib/internal/inspector/network_http.js95.93% <98.48%> (+0.66%)⬆️
lib/internal/inspector/network_http2.js89.78% <98.79%> (+2.04%)⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment threadtest/parallel/test-inspector-network-http-compressed.js Outdated
rubnogueiraand others added 2 commits April 9, 2026 14:45
PR-URL: nodejs#61226Fixes: nodejs#61222
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@legendecas
legendecasforce-pushed the fix/inspector-compressed-responses branch from 00a8580 to 9f54777CompareApril 9, 2026 18:45
@legendecas

legendecas commented Apr 9, 2026

Copy link
Copy Markdown
MemberAuthor

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http2Issues or PRs related to the http2 subsystem.inspectorIssues and PRs related to the V8 inspector protocolneeds-ciPRs that need a full CI run.stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@legendecas@nodejs-github-bot@aduh95@rubnogueira