Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/api/quic.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3990,8 +3990,9 @@ A few things to note:
the request is `HEADERS` followed by `END_STREAM`.
* The `onheaders` callback receives the response pseudo-headers and
regular headers in a single object with lowercase string keys.
After the callback returns, the same object is also accessible
via [`stream.headers`][].
For incoming headers, the `:status` pseudo-header is converted to
a `number`, matching HTTP/2 behavior. After the callback returns,
the same object is also accessible via [`stream.headers`][].
* Reading `for await (const chunks of stream)` consumes the response
body. Each iteration yields a `Uint8Array[]` batch of chunks.
* HTTP semantic helpers (URL parsing, method/status validation,
Expand Down
15 changes: 10 additions & 5 deletions lib/internal/quic/quic.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
assert(pairs.length % 2 === 0);
const block = { __proto__: null };
for (let n = 0; n + 1 < pairs.length; n += 2) {
if (block[pairs[n]] !== undefined) {
if (ArrayIsArray(block[pairs[n]])) {
ArrayPrototypePush(block[pairs[n]], pairs[n + 1]);
const name = pairs[n];
let value = pairs[n + 1];
// Match HTTP/2 behavior: incoming :status is exposed as a number.
if (name === ':status')
value |= 0;
if (block[name] !== undefined) {
if (ArrayIsArray(block[name])) {
ArrayPrototypePush(block[name], value);
} else {
block[pairs[n]] = [block[pairs[n]], pairs[n + 1]];
block[name] = [block[name], value];
}
} else {
block[pairs[n]] = pairs[n + 1];
block[name] = value;
}
}
return block;
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-callback-errors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
ontrailers: mustCall(function() {
throw new Error('ontrailers sync error');
Expand DownExpand Up@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-close-behavior.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-concurrent-requests.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
headersReceived.resolve();
}),
});
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-datagram.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-error-codes.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-goaway.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
await clientSession.opened;

const onClientHeaders = mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
if (++clientHeaderCount === 2) {
bothHeadersReceived.resolve();
}
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-header-validation.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
},
onheaders: mustCall(function(headers) {
// Client should also receive lowercased response header names.
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/html');
assert.strictEqual(headers['x-response-header'], 'ResponseValue');

Expand DownExpand Up@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '204');
assert.strictEqual(headers[':status'], 204);
}),
});

Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-quic-h3-informational-headers.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
assert.ok(msg.stream, 'stream.info should include stream');
assert.ok(msg.session, 'stream.info should include session');
assert.ok(msg.headers, 'stream.info should include headers');
assert.strictEqual(msg.headers[':status'], '103');
assert.strictEqual(msg.headers[':status'], 103);
}));

// quic.stream.headers also fires for the final response headers.
Expand DownExpand Up@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
oninfo: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '103');
assert.strictEqual(headers[':status'], 103);
assert.strictEqual(headers.link, '</style.css>; rel=preload; as=style');
clientInfoReceived.resolve();
}),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -107,7 +107,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the final (initial) headers, not 1xx.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-origin.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ const decoder = new TextDecoder();
':authority': 'example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -173,7 +173,7 @@ const decoder = new TextDecoder();
':authority': 'custom-port.example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-pending-stream.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-filehandle.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -76,7 +76,7 @@ writeFileSync(testFile, testContent);
},
body: fh,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-request.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ const stream = await clientSession.createBidirectionalStream({
},
body: encoder.encode(requestBody),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
10 changes: 5 additions & 5 deletions test/parallel/test-quic-h3-priority.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -67,7 +67,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: false,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -85,7 +85,7 @@ const decoder = new TextDecoder();
priority: 'low',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream2.priority, { level: 'low', incremental: true });
Expand All@@ -99,7 +99,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream3.priority, { level: 'default', incremental: false });
Expand All@@ -113,7 +113,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
// Default priority initially.
Expand DownExpand Up@@ -215,7 +215,7 @@ const decoder = new TextDecoder();
},
body: encoder.encode('signal'),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream.priority, { level: 'default', incremental: false });
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-qpack-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function makeRequest(clientSession, path) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
const body = await bytes(stream);
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-request-response.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,7 +93,7 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -106,7 +106,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the buffered response headers.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-quic-h3-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,7 @@ const decoder = new TextDecoder();
'x-second': 'two',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -129,7 +129,7 @@ const decoder = new TextDecoder();
'x-long': longValue,
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -185,7 +185,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
64 changes: 64 additions & 0 deletions test/parallel/test-quic-h3-status-code-type.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
// Flags: --experimental-quic --experimental-stream-iter --no-warnings

// Verify incoming :status is exposed as a number, matching HTTP/2 behavior.
// See https://github.com/nodejs/node/issues/63557

import { hasQuic, skip, mustCall } from '../common/index.mjs';
import assert from 'node:assert';
import * as fixtures from '../common/fixtures.mjs';

if (!hasQuic) {
skip('QUIC is not enabled');
}

const { listen, connect } = await import('node:quic');
const { createPrivateKey } = await import('node:crypto');

const key = createPrivateKey(fixtures.readKey('agent1-key.pem'));
const cert = fixtures.readKey('agent1-cert.pem');

const codes = [200, 204, 404];
let serverResponses = 0;
const serverDone = Promise.withResolvers();

const serverEndpoint = await listen(mustCall(async (ss) => {
ss.onstream = mustCall(() => {
if (++serverResponses === codes.length) {
ss.close();
serverDone.resolve();
}
}, codes.length);
}), {
sni: { '*': { keys: [key], certs: [cert] } },
onheaders: mustCall(function() {
const status = codes[serverResponses - 1];
this.sendHeaders({ ':status': String(status) }, { terminal: true });
this.writer.endSync();
}, codes.length),
});

const clientSession = await connect(serverEndpoint.address, {
servername: 'localhost',
verifyPeer: 'manual',
});
await clientSession.opened;

for (const expected of codes) {
const stream = await clientSession.createBidirectionalStream({
headers: {
':method': 'GET',
':path': '/',
':scheme': 'https',
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(typeof headers[':status'], 'number');
assert.strictEqual(headers[':status'], expected);
}),
});
await stream.closed;
}

await serverDone.promise;
await clientSession.close();
await serverEndpoint.close();
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/api/quic.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3990,8 +3990,9 @@ A few things to note:
the request is `HEADERS` followed by `END_STREAM`.
* The `onheaders` callback receives the response pseudo-headers and
regular headers in a single object with lowercase string keys.
After the callback returns, the same object is also accessible
via [`stream.headers`][].
For incoming headers, the `:status` pseudo-header is converted to
a `number`, matching HTTP/2 behavior. After the callback returns,
the same object is also accessible via [`stream.headers`][].
* Reading `for await (const chunks of stream)` consumes the response
body. Each iteration yields a `Uint8Array[]` batch of chunks.
* HTTP semantic helpers (URL parsing, method/status validation,
Expand Down
15 changes: 10 additions & 5 deletions lib/internal/quic/quic.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
assert(pairs.length % 2 === 0);
const block = { __proto__: null };
for (let n = 0; n + 1 < pairs.length; n += 2) {
if (block[pairs[n]] !== undefined) {
if (ArrayIsArray(block[pairs[n]])) {
ArrayPrototypePush(block[pairs[n]], pairs[n + 1]);
const name = pairs[n];
let value = pairs[n + 1];
// Match HTTP/2 behavior: incoming :status is exposed as a number.
if (name === ':status')
value |= 0;
if (block[name] !== undefined) {
if (ArrayIsArray(block[name])) {
ArrayPrototypePush(block[name], value);
} else {
block[pairs[n]] = [block[pairs[n]], pairs[n + 1]];
block[name] = [block[name], value];
}
} else {
block[pairs[n]] = pairs[n + 1];
block[name] = value;
}
}
return block;
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-callback-errors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
ontrailers: mustCall(function() {
throw new Error('ontrailers sync error');
Expand DownExpand Up@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-close-behavior.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-concurrent-requests.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
headersReceived.resolve();
}),
});
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-datagram.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-error-codes.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-goaway.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
await clientSession.opened;

const onClientHeaders = mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
if (++clientHeaderCount === 2) {
bothHeadersReceived.resolve();
}
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-header-validation.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
},
onheaders: mustCall(function(headers) {
// Client should also receive lowercased response header names.
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/html');
assert.strictEqual(headers['x-response-header'], 'ResponseValue');

Expand DownExpand Up@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '204');
assert.strictEqual(headers[':status'], 204);
}),
});

Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-quic-h3-informational-headers.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
assert.ok(msg.stream, 'stream.info should include stream');
assert.ok(msg.session, 'stream.info should include session');
assert.ok(msg.headers, 'stream.info should include headers');
assert.strictEqual(msg.headers[':status'], '103');
assert.strictEqual(msg.headers[':status'], 103);
}));

// quic.stream.headers also fires for the final response headers.
Expand DownExpand Up@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
oninfo: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '103');
assert.strictEqual(headers[':status'], 103);
assert.strictEqual(headers.link, '</style.css>; rel=preload; as=style');
clientInfoReceived.resolve();
}),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -107,7 +107,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the final (initial) headers, not 1xx.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-origin.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ const decoder = new TextDecoder();
':authority': 'example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -173,7 +173,7 @@ const decoder = new TextDecoder();
':authority': 'custom-port.example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-pending-stream.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-filehandle.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -76,7 +76,7 @@ writeFileSync(testFile, testContent);
},
body: fh,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-request.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ const stream = await clientSession.createBidirectionalStream({
},
body: encoder.encode(requestBody),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
10 changes: 5 additions & 5 deletions test/parallel/test-quic-h3-priority.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -67,7 +67,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: false,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -85,7 +85,7 @@ const decoder = new TextDecoder();
priority: 'low',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream2.priority, { level: 'low', incremental: true });
Expand All@@ -99,7 +99,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream3.priority, { level: 'default', incremental: false });
Expand All@@ -113,7 +113,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
// Default priority initially.
Expand DownExpand Up@@ -215,7 +215,7 @@ const decoder = new TextDecoder();
},
body: encoder.encode('signal'),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream.priority, { level: 'default', incremental: false });
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-qpack-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function makeRequest(clientSession, path) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
const body = await bytes(stream);
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-request-response.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,7 +93,7 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -106,7 +106,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the buffered response headers.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-quic-h3-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,7 @@ const decoder = new TextDecoder();
'x-second': 'two',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -129,7 +129,7 @@ const decoder = new TextDecoder();
'x-long': longValue,
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -185,7 +185,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
64 changes: 64 additions & 0 deletions test/parallel/test-quic-h3-status-code-type.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
// Flags: --experimental-quic --experimental-stream-iter --no-warnings

// Verify incoming :status is exposed as a number, matching HTTP/2 behavior.
// See https://github.com/nodejs/node/issues/63557

import { hasQuic, skip, mustCall } from '../common/index.mjs';
import assert from 'node:assert';
import * as fixtures from '../common/fixtures.mjs';

if (!hasQuic) {
skip('QUIC is not enabled');
}

const { listen, connect } = await import('node:quic');
const { createPrivateKey } = await import('node:crypto');

const key = createPrivateKey(fixtures.readKey('agent1-key.pem'));
const cert = fixtures.readKey('agent1-cert.pem');

const codes = [200, 204, 404];
let serverResponses = 0;
const serverDone = Promise.withResolvers();

const serverEndpoint = await listen(mustCall(async (ss) => {
ss.onstream = mustCall(() => {
if (++serverResponses === codes.length) {
ss.close();
serverDone.resolve();
}
}, codes.length);
}), {
sni: { '*': { keys: [key], certs: [cert] } },
onheaders: mustCall(function() {
const status = codes[serverResponses - 1];
this.sendHeaders({ ':status': String(status) }, { terminal: true });
this.writer.endSync();
}, codes.length),
});

const clientSession = await connect(serverEndpoint.address, {
servername: 'localhost',
verifyPeer: 'manual',
});
await clientSession.opened;

for (const expected of codes) {
const stream = await clientSession.createBidirectionalStream({
headers: {
':method': 'GET',
':path': '/',
':scheme': 'https',
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(typeof headers[':status'], 'number');
assert.strictEqual(headers[':status'], expected);
}),
});
await stream.closed;
}

await serverDone.promise;
await clientSession.close();
await serverEndpoint.close();
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/api/quic.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3990,8 +3990,9 @@ A few things to note:
the request is `HEADERS` followed by `END_STREAM`.
* The `onheaders` callback receives the response pseudo-headers and
regular headers in a single object with lowercase string keys.
After the callback returns, the same object is also accessible
via [`stream.headers`][].
For incoming headers, the `:status` pseudo-header is converted to
a `number`, matching HTTP/2 behavior. After the callback returns,
the same object is also accessible via [`stream.headers`][].
* Reading `for await (const chunks of stream)` consumes the response
body. Each iteration yields a `Uint8Array[]` batch of chunks.
* HTTP semantic helpers (URL parsing, method/status validation,
Expand Down
15 changes: 10 additions & 5 deletions lib/internal/quic/quic.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
assert(pairs.length % 2 === 0);
const block = { __proto__: null };
for (let n = 0; n + 1 < pairs.length; n += 2) {
if (block[pairs[n]] !== undefined) {
if (ArrayIsArray(block[pairs[n]])) {
ArrayPrototypePush(block[pairs[n]], pairs[n + 1]);
const name = pairs[n];
let value = pairs[n + 1];
// Match HTTP/2 behavior: incoming :status is exposed as a number.
if (name === ':status')
value |= 0;
if (block[name] !== undefined) {
if (ArrayIsArray(block[name])) {
ArrayPrototypePush(block[name], value);
} else {
block[pairs[n]] = [block[pairs[n]], pairs[n + 1]];
block[name] = [block[name], value];
}
} else {
block[pairs[n]] = pairs[n + 1];
block[name] = value;
}
}
return block;
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-callback-errors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
ontrailers: mustCall(function() {
throw new Error('ontrailers sync error');
Expand DownExpand Up@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-close-behavior.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-concurrent-requests.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
headersReceived.resolve();
}),
});
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-datagram.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-error-codes.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-goaway.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
await clientSession.opened;

const onClientHeaders = mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
if (++clientHeaderCount === 2) {
bothHeadersReceived.resolve();
}
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-header-validation.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
},
onheaders: mustCall(function(headers) {
// Client should also receive lowercased response header names.
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/html');
assert.strictEqual(headers['x-response-header'], 'ResponseValue');

Expand DownExpand Up@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '204');
assert.strictEqual(headers[':status'], 204);
}),
});

Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-quic-h3-informational-headers.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
assert.ok(msg.stream, 'stream.info should include stream');
assert.ok(msg.session, 'stream.info should include session');
assert.ok(msg.headers, 'stream.info should include headers');
assert.strictEqual(msg.headers[':status'], '103');
assert.strictEqual(msg.headers[':status'], 103);
}));

// quic.stream.headers also fires for the final response headers.
Expand DownExpand Up@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
oninfo: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '103');
assert.strictEqual(headers[':status'], 103);
assert.strictEqual(headers.link, '</style.css>; rel=preload; as=style');
clientInfoReceived.resolve();
}),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -107,7 +107,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the final (initial) headers, not 1xx.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-origin.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ const decoder = new TextDecoder();
':authority': 'example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -173,7 +173,7 @@ const decoder = new TextDecoder();
':authority': 'custom-port.example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-pending-stream.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-filehandle.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -76,7 +76,7 @@ writeFileSync(testFile, testContent);
},
body: fh,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-request.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ const stream = await clientSession.createBidirectionalStream({
},
body: encoder.encode(requestBody),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
10 changes: 5 additions & 5 deletions test/parallel/test-quic-h3-priority.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -67,7 +67,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: false,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -85,7 +85,7 @@ const decoder = new TextDecoder();
priority: 'low',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream2.priority, { level: 'low', incremental: true });
Expand All@@ -99,7 +99,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream3.priority, { level: 'default', incremental: false });
Expand All@@ -113,7 +113,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
// Default priority initially.
Expand DownExpand Up@@ -215,7 +215,7 @@ const decoder = new TextDecoder();
},
body: encoder.encode('signal'),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream.priority, { level: 'default', incremental: false });
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-qpack-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function makeRequest(clientSession, path) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
const body = await bytes(stream);
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-request-response.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,7 +93,7 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -106,7 +106,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the buffered response headers.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-quic-h3-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,7 @@ const decoder = new TextDecoder();
'x-second': 'two',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -129,7 +129,7 @@ const decoder = new TextDecoder();
'x-long': longValue,
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -185,7 +185,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
64 changes: 64 additions & 0 deletions test/parallel/test-quic-h3-status-code-type.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
// Flags: --experimental-quic --experimental-stream-iter --no-warnings

// Verify incoming :status is exposed as a number, matching HTTP/2 behavior.
// See https://github.com/nodejs/node/issues/63557

import { hasQuic, skip, mustCall } from '../common/index.mjs';
import assert from 'node:assert';
import * as fixtures from '../common/fixtures.mjs';

if (!hasQuic) {
skip('QUIC is not enabled');
}

const { listen, connect } = await import('node:quic');
const { createPrivateKey } = await import('node:crypto');

const key = createPrivateKey(fixtures.readKey('agent1-key.pem'));
const cert = fixtures.readKey('agent1-cert.pem');

const codes = [200, 204, 404];
let serverResponses = 0;
const serverDone = Promise.withResolvers();

const serverEndpoint = await listen(mustCall(async (ss) => {
ss.onstream = mustCall(() => {
if (++serverResponses === codes.length) {
ss.close();
serverDone.resolve();
}
}, codes.length);
}), {
sni: { '*': { keys: [key], certs: [cert] } },
onheaders: mustCall(function() {
const status = codes[serverResponses - 1];
this.sendHeaders({ ':status': String(status) }, { terminal: true });
this.writer.endSync();
}, codes.length),
});

const clientSession = await connect(serverEndpoint.address, {
servername: 'localhost',
verifyPeer: 'manual',
});
await clientSession.opened;

for (const expected of codes) {
const stream = await clientSession.createBidirectionalStream({
headers: {
':method': 'GET',
':path': '/',
':scheme': 'https',
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(typeof headers[':status'], 'number');
assert.strictEqual(headers[':status'], expected);
}),
});
await stream.closed;
}

await serverDone.promise;
await clientSession.close();
await serverEndpoint.close();
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/api/quic.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3990,8 +3990,9 @@ A few things to note:
the request is `HEADERS` followed by `END_STREAM`.
* The `onheaders` callback receives the response pseudo-headers and
regular headers in a single object with lowercase string keys.
After the callback returns, the same object is also accessible
via [`stream.headers`][].
For incoming headers, the `:status` pseudo-header is converted to
a `number`, matching HTTP/2 behavior. After the callback returns,
the same object is also accessible via [`stream.headers`][].
* Reading `for await (const chunks of stream)` consumes the response
body. Each iteration yields a `Uint8Array[]` batch of chunks.
* HTTP semantic helpers (URL parsing, method/status validation,
Expand Down
15 changes: 10 additions & 5 deletions lib/internal/quic/quic.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
assert(pairs.length % 2 === 0);
const block = { __proto__: null };
for (let n = 0; n + 1 < pairs.length; n += 2) {
if (block[pairs[n]] !== undefined) {
if (ArrayIsArray(block[pairs[n]])) {
ArrayPrototypePush(block[pairs[n]], pairs[n + 1]);
const name = pairs[n];
let value = pairs[n + 1];
// Match HTTP/2 behavior: incoming :status is exposed as a number.
if (name === ':status')
value |= 0;
if (block[name] !== undefined) {
if (ArrayIsArray(block[name])) {
ArrayPrototypePush(block[name], value);
} else {
block[pairs[n]] = [block[pairs[n]], pairs[n + 1]];
block[name] = [block[name], value];
}
} else {
block[pairs[n]] = pairs[n + 1];
block[name] = value;
}
}
return block;
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-callback-errors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
ontrailers: mustCall(function() {
throw new Error('ontrailers sync error');
Expand DownExpand Up@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-close-behavior.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-concurrent-requests.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
headersReceived.resolve();
}),
});
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-datagram.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-error-codes.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-goaway.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
await clientSession.opened;

const onClientHeaders = mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
if (++clientHeaderCount === 2) {
bothHeadersReceived.resolve();
}
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-header-validation.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
},
onheaders: mustCall(function(headers) {
// Client should also receive lowercased response header names.
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/html');
assert.strictEqual(headers['x-response-header'], 'ResponseValue');

Expand DownExpand Up@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '204');
assert.strictEqual(headers[':status'], 204);
}),
});

Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-quic-h3-informational-headers.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
assert.ok(msg.stream, 'stream.info should include stream');
assert.ok(msg.session, 'stream.info should include session');
assert.ok(msg.headers, 'stream.info should include headers');
assert.strictEqual(msg.headers[':status'], '103');
assert.strictEqual(msg.headers[':status'], 103);
}));

// quic.stream.headers also fires for the final response headers.
Expand DownExpand Up@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
oninfo: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '103');
assert.strictEqual(headers[':status'], 103);
assert.strictEqual(headers.link, '</style.css>; rel=preload; as=style');
clientInfoReceived.resolve();
}),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -107,7 +107,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the final (initial) headers, not 1xx.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-origin.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ const decoder = new TextDecoder();
':authority': 'example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -173,7 +173,7 @@ const decoder = new TextDecoder();
':authority': 'custom-port.example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-pending-stream.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-filehandle.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -76,7 +76,7 @@ writeFileSync(testFile, testContent);
},
body: fh,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-request.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ const stream = await clientSession.createBidirectionalStream({
},
body: encoder.encode(requestBody),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
10 changes: 5 additions & 5 deletions test/parallel/test-quic-h3-priority.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -67,7 +67,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: false,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -85,7 +85,7 @@ const decoder = new TextDecoder();
priority: 'low',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream2.priority, { level: 'low', incremental: true });
Expand All@@ -99,7 +99,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream3.priority, { level: 'default', incremental: false });
Expand All@@ -113,7 +113,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
// Default priority initially.
Expand DownExpand Up@@ -215,7 +215,7 @@ const decoder = new TextDecoder();
},
body: encoder.encode('signal'),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream.priority, { level: 'default', incremental: false });
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-qpack-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function makeRequest(clientSession, path) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
const body = await bytes(stream);
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-request-response.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,7 +93,7 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -106,7 +106,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the buffered response headers.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-quic-h3-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,7 @@ const decoder = new TextDecoder();
'x-second': 'two',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -129,7 +129,7 @@ const decoder = new TextDecoder();
'x-long': longValue,
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -185,7 +185,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
64 changes: 64 additions & 0 deletions test/parallel/test-quic-h3-status-code-type.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
// Flags: --experimental-quic --experimental-stream-iter --no-warnings

// Verify incoming :status is exposed as a number, matching HTTP/2 behavior.
// See https://github.com/nodejs/node/issues/63557

import { hasQuic, skip, mustCall } from '../common/index.mjs';
import assert from 'node:assert';
import * as fixtures from '../common/fixtures.mjs';

if (!hasQuic) {
skip('QUIC is not enabled');
}

const { listen, connect } = await import('node:quic');
const { createPrivateKey } = await import('node:crypto');

const key = createPrivateKey(fixtures.readKey('agent1-key.pem'));
const cert = fixtures.readKey('agent1-cert.pem');

const codes = [200, 204, 404];
let serverResponses = 0;
const serverDone = Promise.withResolvers();

const serverEndpoint = await listen(mustCall(async (ss) => {
ss.onstream = mustCall(() => {
if (++serverResponses === codes.length) {
ss.close();
serverDone.resolve();
}
}, codes.length);
}), {
sni: { '*': { keys: [key], certs: [cert] } },
onheaders: mustCall(function() {
const status = codes[serverResponses - 1];
this.sendHeaders({ ':status': String(status) }, { terminal: true });
this.writer.endSync();
}, codes.length),
});

const clientSession = await connect(serverEndpoint.address, {
servername: 'localhost',
verifyPeer: 'manual',
});
await clientSession.opened;

for (const expected of codes) {
const stream = await clientSession.createBidirectionalStream({
headers: {
':method': 'GET',
':path': '/',
':scheme': 'https',
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(typeof headers[':status'], 'number');
assert.strictEqual(headers[':status'], expected);
}),
});
await stream.closed;
}

await serverDone.promise;
await clientSession.close();
await serverEndpoint.close();
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/api/quic.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3990,8 +3990,9 @@ A few things to note:
the request is `HEADERS` followed by `END_STREAM`.
* The `onheaders` callback receives the response pseudo-headers and
regular headers in a single object with lowercase string keys.
After the callback returns, the same object is also accessible
via [`stream.headers`][].
For incoming headers, the `:status` pseudo-header is converted to
a `number`, matching HTTP/2 behavior. After the callback returns,
the same object is also accessible via [`stream.headers`][].
* Reading `for await (const chunks of stream)` consumes the response
body. Each iteration yields a `Uint8Array[]` batch of chunks.
* HTTP semantic helpers (URL parsing, method/status validation,
Expand Down
15 changes: 10 additions & 5 deletions lib/internal/quic/quic.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
assert(pairs.length % 2 === 0);
const block = { __proto__: null };
for (let n = 0; n + 1 < pairs.length; n += 2) {
if (block[pairs[n]] !== undefined) {
if (ArrayIsArray(block[pairs[n]])) {
ArrayPrototypePush(block[pairs[n]], pairs[n + 1]);
const name = pairs[n];
let value = pairs[n + 1];
// Match HTTP/2 behavior: incoming :status is exposed as a number.
if (name === ':status')
value |= 0;
if (block[name] !== undefined) {
if (ArrayIsArray(block[name])) {
ArrayPrototypePush(block[name], value);
} else {
block[pairs[n]] = [block[pairs[n]], pairs[n + 1]];
block[name] = [block[name], value];
}
} else {
block[pairs[n]] = pairs[n + 1];
block[name] = value;
}
}
return block;
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-callback-errors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
ontrailers: mustCall(function() {
throw new Error('ontrailers sync error');
Expand DownExpand Up@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-close-behavior.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-concurrent-requests.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
headersReceived.resolve();
}),
});
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-datagram.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-error-codes.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-goaway.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
await clientSession.opened;

const onClientHeaders = mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
if (++clientHeaderCount === 2) {
bothHeadersReceived.resolve();
}
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-header-validation.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
},
onheaders: mustCall(function(headers) {
// Client should also receive lowercased response header names.
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/html');
assert.strictEqual(headers['x-response-header'], 'ResponseValue');

Expand DownExpand Up@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '204');
assert.strictEqual(headers[':status'], 204);
}),
});

Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-quic-h3-informational-headers.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
assert.ok(msg.stream, 'stream.info should include stream');
assert.ok(msg.session, 'stream.info should include session');
assert.ok(msg.headers, 'stream.info should include headers');
assert.strictEqual(msg.headers[':status'], '103');
assert.strictEqual(msg.headers[':status'], 103);
}));

// quic.stream.headers also fires for the final response headers.
Expand DownExpand Up@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
oninfo: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '103');
assert.strictEqual(headers[':status'], 103);
assert.strictEqual(headers.link, '</style.css>; rel=preload; as=style');
clientInfoReceived.resolve();
}),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -107,7 +107,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the final (initial) headers, not 1xx.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-origin.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ const decoder = new TextDecoder();
':authority': 'example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -173,7 +173,7 @@ const decoder = new TextDecoder();
':authority': 'custom-port.example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-pending-stream.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-filehandle.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -76,7 +76,7 @@ writeFileSync(testFile, testContent);
},
body: fh,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-request.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ const stream = await clientSession.createBidirectionalStream({
},
body: encoder.encode(requestBody),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
10 changes: 5 additions & 5 deletions test/parallel/test-quic-h3-priority.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -67,7 +67,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: false,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -85,7 +85,7 @@ const decoder = new TextDecoder();
priority: 'low',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream2.priority, { level: 'low', incremental: true });
Expand All@@ -99,7 +99,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream3.priority, { level: 'default', incremental: false });
Expand All@@ -113,7 +113,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
// Default priority initially.
Expand DownExpand Up@@ -215,7 +215,7 @@ const decoder = new TextDecoder();
},
body: encoder.encode('signal'),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream.priority, { level: 'default', incremental: false });
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-qpack-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function makeRequest(clientSession, path) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
const body = await bytes(stream);
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-request-response.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,7 +93,7 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -106,7 +106,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the buffered response headers.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-quic-h3-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,7 @@ const decoder = new TextDecoder();
'x-second': 'two',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -129,7 +129,7 @@ const decoder = new TextDecoder();
'x-long': longValue,
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -185,7 +185,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
64 changes: 64 additions & 0 deletions test/parallel/test-quic-h3-status-code-type.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
// Flags: --experimental-quic --experimental-stream-iter --no-warnings

// Verify incoming :status is exposed as a number, matching HTTP/2 behavior.
// See https://github.com/nodejs/node/issues/63557

import { hasQuic, skip, mustCall } from '../common/index.mjs';
import assert from 'node:assert';
import * as fixtures from '../common/fixtures.mjs';

if (!hasQuic) {
skip('QUIC is not enabled');
}

const { listen, connect } = await import('node:quic');
const { createPrivateKey } = await import('node:crypto');

const key = createPrivateKey(fixtures.readKey('agent1-key.pem'));
const cert = fixtures.readKey('agent1-cert.pem');

const codes = [200, 204, 404];
let serverResponses = 0;
const serverDone = Promise.withResolvers();

const serverEndpoint = await listen(mustCall(async (ss) => {
ss.onstream = mustCall(() => {
if (++serverResponses === codes.length) {
ss.close();
serverDone.resolve();
}
}, codes.length);
}), {
sni: { '*': { keys: [key], certs: [cert] } },
onheaders: mustCall(function() {
const status = codes[serverResponses - 1];
this.sendHeaders({ ':status': String(status) }, { terminal: true });
this.writer.endSync();
}, codes.length),
});

const clientSession = await connect(serverEndpoint.address, {
servername: 'localhost',
verifyPeer: 'manual',
});
await clientSession.opened;

for (const expected of codes) {
const stream = await clientSession.createBidirectionalStream({
headers: {
':method': 'GET',
':path': '/',
':scheme': 'https',
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(typeof headers[':status'], 'number');
assert.strictEqual(headers[':status'], expected);
}),
});
await stream.closed;
}

await serverDone.promise;
await clientSession.close();
await serverEndpoint.close();
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/api/quic.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3990,8 +3990,9 @@ A few things to note:
the request is `HEADERS` followed by `END_STREAM`.
* The `onheaders` callback receives the response pseudo-headers and
regular headers in a single object with lowercase string keys.
After the callback returns, the same object is also accessible
via [`stream.headers`][].
For incoming headers, the `:status` pseudo-header is converted to
a `number`, matching HTTP/2 behavior. After the callback returns,
the same object is also accessible via [`stream.headers`][].
* Reading `for await (const chunks of stream)` consumes the response
body. Each iteration yields a `Uint8Array[]` batch of chunks.
* HTTP semantic helpers (URL parsing, method/status validation,
Expand Down
15 changes: 10 additions & 5 deletions lib/internal/quic/quic.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
assert(pairs.length % 2 === 0);
const block = { __proto__: null };
for (let n = 0; n + 1 < pairs.length; n += 2) {
if (block[pairs[n]] !== undefined) {
if (ArrayIsArray(block[pairs[n]])) {
ArrayPrototypePush(block[pairs[n]], pairs[n + 1]);
const name = pairs[n];
let value = pairs[n + 1];
// Match HTTP/2 behavior: incoming :status is exposed as a number.
if (name === ':status')
value |= 0;
if (block[name] !== undefined) {
if (ArrayIsArray(block[name])) {
ArrayPrototypePush(block[name], value);
} else {
block[pairs[n]] = [block[pairs[n]], pairs[n + 1]];
block[name] = [block[name], value];
}
} else {
block[pairs[n]] = pairs[n + 1];
block[name] = value;
}
}
return block;
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-callback-errors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
ontrailers: mustCall(function() {
throw new Error('ontrailers sync error');
Expand DownExpand Up@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-close-behavior.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-concurrent-requests.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
headersReceived.resolve();
}),
});
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-datagram.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-error-codes.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-goaway.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
await clientSession.opened;

const onClientHeaders = mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
if (++clientHeaderCount === 2) {
bothHeadersReceived.resolve();
}
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-header-validation.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
},
onheaders: mustCall(function(headers) {
// Client should also receive lowercased response header names.
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/html');
assert.strictEqual(headers['x-response-header'], 'ResponseValue');

Expand DownExpand Up@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '204');
assert.strictEqual(headers[':status'], 204);
}),
});

Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-quic-h3-informational-headers.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
assert.ok(msg.stream, 'stream.info should include stream');
assert.ok(msg.session, 'stream.info should include session');
assert.ok(msg.headers, 'stream.info should include headers');
assert.strictEqual(msg.headers[':status'], '103');
assert.strictEqual(msg.headers[':status'], 103);
}));

// quic.stream.headers also fires for the final response headers.
Expand DownExpand Up@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
oninfo: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '103');
assert.strictEqual(headers[':status'], 103);
assert.strictEqual(headers.link, '</style.css>; rel=preload; as=style');
clientInfoReceived.resolve();
}),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -107,7 +107,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the final (initial) headers, not 1xx.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-origin.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ const decoder = new TextDecoder();
':authority': 'example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -173,7 +173,7 @@ const decoder = new TextDecoder();
':authority': 'custom-port.example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-pending-stream.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-filehandle.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -76,7 +76,7 @@ writeFileSync(testFile, testContent);
},
body: fh,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-request.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ const stream = await clientSession.createBidirectionalStream({
},
body: encoder.encode(requestBody),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
10 changes: 5 additions & 5 deletions test/parallel/test-quic-h3-priority.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -67,7 +67,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: false,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -85,7 +85,7 @@ const decoder = new TextDecoder();
priority: 'low',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream2.priority, { level: 'low', incremental: true });
Expand All@@ -99,7 +99,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream3.priority, { level: 'default', incremental: false });
Expand All@@ -113,7 +113,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
// Default priority initially.
Expand DownExpand Up@@ -215,7 +215,7 @@ const decoder = new TextDecoder();
},
body: encoder.encode('signal'),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream.priority, { level: 'default', incremental: false });
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-qpack-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function makeRequest(clientSession, path) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
const body = await bytes(stream);
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-request-response.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,7 +93,7 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -106,7 +106,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the buffered response headers.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-quic-h3-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,7 @@ const decoder = new TextDecoder();
'x-second': 'two',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -129,7 +129,7 @@ const decoder = new TextDecoder();
'x-long': longValue,
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -185,7 +185,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
64 changes: 64 additions & 0 deletions test/parallel/test-quic-h3-status-code-type.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
// Flags: --experimental-quic --experimental-stream-iter --no-warnings

// Verify incoming :status is exposed as a number, matching HTTP/2 behavior.
// See https://github.com/nodejs/node/issues/63557

import { hasQuic, skip, mustCall } from '../common/index.mjs';
import assert from 'node:assert';
import * as fixtures from '../common/fixtures.mjs';

if (!hasQuic) {
skip('QUIC is not enabled');
}

const { listen, connect } = await import('node:quic');
const { createPrivateKey } = await import('node:crypto');

const key = createPrivateKey(fixtures.readKey('agent1-key.pem'));
const cert = fixtures.readKey('agent1-cert.pem');

const codes = [200, 204, 404];
let serverResponses = 0;
const serverDone = Promise.withResolvers();

const serverEndpoint = await listen(mustCall(async (ss) => {
ss.onstream = mustCall(() => {
if (++serverResponses === codes.length) {
ss.close();
serverDone.resolve();
}
}, codes.length);
}), {
sni: { '*': { keys: [key], certs: [cert] } },
onheaders: mustCall(function() {
const status = codes[serverResponses - 1];
this.sendHeaders({ ':status': String(status) }, { terminal: true });
this.writer.endSync();
}, codes.length),
});

const clientSession = await connect(serverEndpoint.address, {
servername: 'localhost',
verifyPeer: 'manual',
});
await clientSession.opened;

for (const expected of codes) {
const stream = await clientSession.createBidirectionalStream({
headers: {
':method': 'GET',
':path': '/',
':scheme': 'https',
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(typeof headers[':status'], 'number');
assert.strictEqual(headers[':status'], expected);
}),
});
await stream.closed;
}

await serverDone.promise;
await clientSession.close();
await serverEndpoint.close();
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/api/quic.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3990,8 +3990,9 @@ A few things to note:
the request is `HEADERS` followed by `END_STREAM`.
* The `onheaders` callback receives the response pseudo-headers and
regular headers in a single object with lowercase string keys.
After the callback returns, the same object is also accessible
via [`stream.headers`][].
For incoming headers, the `:status` pseudo-header is converted to
a `number`, matching HTTP/2 behavior. After the callback returns,
the same object is also accessible via [`stream.headers`][].
* Reading `for await (const chunks of stream)` consumes the response
body. Each iteration yields a `Uint8Array[]` batch of chunks.
* HTTP semantic helpers (URL parsing, method/status validation,
Expand Down
15 changes: 10 additions & 5 deletions lib/internal/quic/quic.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
assert(pairs.length % 2 === 0);
const block = { __proto__: null };
for (let n = 0; n + 1 < pairs.length; n += 2) {
if (block[pairs[n]] !== undefined) {
if (ArrayIsArray(block[pairs[n]])) {
ArrayPrototypePush(block[pairs[n]], pairs[n + 1]);
const name = pairs[n];
let value = pairs[n + 1];
// Match HTTP/2 behavior: incoming :status is exposed as a number.
if (name === ':status')
value |= 0;
if (block[name] !== undefined) {
if (ArrayIsArray(block[name])) {
ArrayPrototypePush(block[name], value);
} else {
block[pairs[n]] = [block[pairs[n]], pairs[n + 1]];
block[name] = [block[name], value];
}
} else {
block[pairs[n]] = pairs[n + 1];
block[name] = value;
}
}
return block;
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-callback-errors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
ontrailers: mustCall(function() {
throw new Error('ontrailers sync error');
Expand DownExpand Up@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-close-behavior.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-concurrent-requests.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
headersReceived.resolve();
}),
});
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-datagram.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-error-codes.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-goaway.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
await clientSession.opened;

const onClientHeaders = mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
if (++clientHeaderCount === 2) {
bothHeadersReceived.resolve();
}
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-header-validation.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
},
onheaders: mustCall(function(headers) {
// Client should also receive lowercased response header names.
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/html');
assert.strictEqual(headers['x-response-header'], 'ResponseValue');

Expand DownExpand Up@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '204');
assert.strictEqual(headers[':status'], 204);
}),
});

Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-quic-h3-informational-headers.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
assert.ok(msg.stream, 'stream.info should include stream');
assert.ok(msg.session, 'stream.info should include session');
assert.ok(msg.headers, 'stream.info should include headers');
assert.strictEqual(msg.headers[':status'], '103');
assert.strictEqual(msg.headers[':status'], 103);
}));

// quic.stream.headers also fires for the final response headers.
Expand DownExpand Up@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
oninfo: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '103');
assert.strictEqual(headers[':status'], 103);
assert.strictEqual(headers.link, '</style.css>; rel=preload; as=style');
clientInfoReceived.resolve();
}),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -107,7 +107,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the final (initial) headers, not 1xx.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-origin.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ const decoder = new TextDecoder();
':authority': 'example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -173,7 +173,7 @@ const decoder = new TextDecoder();
':authority': 'custom-port.example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-pending-stream.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-filehandle.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -76,7 +76,7 @@ writeFileSync(testFile, testContent);
},
body: fh,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-request.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ const stream = await clientSession.createBidirectionalStream({
},
body: encoder.encode(requestBody),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
10 changes: 5 additions & 5 deletions test/parallel/test-quic-h3-priority.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -67,7 +67,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: false,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -85,7 +85,7 @@ const decoder = new TextDecoder();
priority: 'low',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream2.priority, { level: 'low', incremental: true });
Expand All@@ -99,7 +99,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream3.priority, { level: 'default', incremental: false });
Expand All@@ -113,7 +113,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
// Default priority initially.
Expand DownExpand Up@@ -215,7 +215,7 @@ const decoder = new TextDecoder();
},
body: encoder.encode('signal'),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream.priority, { level: 'default', incremental: false });
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-qpack-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function makeRequest(clientSession, path) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
const body = await bytes(stream);
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-request-response.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,7 +93,7 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -106,7 +106,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the buffered response headers.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-quic-h3-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,7 @@ const decoder = new TextDecoder();
'x-second': 'two',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -129,7 +129,7 @@ const decoder = new TextDecoder();
'x-long': longValue,
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -185,7 +185,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
64 changes: 64 additions & 0 deletions test/parallel/test-quic-h3-status-code-type.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
// Flags: --experimental-quic --experimental-stream-iter --no-warnings

// Verify incoming :status is exposed as a number, matching HTTP/2 behavior.
// See https://github.com/nodejs/node/issues/63557

import { hasQuic, skip, mustCall } from '../common/index.mjs';
import assert from 'node:assert';
import * as fixtures from '../common/fixtures.mjs';

if (!hasQuic) {
skip('QUIC is not enabled');
}

const { listen, connect } = await import('node:quic');
const { createPrivateKey } = await import('node:crypto');

const key = createPrivateKey(fixtures.readKey('agent1-key.pem'));
const cert = fixtures.readKey('agent1-cert.pem');

const codes = [200, 204, 404];
let serverResponses = 0;
const serverDone = Promise.withResolvers();

const serverEndpoint = await listen(mustCall(async (ss) => {
ss.onstream = mustCall(() => {
if (++serverResponses === codes.length) {
ss.close();
serverDone.resolve();
}
}, codes.length);
}), {
sni: { '*': { keys: [key], certs: [cert] } },
onheaders: mustCall(function() {
const status = codes[serverResponses - 1];
this.sendHeaders({ ':status': String(status) }, { terminal: true });
this.writer.endSync();
}, codes.length),
});

const clientSession = await connect(serverEndpoint.address, {
servername: 'localhost',
verifyPeer: 'manual',
});
await clientSession.opened;

for (const expected of codes) {
const stream = await clientSession.createBidirectionalStream({
headers: {
':method': 'GET',
':path': '/',
':scheme': 'https',
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(typeof headers[':status'], 'number');
assert.strictEqual(headers[':status'], expected);
}),
});
await stream.closed;
}

await serverDone.promise;
await clientSession.close();
await serverEndpoint.close();
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doc/api/quic.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -3990,8 +3990,9 @@ A few things to note:
the request is `HEADERS` followed by `END_STREAM`.
* The `onheaders` callback receives the response pseudo-headers and
regular headers in a single object with lowercase string keys.
After the callback returns, the same object is also accessible
via [`stream.headers`][].
For incoming headers, the `:status` pseudo-header is converted to
a `number`, matching HTTP/2 behavior. After the callback returns,
the same object is also accessible via [`stream.headers`][].
* Reading `for await (const chunks of stream)` consumes the response
body. Each iteration yields a `Uint8Array[]` batch of chunks.
* HTTP semantic helpers (URL parsing, method/status validation,
Expand Down
15 changes: 10 additions & 5 deletions lib/internal/quic/quic.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -1285,14 +1285,19 @@ function parseHeaderPairs(pairs) {
assert(pairs.length % 2 === 0);
const block = { __proto__: null };
for (let n = 0; n + 1 < pairs.length; n += 2) {
if (block[pairs[n]] !== undefined) {
if (ArrayIsArray(block[pairs[n]])) {
ArrayPrototypePush(block[pairs[n]], pairs[n + 1]);
const name = pairs[n];
let value = pairs[n + 1];
// Match HTTP/2 behavior: incoming :status is exposed as a number.
if (name === ':status')
value |= 0;
if (block[name] !== undefined) {
if (ArrayIsArray(block[name])) {
ArrayPrototypePush(block[name], value);
} else {
block[pairs[n]] = [block[pairs[n]], pairs[n + 1]];
block[name] = [block[name], value];
}
} else {
block[pairs[n]] = pairs[n + 1];
block[name] = value;
}
}
return block;
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-callback-errors.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -151,7 +151,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
ontrailers: mustCall(function() {
throw new Error('ontrailers sync error');
Expand DownExpand Up@@ -265,7 +265,7 @@ async function makeServer(onheadersHandler, extraOpts = {}) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-close-behavior.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -74,7 +74,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-concurrent-requests.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,7 @@ const requests = paths.map(mustCall(async (path) => {
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
headersReceived.resolve();
}),
});
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-datagram.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -87,7 +87,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -151,7 +151,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-error-codes.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -106,7 +106,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-goaway.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -78,7 +78,7 @@ dc.subscribe('quic.session.goaway', mustCall((msg) => {
await clientSession.opened;

const onClientHeaders = mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
if (++clientHeaderCount === 2) {
bothHeadersReceived.resolve();
}
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-header-validation.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -91,7 +91,7 @@ const decoder = new TextDecoder();
},
onheaders: mustCall(function(headers) {
// Client should also receive lowercased response header names.
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/html');
assert.strictEqual(headers['x-response-header'], 'ResponseValue');

Expand DownExpand Up@@ -148,7 +148,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall((headers) => {
assert.strictEqual(headers[':status'], '204');
assert.strictEqual(headers[':status'], 204);
}),
});

Expand Down
8 changes: 4 additions & 4 deletions test/parallel/test-quic-h3-informational-headers.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,7 +34,7 @@ dc.subscribe('quic.stream.info', mustCall((msg) => {
assert.ok(msg.stream, 'stream.info should include stream');
assert.ok(msg.session, 'stream.info should include session');
assert.ok(msg.headers, 'stream.info should include headers');
assert.strictEqual(msg.headers[':status'], '103');
assert.strictEqual(msg.headers[':status'], 103);
}));

// quic.stream.headers also fires for the final response headers.
Expand DownExpand Up@@ -89,12 +89,12 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
oninfo: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '103');
assert.strictEqual(headers[':status'], 103);
assert.strictEqual(headers.link, '</style.css>; rel=preload; as=style');
clientInfoReceived.resolve();
}),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -107,7 +107,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the final (initial) headers, not 1xx.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-origin.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ const decoder = new TextDecoder();
':authority': 'example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -173,7 +173,7 @@ const decoder = new TextDecoder();
':authority': 'custom-port.example.com',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-pending-stream.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,7 +64,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-filehandle.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -76,7 +76,7 @@ writeFileSync(testFile, testContent);
},
body: fh,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-post-request.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ const stream = await clientSession.createBidirectionalStream({
},
body: encoder.encode(requestBody),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
clientHeadersReceived.resolve();
}),
});
Expand Down
10 changes: 5 additions & 5 deletions test/parallel/test-quic-h3-priority.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -67,7 +67,7 @@ const decoder = new TextDecoder();
priority: 'high',
incremental: false,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand All@@ -85,7 +85,7 @@ const decoder = new TextDecoder();
priority: 'low',
incremental: true,
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream2.priority, { level: 'low', incremental: true });
Expand All@@ -99,7 +99,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream3.priority, { level: 'default', incremental: false });
Expand All@@ -113,7 +113,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
// Default priority initially.
Expand DownExpand Up@@ -215,7 +215,7 @@ const decoder = new TextDecoder();
},
body: encoder.encode('signal'),
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
assert.deepStrictEqual(stream.priority, { level: 'default', incremental: false });
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-quic-h3-qpack-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,7 +35,7 @@ async function makeRequest(clientSession, path) {
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});
const body = await bytes(stream);
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-quic-h3-request-response.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -93,7 +93,7 @@ const stream = await clientSession.createBidirectionalStream({
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
assert.strictEqual(headers['content-type'], 'text/plain');
clientHeadersReceived.resolve();
}),
Expand All@@ -106,7 +106,7 @@ const body = await bytes(stream);
assert.strictEqual(decoder.decode(body), responseBody);

// stream.headers should return the buffered response headers.
assert.strictEqual(stream.headers[':status'], '200');
assert.strictEqual(stream.headers[':status'], 200);

await Promise.all([stream.closed, serverDone.promise]);
await clientSession.close();
Expand Down
6 changes: 3 additions & 3 deletions test/parallel/test-quic-h3-settings.mjs
Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,7 @@ const decoder = new TextDecoder();
'x-second': 'two',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -129,7 +129,7 @@ const decoder = new TextDecoder();
'x-long': longValue,
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand DownExpand Up@@ -185,7 +185,7 @@ const decoder = new TextDecoder();
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(headers[':status'], '200');
assert.strictEqual(headers[':status'], 200);
}),
});

Expand Down
64 changes: 64 additions & 0 deletions test/parallel/test-quic-h3-status-code-type.mjs
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
// Flags: --experimental-quic --experimental-stream-iter --no-warnings

// Verify incoming :status is exposed as a number, matching HTTP/2 behavior.
// See https://github.com/nodejs/node/issues/63557

import { hasQuic, skip, mustCall } from '../common/index.mjs';
import assert from 'node:assert';
import * as fixtures from '../common/fixtures.mjs';

if (!hasQuic) {
skip('QUIC is not enabled');
}

const { listen, connect } = await import('node:quic');
const { createPrivateKey } = await import('node:crypto');

const key = createPrivateKey(fixtures.readKey('agent1-key.pem'));
const cert = fixtures.readKey('agent1-cert.pem');

const codes = [200, 204, 404];
let serverResponses = 0;
const serverDone = Promise.withResolvers();

const serverEndpoint = await listen(mustCall(async (ss) => {
ss.onstream = mustCall(() => {
if (++serverResponses === codes.length) {
ss.close();
serverDone.resolve();
}
}, codes.length);
}), {
sni: { '*': { keys: [key], certs: [cert] } },
onheaders: mustCall(function() {
const status = codes[serverResponses - 1];
this.sendHeaders({ ':status': String(status) }, { terminal: true });
this.writer.endSync();
}, codes.length),
});

const clientSession = await connect(serverEndpoint.address, {
servername: 'localhost',
verifyPeer: 'manual',
});
await clientSession.opened;

for (const expected of codes) {
const stream = await clientSession.createBidirectionalStream({
headers: {
':method': 'GET',
':path': '/',
':scheme': 'https',
':authority': 'localhost',
},
onheaders: mustCall(function(headers) {
assert.strictEqual(typeof headers[':status'], 'number');
assert.strictEqual(headers[':status'], expected);
}),
});
await stream.closed;
}

await serverDone.promise;
await clientSession.close();
await serverEndpoint.close();
Loading
Loading