Skip to content

src: merge CreateEnvironment() overloads - #63596

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
addaleax:abi-break-CreateEnvironment
Jun 4, 2026
Merged

src: merge CreateEnvironment() overloads#63596
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
addaleax:abi-break-CreateEnvironment

Conversation

@addaleax

@addaleaxaddaleax commented May 27, 2026

Copy link
Copy Markdown
Member

API-compatible, but ABI-breaking, so done separately from the original 3090def.

@addaleaxaddaleax added c++ Issues and PRs that require attention from people who are familiar with C++. semver-major PRs that contain breaking changes and should be released in the next major version. labels May 27, 2026
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label May 27, 2026
@addaleax
addaleaxforce-pushed the abi-break-CreateEnvironment branch from 23c5506 to 37016f3CompareMay 27, 2026 09:04
@addaleaxaddaleax changed the title src: merge CreateEnvironment() implementationssrc: merge CreateEnvironment() overloadsMay 27, 2026
@codecov

codecovBot commented May 27, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.32%. Comparing base (8257091) to head (a21167c).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #63596 +/- ##
=======================================
Coverage 90.32% 90.32% =======================================
Files 730 730 Lines 234671 234662 -9 Branches 43946 43958 +12 =======================================
+ Hits 211965 211967 +2 
Misses 14423 14423 + Partials 8283 8272 -11
Files with missing linesCoverage Δ
src/api/environment.cc78.72% <ø> (-0.30%)⬇️
src/node.h92.30% <ø> (ø)

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mertcanaltin
mertcanaltin approved these changes May 27, 2026
View reviewed changes

@mertcanaltinmertcanaltin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@legendecas

legendecas commented May 27, 2026

Copy link
Copy Markdown
Member

The linter error should be fixed with #63598 landed on the main branch. Would you mind rebasing on top of the main branch?

@addaleax
src: merge CreateEnvironment() overloads
a21167c
API-compatible, but ABI-breaking, so done separately from the
original 3090def.
Signed-off-by: Anna Henningsen <anna@addaleax.net>
@addaleax

addaleax commented May 27, 2026

Copy link
Copy Markdown
MemberAuthor

@legendecas Thank you, done!

@addaleax
addaleaxforce-pushed the abi-break-CreateEnvironment branch from 37016f3 to a21167cCompareMay 27, 2026 19:20
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2026
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2026
@nodejs-github-bot

nodejs-github-bot commented May 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73795/

@nodejs-github-bot

nodejs-github-bot commented May 28, 2026•
edited by addaleax
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73803/ (💚)

@addaleax

addaleax commented Jun 3, 2026

Copy link
Copy Markdown
MemberAuthor

@nodejs/tsc This is technically semver-major because of the ABI change so needs another TSC approval

gurgunday
gurgunday approved these changes Jun 3, 2026
View reviewed changes

@gurgundaygurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgundaygurgunday added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 3, 2026
@addaleaxaddaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2026
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 2d0c926 into nodejs:mainJun 4, 2026
77 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Landed in 2d0c926

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@legendecaslegendecaslegendecas approved these changes
@gurgundaygurgundaygurgunday approved these changes
+1 more reviewer
@mertcanaltinmertcanaltinmertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.semver-majorPRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@addaleax@legendecas@nodejs-github-bot@anonrig@mertcanaltin@gurgunday