Skip to content

stream: fix lint error - #63598

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:fix-lint
May 27, 2026
Merged

stream: fix lint error#63598
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:fix-lint

Conversation

@aduh95

@aduh95aduh95 commented May 27, 2026

Copy link
Copy Markdown
Contributor

Introduced by #63555

@aduh95
stream: fix lint error
99819e0
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
aduh95 requested a review from trivikrMay 27, 2026 09:54
@aduh95aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label May 27, 2026
@nodejs-github-bot

nodejs-github-bot commented May 27, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@github-actions

github-actionsBot commented May 27, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels May 27, 2026
@aduh95aduh95 removed the needs-ci PRs that need a full CI run. label May 27, 2026
@codecov

codecovBot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.27%. Comparing base (83991ba) to head (99819e0).

Additional details and impacted files
@@ Coverage Diff @@## main #63598 +/- ##
==========================================
- Coverage 90.32% 90.27% -0.05% 
==========================================
Files 730 728 -2 Lines 234669 233565 -1104 Branches 43948 43790 -158 ==========================================
- Hits 211958 210853 -1105 - Misses 14438 14511 +73 + Partials 8273 8201 -72
Files with missing linesCoverage Δ
lib/internal/streams/iter/push.js91.57% <100.00%> (ø)

... and 135 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
aduh95 merged commit 2cdea86 into nodejs:mainMay 27, 2026
45 of 46 checks passed
@aduh95
aduh95 deleted the fix-lint branch May 27, 2026 11:38
@legendecaslegendecas mentioned this pull request May 27, 2026
Merged
aduh95 added a commit that referenced this pull request May 28, 2026
@aduh95
stream: fix lint error (#63598)
6081abb
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #63598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mattias Buelens <mattias@buelens.com>
@github-actionsgithub-actionsBot mentioned this pull request May 30, 2026
Merged
@aduh95aduh95 added the backported-to-v26.x PRs backported to the v26.x-staging branch. label May 30, 2026
aduh95 added a commit that referenced this pull request May 30, 2026
@aduh95
stream: fix lint error
70ba8be
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #63598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mattias Buelens <mattias@buelens.com>
@aduh95aduh95 mentioned this pull request Jul 22, 2026
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Jul 30, 2026
@aduh95
stream: fix lint error
8215e7a
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#63598
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mattias Buelens <mattias@buelens.com>
aduh95 added a commit that referenced this pull request Aug 6, 2026
@aduh95
stream: fix lint error
5e2b4c4
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #63598
Backport-PR-URL: #64675
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattiasBuelensMattiasBuelensMattiasBuelens approved these changes
@lpincalpincalpinca approved these changes
@trivikrtrivikrAwaiting requested review from trivikr

Assignees

No one assigned

Labels

backported-to-v26.xPRs backported to the v26.x-staging branch.fast-trackPRs that do not need to wait for 48 hours to land.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@nodejs-github-bot@MattiasBuelens@lpinca