Skip to content

[v24.x] src: allow empty --experimental-config-file - #63659

Open
marco-ippolito wants to merge 3 commits into
nodejs:v24.x-stagingfrom
marco-ippolito:backport-stuff
Open

[v24.x] src: allow empty --experimental-config-file#63659
marco-ippolito wants to merge 3 commits into
nodejs:v24.x-stagingfrom
marco-ippolito:backport-stuff

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented May 30, 2026

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

nodejs-github-bot commented May 30, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/security-wg
  • @nodejs/startup
  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels May 30, 2026
@marco-ippolito
src: rename config file testRunner to test
289399f
PR-URL: nodejs#60798
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
@marco-ippolito
src: add test flag to config file
4869f1f
PR-URL: nodejs#60798
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
@marco-ippolito
src: allow empty --experimental-config-file
c28ce0d
PR-URL: nodejs#61610
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
@codecov

codecovBot commented May 30, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.63636% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.95%. Comparing base (b881658) to head (c28ce0d).
⚠️ Report is 432 commits behind head on v24.x-staging.

Files with missing linesPatch %Lines
src/node_config_file.cc85.71%3 Missing and 1 partial ⚠️
src/node.cc87.50%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## v24.x-staging #63659 +/- ##
=================================================
+ Coverage 89.92% 89.95% +0.03% 
=================================================
Files 686 686 Lines 208389 208997 +608 Branches 40077 40185 +108 =================================================
+ Hits 187387 187998 +611 - Misses 13238 13239 +1 + Partials 7764 7760 -4
Files with missing linesCoverage Δ
lib/internal/process/pre_execution.js98.53% <100.00%> (+0.66%)⬆️
lib/internal/test_runner/runner.js93.70% <100.00%> (+0.51%)⬆️
src/node_config_file.h100.00% <100.00%> (ø)
src/node_options.cc76.37% <100.00%> (+0.09%)⬆️
src/node_options.h97.90% <ø> (+0.02%)⬆️
src/node.cc74.57% <87.50%> (+0.13%)⬆️
src/node_config_file.cc81.53% <85.71%> (+0.76%)⬆️

... and 53 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74970/

aduh95
aduh95 approved these changes Jul 21, 2026
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@marco-ippolito@aduh95
src: rename config file testRunner to test
f07d766
PR-URL: #60798
Backport-PR-URL: #63659
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@marco-ippolito@aduh95
src: add test flag to config file
4b70bcf
PR-URL: #60798
Backport-PR-URL: #63659
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
@marco-ippolito@aduh95
src: allow empty --experimental-config-file
a446480
PR-URL: #61610
Backport-PR-URL: #63659
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/74979/

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 21, 2026
aduh95 pushed a commit that referenced this pull request Jul 22, 2026
@marco-ippolito@aduh95
src: rename config file testRunner to test
6fee228
PR-URL: #60798
Backport-PR-URL: #63659
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 22, 2026
@marco-ippolito@aduh95
src: add test flag to config file
5da2acf
PR-URL: #60798
Backport-PR-URL: #63659
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 22, 2026
@marco-ippolito@aduh95
src: allow empty --experimental-config-file
4e90b7a
PR-URL: #61610
Backport-PR-URL: #63659
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@marco-ippolito@aduh95
src: rename config file testRunner to test
a642657
PR-URL: #60798
Backport-PR-URL: #63659
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@marco-ippolito@aduh95
src: add test flag to config file
d7946c9
PR-URL: #60798
Backport-PR-URL: #63659
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@marco-ippolito@aduh95
src: allow empty --experimental-config-file
7428b57
PR-URL: #61610
Backport-PR-URL: #63659
Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.v24.xIssues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marco-ippolito@nodejs-github-bot@aduh95