src: allow empty --experimental-config-file by marco-ippolito · Pull Request #61610 · nodejs/node

marco-ippolito · 2026-02-01T09:26:09Z

This PR makes --experimental-config-file accept no arg.
When no arg is passed, it will default to node.config.json.
--experimental-default-config-file is just an alias of --experimental-config-file.
The reason for this change is so when stable we can just remove --experimental-default-config-file and rename --experimental-config-file to --config-file.
Users can execute node with node --config-file index.js or node --config-file=foo.json index.js.

nodejs-github-bot · 2026-02-01T09:26:14Z

Review requested:

@nodejs/config

pmarchini

LGTM

nodejs-github-bot · 2026-02-01T09:52:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71151/

codecov · 2026-02-01T11:24:43Z

Codecov Report

❌ Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.69%. Comparing base (3f52482) to head (4bf9c84).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node.cc	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #61610 +/- ##
==========================================
- Coverage 91.55% 89.69% -1.87% 
==========================================
Files 356 706 +350 Lines 149601 218143 +68542 Branches 23395 41734 +18339 ==========================================
+ Hits 136967 195659 +58692 - Misses 12371 14412 +2041 - Partials 263 8072 +7809

Files with missing lines	Coverage Δ
lib/internal/process/pre_execution.js	`98.38% <100.00%> (+14.63%)`	⬆️
lib/internal/test_runner/runner.js	`93.67% <100.00%> (+0.31%)`	⬆️
src/node_config_file.cc	`83.73% <100.00%> (ø)`
src/node_config_file.h	`100.00% <100.00%> (ø)`
src/node_options.cc	`76.61% <100.00%> (ø)`
src/node_options.h	`98.00% <ø> (ø)`
src/node.cc	`76.90% <87.50%> (ø)`

... and 465 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-04-15T14:18:50Z

Failed to start CI

- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71151/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24459748339

github-actions · 2026-04-15T14:52:52Z

Failed to start CI

- Validating Jenkins credentials
✔ Jenkins credentials valid
- Querying data for job/node-test-pull-request/71151/
[SyntaxError: Unexpected token '<', ..." https://github.com/nodejs/node/actions/runs/24461444173

nodejs-github-bot · 2026-04-15T14:55:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72703/

nodejs-github-bot · 2026-04-16T04:56:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/72710/

nodejs-github-bot · 2026-04-16T06:31:37Z

Landed in 2071c44

PR-URL: #61610 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Notable changes: buffer: * (SEMVER-MINOR) add `end` parameter (Robert Nagy) #62390 crypto: * (SEMVER-MINOR) accept key data in `crypto.diffieHellman()` and cleanup DH jobs (Filip Skokan) #62527 * (SEMVER-MINOR) implement `randomUUIDv7()` (nabeel378) #62553 debugger: * (SEMVER-MINOR) add edit-free runtime expression probes to `node inspect` (Joyee Cheung) #62713 fs: * (SEMVER-MINOR) add `signal` option to `fs.stat()` (Mert Can Altin) #57775 * (SEMVER-MINOR) expose frsize field in statfs (Jinho Jang) #62277 http: * (SEMVER-MINOR) harden `ClientRequest` options merge (Matteo Collina) #63082 * (SEMVER-MINOR) add `req.signal` to `IncomingMessage` (Akshat) #62541 lib,src,test,doc: * (SEMVER-MINOR) add `node:ffi` module (Colin Ihrig) #62072 process: * (SEMVER-MINOR) throw on `execve(2)` failure instead of aborting (Bryan English) #62878 src: * (SEMVER-MINOR) allow empty `--experimental-config-file` (Marco Ippolito) #61610 stream: * (SEMVER-MINOR) propagate destruction in `duplexPair` (Ahmed Elhor) #61098 test_runner: * (SEMVER-MINOR) align mock timeout api (sangwook) #62820 * (SEMVER-MINOR) add mock-timers support for `AbortSignal.timeout` (DeveloperViraj) #60751 * (SEMVER-MINOR) support test order randomization (Pietro Marchini) #61747 util: * (SEMVER-MINOR) colorize text with hex colors (Guilherme Araújo) #61556 PR-URL: #63137

aduh95 · 2026-05-09T09:45:58Z

 const result = await spawnPromisified(process.execPath, [
- '--experimental-config-file',
- 'i-do-not-exist.json',
+ '--experimental-config-file=i-do-not-exist.json',


I don't really get this change, is it an unrelated no-op? It's making the change not land cleanly on v24.x-staging, should I simply forgo those?

PR-URL: nodejs#61610 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com>

PR-URL: #61610 Backport-PR-URL: #63659 Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Notable changes: buffer: * (SEMVER-MINOR) implement `blob.textStream()` (Matthew Aitken) #64036 deps: * (SEMVER-MINOR) update OpenSSL build config to support compression (Tim Perry) #62217 doc: * (SEMVER-MINOR) update `blockList` stability status to release candidate (alphaleadership) #63050 * mark `stream.compose` stable (Matteo Collina) #62562 esm: * (SEMVER-MINOR) add `--experimental-import-text` flag (Efe) #62300 fs: * (SEMVER-MINOR) support caller-supplied `readFile()` buffers (Matteo Collina) #63634 http: * (SEMVER-MINOR) add `httpValidation` option to configure header value validation (RajeshKumar11) #61597 net: * (SEMVER-MINOR) support `TCP_KEEPINTVL` and `TCP_KEEPCNT` in setKeepAlive (Guy Bedford) #63825 perf_hooks: * (SEMVER-MINOR) sample delay per event loop iteration (Pablo Erhard) #62935 src: * (SEMVER-MINOR) allow empty `--experimental-config-file` (Marco Ippolito) #61610 stream: * (SEMVER-MINOR) expose `ReadableStreamTee` (Matteo Collina) #64195 tls: * (SEMVER-MINOR) report negotiated TLS groups (Filip Skokan) #64119 * (SEMVER-MINOR) add `certificateCompression` option (Tim Perry) #62217 PR-URL: #64654

PR-URL: #61610 Backport-PR-URL: #63659 Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Notable changes: buffer: * (SEMVER-MINOR) implement `blob.textStream()` (Matthew Aitken) #64036 deps: * (SEMVER-MINOR) update OpenSSL build config to support compression (Tim Perry) #62217 doc: * (SEMVER-MINOR) update `blockList` stability status to release candidate (alphaleadership) #63050 * mark `stream.compose` stable (Matteo Collina) #62562 esm: * (SEMVER-MINOR) add `--experimental-import-text` flag (Efe) #62300 fs: * (SEMVER-MINOR) support caller-supplied `readFile()` buffers (Matteo Collina) #63634 http: * (SEMVER-MINOR) add `httpValidation` option to configure header value validation (RajeshKumar11) #61597 net: * (SEMVER-MINOR) support `TCP_KEEPINTVL` and `TCP_KEEPCNT` in `setKeepAlive` (Guy Bedford) #63825 perf_hooks: * (SEMVER-MINOR) sample delay per event loop iteration (Pablo Erhard) #62935 src: * (SEMVER-MINOR) allow empty `--experimental-config-file` (Marco Ippolito) #61610 stream: * (SEMVER-MINOR) expose `ReadableStreamTee` (Matteo Collina) #64195 tls: * (SEMVER-MINOR) report negotiated TLS groups (Filip Skokan) #64119 * (SEMVER-MINOR) add `certificateCompression` option (Tim Perry) #62217 PR-URL: #64654

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 1, 2026

marco-ippolito force-pushed the default-config-json branch 2 times, most recently from 775234b to 9b00cedCompare February 1, 2026 09:36

pmarchini approved these changes Feb 1, 2026
View reviewed changes

pmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2026

MoLow approved these changes Feb 1, 2026
View reviewed changes

marco-ippolito added the semver-minor PRs that contain new features and should be released in the next minor version. label Feb 1, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2026

marco-ippolito force-pushed the default-config-json branch 4 times, most recently from 3dc9b42 to 2356e3aCompare February 1, 2026 14:35

pmarchini reviewed Feb 1, 2026
View reviewed changes

Comment threadtest/parallel/test-runner-flag-propagation.js

marco-ippolito force-pushed the default-config-json branch from 2356e3a to e53ba12Compare February 4, 2026 15:35

marco-ippolito force-pushed the default-config-json branch 3 times, most recently from bef68d1 to 5ce1d98Compare April 15, 2026 10:48

src: allow empty --experimental-config-file
4bf9c84

marco-ippolito force-pushed the default-config-json branch from 5ce1d98 to 4bf9c84Compare April 15, 2026 11:15

pmarchini approved these changes Apr 15, 2026
View reviewed changes

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2026

github-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 15, 2026

marco-ippolito removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Apr 15, 2026

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2026

github-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 15, 2026

marco-ippolito removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Apr 15, 2026

marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 16, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 16, 2026

nodejs-github-bot merged commit 2071c44 into nodejs:mainApr 16, 2026
71 checks passed

aduh95 pushed a commit that referenced this pull request May 5, 2026
src: allow empty --experimental-config-file
8273682
PR-URL: #61610 Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

aduh95 mentioned this pull request May 5, 2026
2026-05-07, Version 26.1.0 #63137
Merged

aduh95 reviewed May 9, 2026
View reviewed changes

aduh95 pushed a commit that referenced this pull request Jul 21, 2026
src: allow empty --experimental-config-file
a446480
PR-URL: #61610 Backport-PR-URL: #63659 Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 mentioned this pull request Jul 21, 2026
2026-07-22, Version 24.19.0 'Krypton' (LTS) #64654
Merged

aduh95 pushed a commit that referenced this pull request Jul 22, 2026
src: allow empty --experimental-config-file
4e90b7a
PR-URL: #61610 Backport-PR-URL: #63659 Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 pushed a commit that referenced this pull request Jul 30, 2026
src: allow empty --experimental-config-file
7428b57
PR-URL: #61610 Backport-PR-URL: #63659 Signed-off-by: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Navigation Menu

Uh oh!

Uh oh!

src: allow empty --experimental-config-file - #61610

src: allow empty --experimental-config-file#61610
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:default-config-json

marco-ippolito commented Feb 1, 2026

Uh oh!

nodejs-github-bot commented Feb 1, 2026

Uh oh!

pmarchini left a comment

Uh oh!

nodejs-github-bot commented Feb 1, 2026

Uh oh!

codecovBot commented Feb 1, 2026•
edited
Loading

Uh oh!

Uh oh!

github-actionsBot commented Apr 15, 2026

Uh oh!

github-actionsBot commented Apr 15, 2026

Uh oh!

nodejs-github-bot commented Apr 15, 2026

Uh oh!

nodejs-github-bot commented Apr 16, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 16, 2026

Uh oh!

aduh95May 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

marco-ippolito commented Feb 1, 2026

Uh oh!

nodejs-github-bot commented Feb 1, 2026

Uh oh!

pmarchini left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Feb 1, 2026

Uh oh!

codecovBot commented Feb 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actionsBot commented Apr 15, 2026

Uh oh!

github-actionsBot commented Apr 15, 2026

Uh oh!

nodejs-github-bot commented Apr 15, 2026

Uh oh!

nodejs-github-bot commented Apr 16, 2026

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 16, 2026

Uh oh!

aduh95May 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecovBot commented Feb 1, 2026•
edited
Loading