Uh oh!
There was an error while loading. Please reload this page.
tools: remove default parameters from lint rule - #6411
Closed
Trott wants to merge 1 commit into
Closed
Conversation
The CI server uses system Node.js for linting, which is currently v5.x. So default parameters are not supported there. This change removes the default parameters.
Trott
commented
Apr 27, 2016
MemberAuthor
mscdex
commented
Apr 27, 2016
Contributor
LGTM |
MemberAuthor
Arguments for expediting this:
Arguments against expediting this:
|
2 tasks
cjihrig
commented
Apr 27, 2016
Contributor
LGTM |
1 similar comment
ChALkeR
commented
Apr 27, 2016
Member
LGTM |
evanlucas
commented
Apr 27, 2016
Contributor
LGTM, probably needs a CI run though :] |
jasnell
commented
Apr 27, 2016
Member
@Trott is this a problem for v5 and v4 also? |
Trott
commented
Apr 27, 2016
MemberAuthor
@jasnell It was already removed in the backport for LTS so it shouldn't be a problem for v4. It's unclear to me when/how this would land in v5, so I'm less certain there. |
jbergstroem
commented
Apr 27, 2016
Member
LGTM |
Trott
commented
Apr 28, 2016
MemberAuthor
Trott
commented
Apr 29, 2016
MemberAuthor
Only CI failure is a known unrelated problem. |
jasnell
commented
Apr 29, 2016
Member
LGTM |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Apr 29, 2016
The CI server uses system Node.js for linting, which is currently v5.x. So default parameters are not supported there. This change removes the default parameters. PR-URL: nodejs#6411 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Apr 29, 2016
MemberAuthor
Landed in c8e137b |
Fishrock123 pushed a commit
that referenced
this pull request
May 4, 2016
The CI server uses system Node.js for linting, which is currently v5.x. So default parameters are not supported there. This change removes the default parameters. PR-URL: #6411 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 4, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tools
Description of change
The CI server uses system Node.js for linting, which is currently v5.x.
So default parameters are not supported there. This change removes the
default parameters.