Uh oh!
There was an error while loading. Please reload this page.
tools: fix exit code when linting from CI - #6412
Closed
mscdex wants to merge 1 commit into
Closed
Conversation
mscdex
commented
Apr 27, 2016
ContributorAuthor
/cc @jbergstroem |
Trott
commented
Apr 27, 2016
Member
This probably should only land after #6411 lands or the CI lint VM is updated to Node.js 6.0.0. |
Before this, if there were lint errors reported by `make jslint-ci`, the process would still exit with an exit code of zero. This commit fixes that to align with `make jslint` (exit with non-zero on lint errors).
mscdexforce-pushed
the
tools-fix-jslint-ci-exit-code
branch
from
April 27, 2016 06:01
7052427 to
c4d4423Comparemscdex
commented
Apr 27, 2016
ContributorAuthor
I've pushed some additional changes to exit early when a worker dies unexpectedly (e.g. in case of a |
phillipj
commented
Apr 27, 2016
Member
LGTM |
2 similar comments
jbergstroem
commented
Apr 27, 2016
Member
LGTM |
santigimeno
commented
Apr 28, 2016
Member
LGTM |
jasnell
commented
Apr 28, 2016
Member
CI: https://ci.nodejs.org/job/node-test-pull-request/2413/ |
Trott
commented
Apr 28, 2016
Member
jasnell
commented
Apr 28, 2016
Member
thanks for the heads up. may want to indicate that in the PR description :-) |
Trott
commented
Apr 28, 2016
Member
@jasnell Additional complication is that requirement is only true on master. v4.x can get this PR right now and it will be just fine. |
Trott
commented
Apr 29, 2016
Member
#6411 landed so this can be run in CI now. |
Trott pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 29, 2016
Before this, if there were lint errors reported by `make jslint-ci`, the process would still exit with an exit code of zero. This commit fixes that to align with `make jslint` (exit with non-zero on lint errors). PR-URL: nodejs#6412 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Phillip Johnsen <johphi@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott
commented
Apr 29, 2016
Member
Landed in 1264cec |
Fishrock123 pushed a commit
that referenced
this pull request
May 4, 2016
Before this, if there were lint errors reported by `make jslint-ci`, the process would still exit with an exit code of zero. This commit fixes that to align with `make jslint` (exit with non-zero on lint errors). PR-URL: #6412 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Phillip Johnsen <johphi@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced May 4, 2016
joelostrowski pushed a commit
to joelostrowski/node
that referenced
this pull request
May 4, 2016
Before this, if there were lint errors reported by `make jslint-ci`, the process would still exit with an exit code of zero. This commit fixes that to align with `make jslint` (exit with non-zero on lint errors). PR-URL: nodejs#6412 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Phillip Johnsen <johphi@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
commented
Jun 1, 2016
Contributor
@mscdex safe to assume this would be included with other linter changes if we were to backport? |
mscdex
commented
Jun 1, 2016
ContributorAuthor
@thealphanerd if by 'linter changes' you mean the addition of |
MylesBorins
commented
Jun 2, 2016
Contributor
that is what I mean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
Before this, if there were lint errors reported by
make jslint-ci, the process would still exit with an exit code of zero.This commit fixes that to align with
make jslint(exit with code 1 on lint errors).