net: support TCP handle transfer on Windows by mcollina · Pull Request #64460 · nodejs/node

mcollina · 2026-07-12T19:21:24Z

Adds Windows support for transferring TCP handles across worker threads.

Fixes: #64456

Signed-off-by: Matteo Collina <hello@matteocollina.com>

nodejs-github-bot · 2026-07-12T19:21:29Z

Review requested:

@nodejs/net

codecov · 2026-07-12T20:59:19Z

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.24%. Comparing base (dca0fd1) to head (060c604).
⚠️ Report is 122 commits behind head on main.

Files with missing lines	Patch %	Lines
src/tcp_wrap.cc	50.00%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #64460 +/- ##
==========================================
- Coverage 90.24% 90.24% -0.01% 
==========================================
Files 741 741 Lines 241603 241596 -7 Branches 45523 45530 +7 ==========================================
- Hits 218038 218022 -16 + Misses 15109 15100 -9 - Partials 8456 8474 +18

Files with missing lines	Coverage Δ
lib/internal/errors.js	`97.71% <ø> (-0.01%)`	⬇️
lib/net.js	`94.54% <ø> (+0.19%)`	⬆️
src/tcp_wrap.h	`57.14% <100.00%> (+3.29%)`	⬆️
src/tcp_wrap.cc	`68.85% <50.00%> (ø)`

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-07-13T08:55:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74774/

nodejs-github-bot · 2026-07-13T18:49:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/74791/

mcollina · 2026-07-14T15:38:10Z

DO you know why the test-internt job is failing?

nodejs-github-bot · 2026-07-14T19:53:40Z

Commit Queue failed

- Loading data for nodejs/node/pull/64460
✔ Done loading data for nodejs/node/pull/64460
----------------------------------- PR info ------------------------------------
Title net: support TCP handle transfer on Windows (#64460)
Author Matteo Collina <matteo.collina@gmail.com> (@mcollina)
Branch mcollina:tcp-transfer-windows -> nodejs:main
Labels c++, lib / src, needs-ci
Commits 1
- net: support TCP handle transfer on Windows
Committers 1
- Matteo Collina <hello@matteocollina.com>
PR-URL: https://github.com/nodejs/node/pull/64460
Fixes: https://github.com/nodejs/node/issues/64456
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64460
Fixes: https://github.com/nodejs/node/issues/64456
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 12 Jul 2026 19:21:24 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/64460#pullrequestreview-4680793259
✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/64460#pullrequestreview-4682937899
✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/64460#pullrequestreview-4695725787
✘ 1 GitHub CI job(s) failed:
✘ - test-internet: FAILURE (https://github.com/nodejs/node/actions/runs/29205638124/job/87130276315)
ℹ Last Full PR CI on 2026-07-13T18:49:42Z: https://ci.nodejs.org/job/node-test-pull-request/74791/
- Querying data for job/node-test-pull-request/74791/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/29363329109

Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64460Fixes: #64456 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

guybedford · 2026-07-25T00:26:32Z

I went ahead and landed this in fdcb1de, given the known CI issue was resolved today and that a rerun would require a full cycle here.

Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64460Fixes: #64456 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

net: support TCP handle transfer on Windows
060c604
Signed-off-by: Matteo Collina <hello@matteocollina.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 12, 2026

jasnell approved these changes Jul 12, 2026
View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 13, 2026

StefanStojanovic approved these changes Jul 13, 2026
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 13, 2026

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 14, 2026

marco-ippolito approved these changes Jul 14, 2026
View reviewed changes

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 14, 2026

guybedford added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 24, 2026

guybedford closed this Jul 25, 2026

guybedford mentioned this pull request Jul 25, 2026
net: support sending net.BoundSocket to worker threads and child processes #64725
Open

github-actionsBot mentioned this pull request Aug 4, 2026
2026-08-05, Version 26.7.0 (Current) #65027
Merged

Navigation Menu

Uh oh!

Uh oh!

net: support TCP handle transfer on Windows - #64460

net: support TCP handle transfer on Windows#64460
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:tcp-transfer-windows

mcollina commented Jul 12, 2026

Uh oh!

nodejs-github-bot commented Jul 12, 2026

Uh oh!

codecovBot commented Jul 12, 2026•
edited
Loading

Uh oh!

nodejs-github-bot commented Jul 13, 2026

Uh oh!

nodejs-github-bot commented Jul 13, 2026

Uh oh!

mcollina commented Jul 14, 2026

Uh oh!

nodejs-github-bot commented Jul 14, 2026

Uh oh!

guybedford commented Jul 25, 2026•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

mcollina commented Jul 12, 2026

Uh oh!

nodejs-github-bot commented Jul 12, 2026

Uh oh!

codecovBot commented Jul 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Jul 13, 2026

Uh oh!

nodejs-github-bot commented Jul 13, 2026

Uh oh!

mcollina commented Jul 14, 2026

Uh oh!

nodejs-github-bot commented Jul 14, 2026

Uh oh!

guybedford commented Jul 25, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecovBot commented Jul 12, 2026•
edited
Loading

guybedford commented Jul 25, 2026•
edited
Loading