deps: V8: backport 5177b10891e6 by avivkeller · Pull Request #64631 · nodejs/node

avivkeller · 2026-07-20T16:29:31Z

Original commit message:

fix(inspector): hold on to promises
Keep `m_evaluationResult` strong for evaluations
until the promise settles or the request is cancelled.
Bug: 536271637
Change-Id: If21cc4aa0ba6bb2e2722d5ee73eb7744a0ead207
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8123081
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#108874}

Refs: v8/v8@5177b10
Co-authored-by: avivkeller me@aviv.sh

nodejs-github-bot · 2026-07-20T16:29:37Z

Review requested:

@nodejs/gyp
@nodejs/security-wg
@nodejs/v8-update

legendecas · 2026-07-20T20:03:57Z

CI failure seems related to #64633.

avivkeller · 2026-07-27T05:24:03Z

cc @nodejs/repl @nodejs/v8 Ready for review, the upstream change has landed

avivkeller · 2026-07-27T05:29:00Z

Why didn't git node include the changeset 🤔 I'll re-write it manually.

Original commit message: fix(inspector): hold on to promises Keep `m_evaluationResult` strong for evaluations until the promise settles or the request is cancelled. Bug: 536271637 Change-Id: If21cc4aa0ba6bb2e2722d5ee73eb7744a0ead207 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8123081 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#108874} Refs: v8/v8@5177b10 Co-authored-by: avivkeller <me@aviv.sh>

Signed-off-by: avivkeller <me@aviv.sh>

codecov · 2026-07-27T08:23:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.15%. Comparing base (54a5095) to head (1c8abc1).
⚠️ Report is 56 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #64631 +/- ##
==========================================
+ Coverage 90.14% 90.15% +0.01% 
==========================================
Files 744 744 Lines 242518 242518 Branches 45685 45695 +10 ==========================================
+ Hits 218611 218638 +27 + Misses 15396 15389 -7 + Partials 8511 8491 -20

see 29 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

avivkeller · 2026-07-30T19:26:57Z

Bump @nodejs/v8-update this resolves flaky tests

nodejs-github-bot · 2026-07-31T00:56:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75322/

nodejs-github-bot · 2026-07-31T00:56:13Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7293/

nodejs-github-bot · 2026-07-31T00:56:35Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7293/

nodejs-github-bot · 2026-07-31T00:56:40Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7293/

nodejs-github-bot · 2026-07-31T13:24:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75329/

nodejs-github-bot · 2026-07-31T18:21:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75339/

Original commit message: fix(inspector): hold on to promises Keep `m_evaluationResult` strong for evaluations until the promise settles or the request is cancelled. Bug: 536271637 Change-Id: If21cc4aa0ba6bb2e2722d5ee73eb7744a0ead207 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8123081 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#108874} Refs: v8/v8@5177b10 Co-authored-by: avivkeller <me@aviv.sh> PR-URL: #64631 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Signed-off-by: avivkeller <me@aviv.sh> PR-URL: #64631 Refs: v8/v8@5177b10 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

avivkeller · 2026-07-31T22:59:42Z

Landed in b7d29fe...8a1ca0f

Original commit message: fix(inspector): hold on to promises Keep `m_evaluationResult` strong for evaluations until the promise settles or the request is cancelled. Bug: 536271637 Change-Id: If21cc4aa0ba6bb2e2722d5ee73eb7744a0ead207 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8123081 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#108874} Refs: v8/v8@5177b10 Co-authored-by: avivkeller <me@aviv.sh> PR-URL: #64631 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Signed-off-by: avivkeller <me@aviv.sh> PR-URL: #64631 Refs: v8/v8@5177b10 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Original commit message: fix(inspector): hold on to promises Keep `m_evaluationResult` strong for evaluations until the promise settles or the request is cancelled. Bug: 536271637 Change-Id: If21cc4aa0ba6bb2e2722d5ee73eb7744a0ead207 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8123081 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#108874} Refs: v8/v8@5177b10 Co-authored-by: avivkeller <me@aviv.sh> PR-URL: nodejs#64631 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Original commit message: fix(inspector): hold on to promises Keep `m_evaluationResult` strong for evaluations until the promise settles or the request is cancelled. Bug: 536271637 Change-Id: If21cc4aa0ba6bb2e2722d5ee73eb7744a0ead207 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8123081 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#108874} Refs: v8/v8@5177b10 Co-authored-by: avivkeller <me@aviv.sh> PR-URL: #64631 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Signed-off-by: avivkeller <me@aviv.sh> PR-URL: #64631 Refs: v8/v8@5177b10 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Original commit message: fix(inspector): hold on to promises Keep `m_evaluationResult` strong for evaluations until the promise settles or the request is cancelled. Bug: 536271637 Change-Id: If21cc4aa0ba6bb2e2722d5ee73eb7744a0ead207 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8123081 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#108874} Refs: v8/v8@5177b10 Co-authored-by: avivkeller <me@aviv.sh> PR-URL: #64631 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Signed-off-by: avivkeller <me@aviv.sh> PR-URL: #64631 Refs: v8/v8@5177b10 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

avivkeller added the blocked PRs that are blocked by other issues or PRs. label Jul 20, 2026

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jul 20, 2026

avivkeller linked an issue Jul 20, 2026 that may be closed by this pull request
test/parallel/test-repl-user-error-handler is flaky #64595
Closed

avivkeller force-pushed the v8-backport-8123081 branch from 3f332e4 to 2ec3540Compare July 20, 2026 16:32

avivkeller added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jul 27, 2026

avivkeller force-pushed the v8-backport-8123081 branch from 2ec3540 to eb2eb4fCompare July 27, 2026 05:23

avivkeller added repl Issues and PRs related to the REPL subsystem. and removed blocked PRs that are blocked by other issues or PRs. labels Jul 27, 2026

avivkeller force-pushed the v8-backport-8123081 branch from eb2eb4f to c7fb243Compare July 27, 2026 05:26

avivkeller changed the title ~~deps: V8: backport 2d837cbc1ca2~~deps: V8: backport If21cc4aa0ba6Jul 27, 2026

avivkeller changed the title ~~deps: V8: backport If21cc4aa0ba6~~deps: V8: backport 5177b10891e6Jul 27, 2026

avivkeller added 2 commits July 26, 2026 22:54

test: remove test-repl-user-error-handler from flaky
1c8abc1
Signed-off-by: avivkeller <me@aviv.sh>

avivkeller force-pushed the v8-backport-8123081 branch from c7fb243 to 1c8abc1Compare July 27, 2026 05:54

This was referenced Jul 27, 2026
deps: update V8 to 14.9 #64784
Open
test/parallel/test-repl-user-error-handler is flaky #64595
Closed

avivkeller added the review wanted PRs that need reviews. label Jul 30, 2026

daeyeon approved these changes Jul 31, 2026
View reviewed changes

daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2026

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2026

avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 31, 2026

legendecas approved these changes Jul 31, 2026
View reviewed changes

avivkeller closed this Jul 31, 2026

github-actionsBot mentioned this pull request Aug 4, 2026
2026-08-05, Version 26.7.0 (Current) #65027
Merged

Uh oh!

Uh oh!

Conversation

avivkeller commented Jul 20, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 20, 2026

Uh oh!

legendecas commented Jul 20, 2026

Uh oh!

avivkeller commented Jul 27, 2026

Uh oh!

avivkeller commented Jul 27, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecovBot commented Jul 27, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

avivkeller commented Jul 30, 2026

Uh oh!

nodejs-github-bot commented Jul 31, 2026

Uh oh!

nodejs-github-bot commented Jul 31, 2026

Uh oh!

nodejs-github-bot commented Jul 31, 2026

Uh oh!

nodejs-github-bot commented Jul 31, 2026

Uh oh!

nodejs-github-bot commented Jul 31, 2026

Uh oh!

nodejs-github-bot commented Jul 31, 2026

Uh oh!

avivkeller commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

avivkeller commented Jul 20, 2026•
edited
Loading

avivkeller commented Jul 27, 2026•
edited
Loading

codecovBot commented Jul 27, 2026•
edited
Loading